Received-SPF: pass (google.com: domain of linux-kernel+bounces-52152-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 5 Feb 2024 08:37:48 +0100
From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, jiri@resnulli.us,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] Use KMEM_CACHE instead of kmem_cache_create
Message-ID: <ZcCQTPUoeqUeiQsN@mev-dev>
References: <20240205072013.427639-1-chentao@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240205072013.427639-1-chentao@kylinos.cn>

On Mon, Feb 05, 2024 at 03:20:07PM +0800, Kunwu Chan wrote:
> As Jiri Pirko suggests, 
You can add a suggested-by tag.

> I'm using a patchset to cleanup the same issues in the 'net' module.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
What about rest of the kmem_cache_create in net folder? (ex. fib_trie)

> Some cache names are changed to be the same as struct names. 
> This change is recorded in the changelog for easy reference.
> It's harmless cause it's used in /proc/slabinfo to identify this cache.
> 
> Kunwu Chan (6):
>   net: kcm: Simplify the allocation of slab caches
>   ip6mr: Simplify the allocation of slab caches in ip6_mr_init
>   ipmr: Simplify the allocation of slab caches
>   ipv4: Simplify the allocation of slab caches in ip_rt_init
>   tcp: Simplify the allocation of slab caches
>   ipv6: Simplify the allocation of slab caches
> 
>  net/ipv4/ipmr.c    |  5 +----
>  net/ipv4/route.c   |  5 ++---
>  net/ipv4/tcp.c     | 14 ++++----------
>  net/ipv6/ip6_fib.c |  6 ++----
>  net/ipv6/ip6mr.c   |  5 +----
>  net/kcm/kcmsock.c  |  8 ++------
>  6 files changed, 12 insertions(+), 31 deletions(-)
> 
> -- 
> 2.39.2

Changes looks fines, thanks
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
for whole series.

Thanks,
Michal