Received-SPF: pass (google.com: domain of linux-kernel+bounces-52223-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: John Ogness <john.ogness@linutronix.de>
To: Yicong Yang <yangyicong@huawei.com>, gregkh@linuxfoundation.org,
 jirislaby@kernel.org, tony@atomide.com, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com, tglx@linutronix.de,
 yangyicong@hisilicon.com, linuxarm@huawei.com, prime.zeng@hisilicon.com,
 jonathan.cameron@huawei.com, fanghao11@huawei.com
Subject: Re: [PATCH] serial: port: Don't suspend if the port is still busy
In-Reply-To: <20240204031957.58176-1-yangyicong@huawei.com>
References: <20240204031957.58176-1-yangyicong@huawei.com>
Date: Mon, 05 Feb 2024 09:53:05 +0106
Message-ID: <878r3zpaba.fsf@jogness.linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On 2024-02-04, Yicong Yang <yangyicong@huawei.com> wrote:
> diff --git a/drivers/tty/serial/serial_port.c b/drivers/tty/serial/serial_port.c
> index 88975a4df306..60d1eec6b6b7 100644
> --- a/drivers/tty/serial/serial_port.c
> +++ b/drivers/tty/serial/serial_port.c
> @@ -46,8 +46,28 @@ static int serial_port_runtime_resume(struct device *dev)
>  	return 0;
>  }
>  
> +static int serial_port_runtime_suspend(struct device *dev)
> +{
> +	struct serial_port_device *port_dev = to_serial_base_port_device(dev);
> +	struct uart_port *port;
> +	unsigned long flags;
> +
> +	port = port_dev->port;
> +
> +	if (port->flags & UPF_DEAD)
> +		return 0;
> +
> +	spin_lock_irqsave(&port->lock, flags);
> +	if (__serial_port_busy(port))
> +		pm_request_resume(dev);
> +	spin_unlock_irqrestore(&port->lock, flags);

Please use the wrapper functions for the uart port lock:

uart_port_lock_irqsave()
uart_port_unlock_irqrestore()

John Ogness