Received-SPF: pass (google.com: domain of linux-kernel+bounces-52226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2f43774a-16cf-412e-b4b7-840889bb796b@suse.cz>
Date: Mon, 5 Feb 2024 09:50:13 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm/slab: Add slabreclaim flag to slabinfo
To: Greg KH <gregkh@linuxfoundation.org>,
 Fangzheng Zhang <fangzheng.zhang@unisoc.com>
Cc: Christoph Lameter <cl@linux.com>, Pekka Enberg <penberg@kernel.org>,
 David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Fangzheng Zhang
 <fangzheng.zhang1003@gmail.com>, Yuming Han <yuming.han@unisoc.com>,
 Chunyan Zhang <zhang.lyra@gmail.com>
References: <20240131094442.28834-1-fangzheng.zhang@unisoc.com>
 <2024020441-version-chihuahua-1067@gregkh>
Content-Language: en-US
From: Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <2024020441-version-chihuahua-1067@gregkh>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2/4/24 14:09, Greg KH wrote:
> On Wed, Jan 31, 2024 at 05:44:42PM +0800, Fangzheng Zhang wrote:
>> In order to enhance slab debugging, we add slabreclaim flag to
>> slabinfo. Slab type is also an important analysis point in slabinfo
>> for per slab, when various problems such as memory leaks or memory
>> statistics occur.
>> 
>> Signed-off-by: Fangzheng Zhang <fangzheng.zhang@unisoc.com>
>> ---
>>  mm/slab_common.c | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>> 
>> diff --git a/mm/slab_common.c b/mm/slab_common.c
>> index 238293b1dbe1..aeeb2bfe6dda 100644
>> --- a/mm/slab_common.c
>> +++ b/mm/slab_common.c
>> @@ -1038,7 +1038,7 @@ static void print_slabinfo_header(struct seq_file *m)
>>  	seq_puts(m, "slabinfo - version: 2.1\n");
>>  	seq_puts(m, "# name            <active_objs> <num_objs> <objsize> <objperslab> <pagesperslab>");
>>  	seq_puts(m, " : tunables <limit> <batchcount> <sharedfactor>");
>> -	seq_puts(m, " : slabdata <active_slabs> <num_slabs> <sharedavail>");
>> +	seq_puts(m, " : slabdata <active_slabs> <num_slabs> <sharedavail> <slabreclaim>");
> 
> Doesn't this change the slabinfo version number above?  Where is this
> change documented so that userspace knows about it?

Yeah I was vary about this. Do the other longer-time-than-me slab
maintainers recall how we handled this in the past?
Also the information is already available, even if harder to gather, in the
file /sys/kernel/slab/$cache/reclaim_account

> thanks,
> 
> greg k-h