Received-SPF: pass (google.com: domain of linux-kernel+bounces-52234-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
CC: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>, <tony@atomide.com>,
	<linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
	<yangyicong@hisilicon.com>, <andriy.shevchenko@linux.intel.com>,
	<tglx@linutronix.de>, <linuxarm@huawei.com>, <prime.zeng@hisilicon.com>,
	<jonathan.cameron@huawei.com>, <fanghao11@huawei.com>
Subject: Re: [PATCH] serial: port: Don't suspend if the port is still busy
To: John Ogness <john.ogness@linutronix.de>
References: <20240204031957.58176-1-yangyicong@huawei.com>
 <878r3zpaba.fsf@jogness.linutronix.de>
From: Yicong Yang <yangyicong@huawei.com>
Message-ID: <d25d1d33-6a10-4e23-5ab2-f02ed4b72fac@huawei.com>
Date: Mon, 5 Feb 2024 17:00:11 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <878r3zpaba.fsf@jogness.linutronix.de>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On 2024/2/5 16:47, John Ogness wrote:
> On 2024-02-04, Yicong Yang <yangyicong@huawei.com> wrote:
>> diff --git a/drivers/tty/serial/serial_port.c b/drivers/tty/serial/serial_port.c
>> index 88975a4df306..60d1eec6b6b7 100644
>> --- a/drivers/tty/serial/serial_port.c
>> +++ b/drivers/tty/serial/serial_port.c
>> @@ -46,8 +46,28 @@ static int serial_port_runtime_resume(struct device *dev)
>>  	return 0;
>>  }
>>  
>> +static int serial_port_runtime_suspend(struct device *dev)
>> +{
>> +	struct serial_port_device *port_dev = to_serial_base_port_device(dev);
>> +	struct uart_port *port;
>> +	unsigned long flags;
>> +
>> +	port = port_dev->port;
>> +
>> +	if (port->flags & UPF_DEAD)
>> +		return 0;
>> +
>> +	spin_lock_irqsave(&port->lock, flags);
>> +	if (__serial_port_busy(port))
>> +		pm_request_resume(dev);
>> +	spin_unlock_irqrestore(&port->lock, flags);
> 
> Please use the wrapper functions for the uart port lock:
> 
> uart_port_lock_irqsave()
> uart_port_unlock_irqrestore()
> 

Sure. Thanks for the information.