Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2279228rdb; Mon, 5 Feb 2024 01:10:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IENP4BioZLXClVB/+eJXo6qGOtu3gs0uOcfSteTwtKhvp/xuJ+9LobddJ5+Av+XDorbCMUe X-Received: by 2002:a17:902:e752:b0:1d9:a3f4:6452 with SMTP id p18-20020a170902e75200b001d9a3f46452mr3779472plf.23.1707124226684; Mon, 05 Feb 2024 01:10:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707124226; cv=pass; d=google.com; s=arc-20160816; b=qCIaQBMLxV+nQ9ewk89KhSpmuiOaySvBUfKIJjojoRWS3Sv0AbY6+d7b79JTZF6C7E rVm+pbs4C0Vrnl0Y7keqYdbg4T14Jyi1aPxVbWtqcQNy79rppj4RcmAth/FylrzO6hwT l9iygfp63Puj/xBRmIjxBdI+0xV3JGiOMXoVxpHHzIIv/xNgWJ0xwMSVyF2yzLAqccJg Drd/Wl588fJi4jneZWbA8jACy8TKjjs7DHZg6gimEisknIuXcSvR3UJxo/kcwNAUFMPC B6pC6yzHJOKNJ5hd+h0tGEjTsXCcbCJvMPTffcnYjNlGD+JsO8fHBWRQxsKMDPn/5eu8 dHfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=s+csqZNeYkrIpb1E9IDQxL9nuwxhFuBXUexzaWPxbGg=; fh=+u/wvIiXyMRtc5S3+fFpCAOH89tEzzgW/BISFkZLXJk=; b=zqyhow9PyG2vO2Zs5QXgDPenKDFQEyRU39mCHgm1eq7//DUaAm7NDP8QPU7GAORF/u GW5Y4Y1iwvDVpqzjaemVZ+45udpLonVkpWE/hMRtI6iu41RF/E1ThoGNeL0sX2AZlq9p K8u2Y0lw7CnrRKb/vRhhh1fZnt3mfxFJwlOXw9RoUAVnzl93aMzoM7bWefYuxiMGJ2QC Ewric4GjSQ2praTvQmv9CY+gScCTvsuIx1c6EkRFWzVLCVWiSN3T7z8iEcrrQkqSi64j pi+h96hhB7t8AsvuaATdyjquGMegTsMC4ZZk3J4rMG7wLRBByD5YbwHIkl5R6wlf2NF4 GcYw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=Uw8jSUoF; arc=pass (i=1 spf=pass spfdomain=foss.st.com dkim=pass dkdomain=foss.st.com dmarc=pass fromdomain=foss.st.com); spf=pass (google.com: domain of linux-kernel+bounces-52258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52258-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com X-Forwarded-Encrypted: i=1; AJvYcCXRLwvNAdS2bp6Mu9gbmeyu2M+sECOkNaGpwmA+eBQPDRzxdk77AE+IAUTG4THU+09/+FL7hppg6nRMacsHvzEcv1wLJs0G5SSFUQi/Tg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id k24-20020a170902761800b001d93939c3b1si5906043pll.577.2024.02.05.01.10.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 01:10:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=Uw8jSUoF; arc=pass (i=1 spf=pass spfdomain=foss.st.com dkim=pass dkdomain=foss.st.com dmarc=pass fromdomain=foss.st.com); spf=pass (google.com: domain of linux-kernel+bounces-52258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52258-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 390552843B5 for ; Mon, 5 Feb 2024 09:10:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0F99C14002; Mon, 5 Feb 2024 09:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="Uw8jSUoF" Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1060D13FF5; Mon, 5 Feb 2024 09:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707124065; cv=none; b=MdoLWfVZxWcXuFepanZ4JananrcOqUxEBgpFa8E5Oo44Ifm0oHOPMpVUV9KYqcuLbhKPK1B9UeOTiJicBkzqFmV1Evbv7A1Mzm0RHQrs7969wKsyYpDJzooRXvr4aQZuuAYyw3LKUD+Xjy1Dv947CWa0PpPuszSXfOqLR7TWQEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707124065; c=relaxed/simple; bh=kQmqmHg5fshjsFYejINZNIdG6Su3JBwLNqost24IYRo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=Jfw6rcMBar7Nng4pWrxpfggAbNOBOovPzfsHgPd2Gtq349szUZA0MY4AFT4wU6QLBHdqcztCFrweZuqQKE7pmqDEsh7Ncz0FpUlsPmQ2dLojR8fLg4/jV75N7si5dOgoKRyvE6urzFRINgy0BNEYwUbbvipH0IgVX+6lq+QVneg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=Uw8jSUoF; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 4151eHjs015366; Mon, 5 Feb 2024 10:06:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=selector1; bh=s+csqZNeYkrIpb1E9IDQxL9nuwxhFuBXUexzaWPxbGg =; b=Uw8jSUoFDTOIjl/+f1zZdOBNUfca5a5l1WK+Cs9/U+KkzaWV09SQGZcBvPn mDykRDImcoiUxcFqoayFE+BXNDh5V0vEXmgblAXt3ZtzcyTZOrZZcs5c1endVF79 Q8SFLjTWZvM4pA1gTLHqgi49xWTIe/Jn7kg+kPkeTPQ6hQoWvTsBArHCb9wVEv5c ZPPqTxsGCPfB1d0z8gnSJ58U6au1zUccI50dSxwqMTJZBtFH4u8SkhqfZEdCO9Yx mBsY9lmzMzA7oNKMH8/m+xFcfL/VHke+e6hguPmoTDiIS3yGSb1kVpIAVM/yFGIw 88KLRQNsshd1vakTza/cV0wh91A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3w1ewnx0pk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Feb 2024 10:06:56 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4094D100065; Mon, 5 Feb 2024 10:06:55 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 34A8C29E60F; Mon, 5 Feb 2024 10:06:55 +0100 (CET) Received: from localhost (10.252.18.216) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 5 Feb 2024 10:06:54 +0100 From: Raphael Gallais-Pou Date: Mon, 5 Feb 2024 10:06:54 +0100 Subject: [PATCH 4/5] drm/panel: simple: fix flags on RK043FN48H Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20240205-ltdc_mp13-v1-4-072d24bf1b36@foss.st.com> References: <20240205-ltdc_mp13-v1-0-072d24bf1b36@foss.st.com> In-Reply-To: <20240205-ltdc_mp13-v1-0-072d24bf1b36@foss.st.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter CC: , , , , , Raphael Gallais-Pou X-Mailer: b4 0.12.4 X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-05_04,2024-01-31_01,2023-05-22_02 DISPLAY_FLAGS_SYNC_POSEDGE is missing in the flags on the default timings. When overriding the default mode with one described in the device tree, the mode does not get acked because of this missing flag. Moreover since the panel is driven by the positive edge it makes sense to add it here. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/panel/panel-simple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 2214cb09678c..7b286382ffb4 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -3523,7 +3523,8 @@ static const struct display_timing rocktech_rk043fn48h_timing = { .vfront_porch = { 1, 4, 4 }, .vsync_len = { 1, 10, 10 }, .flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW | - DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE, + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | + DISPLAY_FLAGS_SYNC_POSEDGE, }; static const struct panel_desc rocktech_rk043fn48h = { -- 2.25.1