Received-SPF: pass (google.com: domain of linux-kernel+bounces-52334-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <f00582bf4d19b539cc1427706ee9a07fd3992bc3.camel@gmail.com>
Subject: Re: [PATCH v7 01/39] ARM: ep93xx: Add terminator to
 gpiod_lookup_table
From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>, nikita.shubin@maquefel.me, 
	Arnd Bergmann
	 <arnd@arndb.de>
Cc: Hartley Sweeten <hsweeten@visionengravers.com>, Russell King
 <linux@armlinux.org.uk>, "Wu, Aaron" <Aaron.Wu@analog.com>, Olof Johansson
 <olof@lixom.net>, Lee Jones <lee@kernel.org>, Ralf Baechle
 <ralf@linux-mips.org>,  linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, Andy Shevchenko <andriy.shevchenko@intel.com>
Date: Mon, 05 Feb 2024 10:42:16 +0100
In-Reply-To: <CACRpkdYDmx9qrkCo5mad_w1e0MKNYrVirg=qi+R4Q907SLdRwg@mail.gmail.com>
References: <20240118-ep93xx-v7-0-d953846ae771@maquefel.me>
	 <20240118-ep93xx-v7-1-d953846ae771@maquefel.me>
	 <CACRpkdYDmx9qrkCo5mad_w1e0MKNYrVirg=qi+R4Q907SLdRwg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
Precedence: bulk
MIME-Version: 1.0

Hi Arnd and all,

On Fri, 2024-01-19 at 00:52 +0100, Linus Walleij wrote:
> On Thu, Jan 18, 2024 at 9:22=E2=80=AFAM Nikita Shubin via B4 Relay
> <devnull+nikita.shubin.maquefel.me@kernel.org> wrote:
>=20
> > From: Nikita Shubin <nikita.shubin@maquefel.me>
> >=20
> > Without the terminator, if a con_id is passed to gpio_find() that
> > does not exist in the lookup table the function will not stop looping
> > correctly, and eventually cause an oops.
> >=20
> > Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
> > Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
>=20
> Sorry, my bug...
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Cc: stable@vger.kernel.org
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

Arnd, could you please take this into arm-soc?
I can send a PR, but this probably makes little sense for one patch?

--=20
Alexander Sverdlin.