Received-SPF: pass (google.com: domain of linux-kernel+bounces-52373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
Precedence: bulk
MIME-Version: 1.0
Message-Id: <86ae775b-b3ab-45db-9541-95fcc0e17b5e@app.fastmail.com>
In-Reply-To: <f00582bf4d19b539cc1427706ee9a07fd3992bc3.camel@gmail.com>
References: <20240118-ep93xx-v7-0-d953846ae771@maquefel.me>
 <20240118-ep93xx-v7-1-d953846ae771@maquefel.me>
 <CACRpkdYDmx9qrkCo5mad_w1e0MKNYrVirg=qi+R4Q907SLdRwg@mail.gmail.com>
 <f00582bf4d19b539cc1427706ee9a07fd3992bc3.camel@gmail.com>
Date: Mon, 05 Feb 2024 10:02:06 +0000
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
 "Linus Walleij" <linus.walleij@linaro.org>,
 "Nikita Shubin" <nikita.shubin@maquefel.me>
Cc: "Hartley Sweeten" <hsweeten@visionengravers.com>,
 "Russell King" <linux@armlinux.org.uk>, "Wu, Aaron" <Aaron.Wu@analog.com>,
 "Olof Johansson" <olof@lixom.net>, "Lee Jones" <lee@kernel.org>,
 "Ralf Baechle" <ralf@linux-mips.org>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, "Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v7 01/39] ARM: ep93xx: Add terminator to gpiod_lookup_table
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 5, 2024, at 09:42, Alexander Sverdlin wrote:
> Hi Arnd and all,
>
> On Fri, 2024-01-19 at 00:52 +0100, Linus Walleij wrote:
>> On Thu, Jan 18, 2024 at 9:22=E2=80=AFAM Nikita Shubin via B4 Relay
>> <devnull+nikita.shubin.maquefel.me@kernel.org> wrote:
>>=20
>> > From: Nikita Shubin <nikita.shubin@maquefel.me>
>> >=20
>> > Without the terminator, if a con_id is passed to gpio_find() that
>> > does not exist in the lookup table the function will not stop loopi=
ng
>> > correctly, and eventually cause an oops.
>> >=20
>> > Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
>> > Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
>>=20
>> Sorry, my bug...
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Cc: stable@vger.kernel.org
> Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
>
> Arnd, could you please take this into arm-soc?
> I can send a PR, but this probably makes little sense for one patch?

I'm travelling at the moment, but can take it when I get back.

If you want to be sure it doesn't get lost, please send the
patch (with the Acks) to soc@kernel.org and it will end up
in patchwork.

   Arnd