Received-SPF: pass (google.com: domain of linux-kernel+bounces-52345-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b319f01721fba04cb91d4bc61db69894d0e9a0c9.camel@gmail.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: adc: ad7192: Add properties
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, David Lechner
	 <dlechner@baylibre.com>, Alisa-Dariana Roman <alisadariana@gmail.com>
Cc: Alisa-Dariana Roman <alisa.roman@analog.com>, Michael Hennerich
 <michael.hennerich@analog.com>, linux-iio@vger.kernel.org, 
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter
 Clausen <lars@metafoo.de>, Alexandru Tachici
 <alexandru.tachici@analog.com>,  Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
 Ceclan Dumitru <dumitru.ceclan@analog.com>
Date: Mon, 05 Feb 2024 10:50:55 +0100
In-Reply-To: <5bc2bd1e-16a8-4de4-bec6-9391addacc89@linaro.org>
References: <20231114200533.137995-1-alisa.roman@analog.com>
	 <20231114200533.137995-2-alisa.roman@analog.com>
	 <c6ca5a25-2d41-4a46-95a5-eb994c4cf529@linaro.org>
	 <09cc2ecb-b73f-495a-9196-dbb4899f4c85@gmail.com>
	 <CAMknhBFhr=qTd=nioq_m=icZZUfYWSq8Moy4A4RssvbcNoLNQg@mail.gmail.com>
	 <5bc2bd1e-16a8-4de4-bec6-9391addacc89@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-02-05 at 10:28 +0100, Krzysztof Kozlowski wrote:
> On 02/02/2024 23:20, David Lechner wrote:
> > > >=20
> > > > And this should be input clock.
> > > >=20
> > > > > +=C2=A0=C2=A0=C2=A0 type: boolean
> > > > > +
> > > > > +=C2=A0 adi,int-clock-output-enable:
> > > > > +=C2=A0=C2=A0=C2=A0 description: |
> > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Internal 4.92 MHz clock available=
 on MCLK2 pin.
> > > > > +=C2=A0=C2=A0=C2=A0 type: boolean
> > > >=20
> > > > This should be clock-cells and clock provider.
> > > >=20
> > > > Unless you are just documenting already used interface which you do=
 not
> > > > want to break...
> >=20
> > This property is already used in the mainline Linux driver, so sounds
> > like the "don't want to break it" case. But it would make sense to
> > deprecate this property and use standard clock provider bindings
> > instead.
>=20
> One could think like that, but what type of process would it create?
> Send driver changes WITHOUT binding, then document whatever crap you
> have saying "Linux already supports it!".
>=20
> Whenever such argument is used, I am repeating the same.
>=20
> Let's be more clear: NAK if this is clock provider and the only argument
> is that someone sneaked undocumented interface bypassing review.
>=20

Fair enough...=C2=A0

Alisa,

I guess you have two alternatives then:

1) Drop this patch;
2) Add proper clock provider properties.

I would obviously go with 2). You can then take care of backward compatibil=
ity in the
driver. Like, if clock-cells is present, ignore the legacy properties and p=
roperly
export the clocks we have in the device.

- Nuno S=C3=A1