Received-SPF: pass (google.com: domain of linux-kernel+bounces-52409-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <7e3b9556-f083-4c14-a48f-46242d1c744b@oracle.com>
Date: Mon, 5 Feb 2024 10:26:43 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 6/6] fs: xfs: Set FMODE_CAN_ATOMIC_WRITE for
 FS_XFLAG_ATOMICWRITES set
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com
References: <20240124142645.9334-1-john.g.garry@oracle.com>
 <20240124142645.9334-7-john.g.garry@oracle.com>
 <20240202180619.GK6184@frogsfrogsfrogs>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240202180619.GK6184@frogsfrogsfrogs>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?b3cvUGRaZ1V4ODk0QiswejFNVmNhRVBQaFVsejVxSUp5cWxwN2xpNXNMaFp5?=
 =?utf-8?B?ZWdqRXdxYU45NHU5Q2FJMUxHMC85RnpiVWNIejlhS3RaYnFvYXhhNGE2S2Np?=
 =?utf-8?B?TUFVR3dWd3hybzRXcC9aTTRTZ0FDU1ozck84NytkbU1CV2g4Zld3QzkyZ01M?=
 =?utf-8?B?N0J1cVEwNE5iOXlGTlM0Y1ZQL3V5dm9QZkkrMWtzUmlJSXpNSmQwanFmN2U4?=
 =?utf-8?B?R0xZOUpzRFhCTm5DbStXQzFkM0xxeFRCdWJoN2IrdEwzYitUd3lKRzNiMDUv?=
 =?utf-8?B?emxHRDR1OU5BZWtlMk9tVEVyb1J0YnpCSksrQzNHYWhCN3ViRkpzVVIyQmsz?=
 =?utf-8?B?VDNEY0ZWVUJQNmh4N0NuUGxJWU5rOXdSc0JCc0FjZmlFQm5ONWpQdFlrcjN6?=
 =?utf-8?B?VzA2U0x6K3BYMVM1Ujk1SExReC83SzZseWo3Q1lOYk92UUx0UEVSbDNuUkpM?=
 =?utf-8?B?NS9OWFh3N1pobldKWmtFSkYzR0dKSmZhK2xQS2V1YXhzOFNwN1JGVThnZVYz?=
 =?utf-8?B?cGxIa2JJYllnTG56amk0cWdhK0VaZDJSUHVKWld6WHducHZDeHNFZW14bWF1?=
 =?utf-8?B?bG8zSW90dm8rbWYwb3NSVWlyclpwK0t4SHMyMi9JZmdJTEF5dS9RQVg0YjF5?=
 =?utf-8?B?MGpsaExBZXQvRXA0ZWp3Wk50Q1VTVXRxcGZYMzlZNnoyZWpOMktiTnJsS0lM?=
 =?utf-8?B?elZ4alBIRStKb3Yrbzd6d09LRlh5alFsbWFuQXRpeTlCb0YrdXpNUDhlTExM?=
 =?utf-8?B?ZW13S3hmUGJqMjZLTklULysxVWJlUUxtL1FvelZCL2wzWWxOZ3owM0Nua2R2?=
 =?utf-8?B?eVV4WXZReVd1S0hXYkRmMGpqaFU4Yys4SFdkVzJUNlJHa2FydEd4VFNZNm5z?=
 =?utf-8?B?Y2FybzVNdk9PN1ArdnpUeGFsWUVmSXFyNXBMTzlDU3d1MG4vUVRDbkJhZ0tV?=
 =?utf-8?B?WTlPZXBKZEszTnBHTkhYS3pLUlF5WVlFUXlNSGJBMlVCK1A1MmV0dnNhQXZY?=
 =?utf-8?B?UXN2T25QZEdKNlFCYUtWMFRsOGtuVUtqWU81eGxzZVlHNUkzT2tOMG01bU1u?=
 =?utf-8?B?czVIV2pTdlFwa2pEMU1yd056Y0JXM2xCKzJiMVNvYXZMS0QxRWlOSzdhTW5i?=
 =?utf-8?B?RWJ5ak5KRVViQUorS2hoVHcwTEh0TDZFNHhSWkYrbzBkbnlBazB5Ykp4bHM4?=
 =?utf-8?B?amYxdmVpaTliaSt4ZVpaSHUxanROcUs4dzc0SEg5Q1Yrc2RLTENzLzM0TmRF?=
 =?utf-8?B?V0lrV0NNaFRZQURUbUZtNitJRSttSUhWOGNKeDQ1WXpuc2o0VGZYVjhPZ20w?=
 =?utf-8?B?VkFRZHZSYkZ3TnNITFFQZTFrZTJvUnhpc0gzVXhKd29GOE9CWjNZL0xXMWlj?=
 =?utf-8?B?cEd2OHVDZGprZ3NJeDFRVkFodTkrUGlmemhxWkFWeXNzQWJJeWRqeW43UEU1?=
 =?utf-8?B?dk9UUU1BWVdQVDVQZ3hWdTBYU25hczRaaE40bmN2TUt3Sm1IS05EUW9Ia2hO?=
 =?utf-8?B?NUMyQU9lU2dQL2dQVWJnWnA4SFNVam95ejh0amJlenFPdStaM0duNEh3b1ZM?=
 =?utf-8?B?eDNPS2g0ZGRCUVFXWnJDOXgzaFRMUFpaUUtSa0ZPTjlCOTN3WGxlNW50bUha?=
 =?utf-8?B?M25pdUZSVFp4OVFWaitBSUkvSE10YXYycWVmT2JLd2xtSEM4ODlFc0NkU1lu?=
 =?utf-8?B?amN2eDBhQ2VxdTV5YllLd2RvV2RKWXlENDdxNFFWMlRxNlozSmxndHNtdlBz?=
 =?utf-8?B?OS9ETVFZZkZDMGc1YzBUNmJVUDNoRVJWL3JRb2VYTUg3alBpOXhKVGhFMmVk?=
 =?utf-8?B?WkphSHpiUUFvdEVDUURsdHpLMWwvYi9uN2pPbTJuYnBDZEhaOXZzZ2wyS0kv?=
 =?utf-8?B?R095bjJUR3Q5N2N4aXRJODhtYjJIcjlSc2tJaTNZbDE5enVybjhHM2tQdk5E?=
 =?utf-8?B?dHlMVEtpUlJvUmFJcVYvNUwwV1VJZ1lIdVI3VGpOK01ETDVKdy83cHVOY21H?=
 =?utf-8?B?TEhFRGR2YnduUUs0MzNnT3NNZkNWYXVqbndpUUFGWDcwaG4wOWpBU3A4UGhp?=
 =?utf-8?B?eHl5NXhFUmhrbjNsbzhSaUVkbzkzcXFlUjNQRnJ3Z3ViNzRDRHdWRFVoazNF?=
 =?utf-8?B?TGhlNHVBdHBlQjVHZUp2SnZ0SXZDYXRNRGtwVnZ6UFZPcUs1eURhaHNBZnZW?=
 =?utf-8?B?K2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	mpwi0a5ZEjYadHSg4F6j/hg6S1wsNyTeQE1OMS9oqnRyKC/BnN0S6bMuvkxKHZFJA4SFHg7ZAWAr9b9SA/5UUOTXNwOMopKaNhdGBG7n5n8atB/Qf8vMxIYJHLfypMDgrSNwnnmCcRuzNf1QnMXweXJEbTcnepLLv5kR3lk88b9T9auPdy8h2M6i1kfruObsKD/HdPk7zf0D2GlzRz2RM/d8CBY7NTnHl6UwDSoKuh0yuc4av0XGhg4sRmDX6wHslPdHCQ4vkTziVopaGSppI2eqdM918TYerAPaacUDkDv5+njW4oznBJZXZ0CDwyjtR4fedyAPMTqynoGeu9VEJYckQjCfKnTDcTLQk4bPdHeMwXdXoBPGS60u13YO4EstKc7t1KcRBEg0xxVFBh2KjrizvDbQwU0ORosTYkIG81POUEUCBF83Y07Hfy28bd6tVgwCkFv8uWxE7UXs87zwXdZZ3Yj3v+bMk4x0F29iNuDhO3pN26MUcoAeJwVxYoh/pVOrS87z0FZa1K20QM5iv3uHqE/OPY4e48wVJ4k1LYlZES7fC0IKYFCyn/VMTQwY6esLIOpVBIUU7T9GokEpX5mktfRsFhnKyUge6H4LNt8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd39446e-c863-4085-4f30-08dc2634f573
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 10:26:48.0588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2oHfumdA02f0Spd8jbxBE1usFdW12DFUPirWUJNpF45qP1jKFgqxLVde7BMWF+wkJMsqm0YmjiAvEQcyZccq8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5171
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-05_06,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0
 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402050079
X-Proofpoint-GUID: FFDN67C2HZzaof5OfGkmSMJrtuKBNTcR
X-Proofpoint-ORIG-GUID: FFDN67C2HZzaof5OfGkmSMJrtuKBNTcR

On 02/02/2024 18:06, Darrick J. Wong wrote:
> On Wed, Jan 24, 2024 at 02:26:45PM +0000, John Garry wrote:
>> For when an inode is enabled for atomic writes, set FMODE_CAN_ATOMIC_WRITE
>> flag.
>>
>> Signed-off-by: John Garry <john.g.garry@oracle.com>
>> ---
>>   fs/xfs/xfs_file.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
>> index e33e5e13b95f..1375d0089806 100644
>> --- a/fs/xfs/xfs_file.c
>> +++ b/fs/xfs/xfs_file.c
>> @@ -1232,6 +1232,8 @@ xfs_file_open(
>>   		return -EIO;
>>   	file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC | FMODE_BUF_WASYNC |
>>   			FMODE_DIO_PARALLEL_WRITE | FMODE_CAN_ODIRECT;
>> +	if (xfs_inode_atomicwrites(XFS_I(inode)))

Note to self: This should also check if O_DIRECT is set

> 
> Shouldn't we check that the device supports AWU at all before turning on
> the FMODE flag?

Can we easily get this sort of bdev info here?

Currently if we do try to issue an atomic write and AWU for the bdev is 
zero, then XFS iomap code will reject it.

Thanks,
John

> 
> --D
> 
>> +		file->f_mode |= FMODE_CAN_ATOMIC_WRITE;
>>   	return generic_file_open(inode, file);
>>   }
>>   
>> -- 
>> 2.31.1
>>
>>