Received-SPF: pass (google.com: domain of linux-kernel+bounces-52443-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 5 Feb 2024 10:59:43 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] perf: make pmu_bus const
Message-ID: <ZcC_nzYhFnnnvkux@FVFF77S0Q05N>
References: <20240204-bus_cleanup-events-v1-1-c779d1639c3a@marliere.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240204-bus_cleanup-events-v1-1-c779d1639c3a@marliere.net>

On Sun, Feb 04, 2024 at 10:29:39AM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the pmu_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 59b332cce9e7..decd994bfca4 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -11434,7 +11434,7 @@ static const struct attribute_group *pmu_dev_groups[] = {
>  };
>  
>  static int pmu_bus_running;
> -static struct bus_type pmu_bus = {
> +static const struct bus_type pmu_bus = {
>  	.name		= "event_source",
>  	.dev_groups	= pmu_dev_groups,
>  };
> 
> ---
> base-commit: fdd041028f2294228e10610b4fca6a1a83ac683d
> change-id: 20240204-bus_cleanup-events-765165264090
> 
> Best regards,
> -- 
> Ricardo B. Marliere <ricardo@marliere.net>
>