Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2336772rdb; Mon, 5 Feb 2024 03:33:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHci9IYdCEC2sj+6MXuY2xHuyv24tGYJG2W1/ALYl18xjfMY2wawP50sLHy9xaAt3CfEise X-Received: by 2002:a05:622a:1702:b0:42c:201e:7bd6 with SMTP id h2-20020a05622a170200b0042c201e7bd6mr3849475qtk.61.1707132824558; Mon, 05 Feb 2024 03:33:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707132824; cv=pass; d=google.com; s=arc-20160816; b=X1i3qvr18RzuGYJpDsuGCTpS/ypJcy2QJSl5Mf27GZx4fv0FCZgctbR5EYOP8A1IE+ nVJAf+jcpw93/W6+6RVRvpVTnULtQR4PYWDHjBDqU51KOjY/y2dg778irjKbh8irRrKp waDhOiVWwihqjg3pz1TYR9Od+iHyfOV7uAYa4vg3wVjd/y+GtUDhZIhNLQ3oNdZRmZbs sjYxCpG51eq8vMtReRIwxFvT1E12wRsV0Y9yZv4OA5GxPgzQ23g5vSHITINYq93VoZk3 qkO0zevgk62Yfyt4RXDwbCxKg9eikVeAfAKug2zoTRbdIeEQatnZgE+g7h8cNf9DT53O ikTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=o4RoA1rH4rB2jaS+AHrZsou+aBL79EHdgTVoMA6pD7E=; fh=vIKynd2FFWZRoL4COEoPsQWYGBwyqubfSreQXvDXLqg=; b=mz9OJFPT/aKYbCSdt707f4hv5H0TxJTBLjE6xe0VfKMMJpWhkubOhyk/DDOQ1K7CUx M36PSt0pWlCpVG1T1YMfaoM0DO1nfUE1FlvUvbllbNqmVJPvIzKxJvQwhQMBDyu+8Bnr SwG61xpINogaDQKiFiOTJifD5WH4L1dau6Z5Evf1TsOlGvnjvDJpOan/zQSHKlesieop kqJz7mU9l0shWSb7PUDCK6ya2/yx2KkKjBMNXntGt+fXD5Ql7/ks+TzHz2mGJEtGrj4f 7ddDi8iKIUD1vs/EC1xQxyT6iqub4RS6/IYEB+OcCi76Kr56tzfr3aeOCCqbqSwlHp86 F7Og==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qSWqRmpA; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-52489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52489-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCXIhx+ZzrF+EW448sWxlyvoOfK8Pdsuk+klaKyIfx1OzqQoioF82+dlDfKdc5KG9XVwup88MdGY85jt10PFcBqSHDbBTUnD1ItKfX+vwQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b2-20020ac86782000000b0042c00d84d39si7419057qtp.0.2024.02.05.03.33.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 03:33:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qSWqRmpA; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-52489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52489-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F00591C209D3 for ; Mon, 5 Feb 2024 11:33:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4AEF818E1E; Mon, 5 Feb 2024 11:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qSWqRmpA" Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FEC118E0E for ; Mon, 5 Feb 2024 11:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707132816; cv=none; b=DCD8AGHRiyaQyBuwEBYnspj0bJXXntimalNEECe/rFBTfrpAyp1qN0pPxfxi4PgvT2XxbVXl4XGSM2A8KVKWxCHklQqOFBIuYFt3Xm/pOeix7Leflqrpy5wLps1herFAOoAX78HG/2OX/qEbta5FlneU1w7y6+ISWsIQilMMVJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707132816; c=relaxed/simple; bh=pqHr8ktcWjb7z6YkpH8/0b9yqCF/o9NhA+xa5c+rTns=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZLFvRnHsMbUMBU2Pu4BC1jcsH6cYaK7egrVgYIkiZxmgObKFr2jrh+ORm+rRaGBvbMz06T7YwTwKwY+c4CPTnW5ShPyB/Oy8j/u/Pbrd4M/ZjzkK/54FGL2gjn0bXUDc1Gx+ELEUfdlRgznL3x6YTv96Lrexhf53PGzKTdhRZ/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qSWqRmpA; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a26ed1e05c7so597384966b.2 for ; Mon, 05 Feb 2024 03:33:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707132812; x=1707737612; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o4RoA1rH4rB2jaS+AHrZsou+aBL79EHdgTVoMA6pD7E=; b=qSWqRmpAAV3ysP0eoc4GTKQEWXviQk7N/wSa/+WeujTdNfJfwXKUgIai/rFr5hOVhe xeHemWEQGu9MQ/+hkA+jRf+NRHRbmmu8txibA1wBG1UbbNK8AynuW9PZ4R7r6ljNqqop v1NGt/kskHMzVqwv/XP3QAn0aR+RgvyoNdeVpf5/9eUGFTuvXoU6gm+1BLJt05b+vovh kMh/NWlT626RP/4tHiv2QrHGcq7kYDRgWTpsUR4uAYvOCrZNgeMR7GAa219ZduYJoVXB ypgzteh9zBdEGLW2IsaaC1TFxOzjNwom+ZQ6jN4ttr7xM/Hh7zS1b1EyXU+aHh4OeIi3 Bd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707132812; x=1707737612; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o4RoA1rH4rB2jaS+AHrZsou+aBL79EHdgTVoMA6pD7E=; b=BKu+WBsEl5RK3K4ikpgUOU+ql75NrxLn0TkBZ89SRCFo+uVjWB4wxIuFczPKl9IUJ2 QbDskMt4I9AuVu00u1Lo9XSRv3p976FoSJPeicVVhDtCrXrG3NdVkYwDvj2pKPkzxsU/ 2z+wMVsmmSulnoijJWV2Z/ld5OU3hTBo6zyV6DnsUBHeyZNjZM0+CGgO48Qbr8ey1THR bhEmzWhyw5jeSPHyos6CZzJI+LCI86p2bzACEyF4Ha5srSXP90thSBAF8ZGJuyVzfclD UVonbFgmEPjvmv5nc1Oh6jQv8KxQNcq51wOTxsCdTEQtPdeV8G8Hakusk8RCiADpcvjH 8gHQ== X-Gm-Message-State: AOJu0YzX8onxq4LT9YCE0tautpLzxSgQ6h60wjLIJS1z5/HYPrG093lM XzmisSiKWfSs/OfDnhlOQC+cB3WFMOXbUBFnBSdd1tuFIsq/jijgepO/UDgrTLM= X-Received: by 2002:a17:906:31d9:b0:a37:2176:251d with SMTP id f25-20020a17090631d900b00a372176251dmr5226974ejf.15.1707132812195; Mon, 05 Feb 2024 03:33:32 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVIKDymKFwpaw0owuIVjaaVHIJEixWT6e2nh/2aI2NxesHM6Fn+jsrih0eFIHj4iw2Q8nSDuTOVNNMTJbcvfaJ4vHgwbFGdQi+SXcneuAkekZomVLErSJNvVfa3xjtpJpx/As4NmOezkfAYHyVFX9I6r2xfVySi1INlVPX4Ill98BCq8z7zJmT5KY8LlOTqWOg87x5QYxnA6IYBR1Uj33oRmG2pYTHr6Attvqd99Z3+H0WsKrP5Xe5nO/RYVBPH7Rb75YSDgvzQ4M5ZttkjblpYJ+5XHJYn4OWSZQBbT2a6qboAZ6C2VSZMx7aaoNakIWL+dX3wy1VRPSRW1S/N8Hg0cYr6UCz0Z4AXrqbz33FftZ5P/1jq3Jj/5gkGzlFMMdhAa//ikgiYLqrt2VwXz8+gHrsePFB6fUt1cuVtiaEB7s+tQjSRjaFuFDQKavEaq/YmOWP077j2SK981wdKKxM+K/x9gbzZ9C59W13cOIEGXbPiGQ== Received: from [192.168.159.104] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id g9-20020a170906348900b00a3522154450sm4299604ejb.12.2024.02.05.03.33.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Feb 2024 03:33:31 -0800 (PST) Message-ID: <6fdde54e-12cb-442c-9dea-d1d6cbca340b@linaro.org> Date: Mon, 5 Feb 2024 12:33:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] clk: qcom: gcc-sm8150: Add gcc_parents_0_ao support Content-Language: en-US To: "Satya Priya Kakitapalli (Temp)" , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ajit Pandey , Imran Shaik , Jagadeesh Kona References: <20240123-gcc-ao-support-v1-0-6c18d5310874@quicinc.com> <20240123-gcc-ao-support-v1-2-6c18d5310874@quicinc.com> <77903574-696b-90f9-f136-be5c5d219ba1@quicinc.com> <5ae84692-b05d-4a43-aabb-4d2e7d9926d5@linaro.org> <04788b2c-a212-b8a2-1124-d904f2f61f5d@quicinc.com> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <04788b2c-a212-b8a2-1124-d904f2f61f5d@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5.02.2024 09:37, Satya Priya Kakitapalli (Temp) wrote: > > On 1/25/2024 3:25 PM, Konrad Dybcio wrote: >> >> >> On 1/25/24 06:49, Satya Priya Kakitapalli (Temp) wrote: >>> >>> On 1/23/2024 11:17 PM, Konrad Dybcio wrote: >>>> >>>> >>>> On 1/23/24 17:34, Satya Priya Kakitapalli wrote: >>>>> Add active_only support for gcc_parents_0, this is needed because >>>>> some of the clocks under it are critical which would vote on xo >>>>> blocking the suspend. >>>>> >>>>> Signed-off-by: Satya Priya Kakitapalli >>>>> --- >>>> >>>> Is there a need to keep gcc_cpuss_ahb_clk_src around? Do we do any >>>> ratesetting on it? Should we ever turn it off? >>>> >>> >>> The branch clocks under gcc_cpuss_ahb_clk_src are critical clocks, which are running at 19.2Mhz causing vote on XO during suspend. As of now no rate setting is happening but this rcg is useful to get the exact rates from debugfs. Hence this change is needed to avoid XO shutdown issues. >> >> So, if I underderstood you correctly, this clock serves no purpose other >> than getting rate? >> >> In this case, I'd say we should de-register it from the clock driver and >> use debugcc [1] (contributions welcome!) for precise measurements. >> > > Although currently there is no rate-setting happening now, its better to keep the rcg modelling as is, considering that it might be needed if some use case arises in future. We don't tend to solve imaginary problems, please lay out what it would be used for, if at all. Then, we can assess whether it's necessary. Konrad