Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2341499rdb; Mon, 5 Feb 2024 03:45:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwfHGNe6jXxa2xPstrZYdRhSDNLePu4hUiEZP+q63Wr5z9+GFN5VQP7zx+ieREKj6ZfO+o X-Received: by 2002:a05:6512:138f:b0:511:548f:8ee8 with SMTP id fc15-20020a056512138f00b00511548f8ee8mr837295lfb.26.1707133540504; Mon, 05 Feb 2024 03:45:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707133540; cv=pass; d=google.com; s=arc-20160816; b=GztVoz7MhJDwUIyy29U65rvD7DIhPl7/joB0rRnP4yC0GoKN8dJ4T8+hhUSakakSTY DmOIctakRQfulTPNVefep0n87PnHhRGRA0eiJy//PTsVcT/qHljr8q4knnbicEy6iHVj 4RzBZ/EoOvLw0K/+dRho98Sa6fnUc0YNhZfz7+4ynXiF3IHxGeK9rNewNAMPzyVWVVn1 j2A6QqDsPCl2Rej7O/YqF7Ck3/27f5aVx66x56lBosUWlTvGOJGuxl1ZnL+CP/zJAk/k NGnVgLMFGKtZakk6jAI7uBHyMKHrNLqdGuqaLMlAbcTYn61OnEornybuXmP6J3JWRPNk AJ6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=BYs4rQ5/k64xGn6SgCJXpRb/M2MgU+YyuM9pGGjE//A=; fh=rfUzVwkpRxdgaquPZ+Bh2KpOrunilr0bbpVn10Hw62I=; b=RK3cD3RljUwUpxm2x8MTUjhzigaM49uZgQx2YppA+TPinQJzaMDnTz3UEPA5x0xvKt yTl4WWt1BP/4CZ0YBRyBvxCASplib7aesNXKZjqWVz8QjgZsVa2+OGMy2C5O+YeSfHjc cy6z/vAhwSbvzvLvJA79kyKal0Cz9uvo4fwVWVBv42+S2wN5Fysu90o/d4tPwIRtkRsK E9yYlDY2QFz/B8+Dx8Om71+IBHBn9PcDpZs5lfu0U9YMZVKdNhLuPlAUrtrlk/v0w5oj jR/ChAheMSF8zwxTUKasTvUK7BG/WBK7K0P4xLcJlFmCB0oJXCwI7k1H8TR3bnmH/vEy 42bQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S0SfTXx8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-52511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52511-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCVeIlVOsyghgMbcKPlNaSg1ACUjBzZ0JElw/Dk/SWKaFmRGDxhepiRDDEM1JnEEmsvDjQbffTB5LEHKkwlCSo6vMmaC2SYtq7GmCCkugg== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id v22-20020a170906565600b00a36fae45512si3913365ejr.615.2024.02.05.03.45.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 03:45:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S0SfTXx8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-52511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52511-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 40E7B1F22AC1 for ; Mon, 5 Feb 2024 11:45:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8611E18EB8; Mon, 5 Feb 2024 11:45:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S0SfTXx8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A776118E29; Mon, 5 Feb 2024 11:45:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707133527; cv=none; b=hpP1Fwq0rMvxj7U9LXMTBRnpe3e/3PrWWL/p2WpAU06plIwab6vszB7Jn/uM1fNViUrLX9FKz0N+iIObZXmeGvxEhZsHTAhUdbzBDEpO97WSqOSGKah/YI42rn+rId73oszhpYSEf3dfzbwR4jirAwRLBPZl89fvQL1AtNqgCao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707133527; c=relaxed/simple; bh=BYs4rQ5/k64xGn6SgCJXpRb/M2MgU+YyuM9pGGjE//A=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bKiTyql6li8pP12HY8cjk2/vQCwpjlRnfqbZpLjOhNDhHCRZB0TRF78P9PSBlZpR4+/T+O9fwDYgjL9tQtqgsHFij2ybd17i3CqyuLVMQI+MAccFKm6jf7uFybh+mWCLlX0KludQ8775GpzraIqdOj2fOEGQnKpO6zjIv+6vzLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S0SfTXx8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C396C43390; Mon, 5 Feb 2024 11:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707133527; bh=BYs4rQ5/k64xGn6SgCJXpRb/M2MgU+YyuM9pGGjE//A=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=S0SfTXx8sAXPGWHPW5VvRr1z+i13fTvnBD3aKcRF9YWbPdt6+xWiOHp4J4sglj/Kc Eqbx+DkKxXtmtSCMTgApk06HNiqPUFkdqNSabgr/yHD7XhW6DWYBf9zB91Dd+mhvgl zrNhUVHpin/TssQbqpOTWgD4RLJXTIUGegXQCJ0wktuqhYl1sFIcsYL8wUkmV+BvtM s+EYbkeogcz1Ke+nixtIW4C+JfQnct5cKdirN3qXtIv3hrT57hk+6POf1IQiN2A31u 1kXRcZIMsqT3l5NHpdRJoEJpsHukCSoIKxYyLpIr7TvEaWHl/jmo9E8Tapw0n2Wagl HiQewaybecxIw== Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-216f774c827so2168726fac.2; Mon, 05 Feb 2024 03:45:27 -0800 (PST) X-Gm-Message-State: AOJu0Yw/d9GN+IQulgrN9f264SCUN9ZOIyDxlvdPkd7b1ghzt0dhfI6j qYg+OIp0q/q3v+WLPFVDidmG5tGerUDVBZ0ldeOlnYnMAWq5g6gb2epnkb9SWfyuReuVunvc5Th cEUFU7S0pL8XjFO2F3jQ2H9vj6BQ= X-Received: by 2002:a05:6870:4c0d:b0:219:9c12:ba14 with SMTP id pk13-20020a0568704c0d00b002199c12ba14mr645100oab.47.1707133526341; Mon, 05 Feb 2024 03:45:26 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received: by 2002:a8a:d11:0:b0:514:c0b3:431 with HTTP; Mon, 5 Feb 2024 03:45:25 -0800 (PST) In-Reply-To: <20240205111917.181490-1-pchelkin@ispras.ru> References: <20240205111917.181490-1-pchelkin@ispras.ru> From: Namjae Jeon Date: Mon, 5 Feb 2024 20:45:25 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ksmbd: free aux buffer if ksmbd_iov_pin_rsp_read fails To: Fedor Pchelkin Cc: Steve French , Sergey Senozhatsky , Tom Talpey , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" 2024-02-05 20:19 GMT+09:00, Fedor Pchelkin : > ksmbd_iov_pin_rsp_read() doesn't free the provided aux buffer if it > fails. Seems to be the caller's responsibility to clear the buffer in > error case. > > Found by Linux Verification Center (linuxtesting.org). > > Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound") > Cc: stable@vger.kernel.org > Signed-off-by: Fedor Pchelkin Applied it to #ksmbd-for-next-next. Thanks for your patch!