Received-SPF: pass (google.com: domain of linux-kernel+bounces-52573-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 5 Feb 2024 09:09:55 -0300
From: "Ricardo B. Marliere" <ricardo@marliere.net>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>, 
	Rich Felker <dalias@libc.org>, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] dma: dma-sysfs: make dma_subsys const
Message-ID: <paxhpsxe6w5r3urpwr5jvj36mlg5zxtmpdj2tzqhahl7qt66zi@4ppfluzcsaso>
References: <20240204-bus_cleanup-sh-v1-1-44ced951bb16@marliere.net>
 <26d729c173a2ba0b536de4b41dacd403793d94c7.camel@physik.fu-berlin.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <26d729c173a2ba0b536de4b41dacd403793d94c7.camel@physik.fu-berlin.de>

On  5 Feb 06:17, John Paul Adrian Glaubitz wrote:
> Hi Ricardo,
> 
> On Sun, 2024-02-04 at 12:15 -0300, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> > move the dma_subsys variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> > ---
> >  arch/sh/drivers/dma/dma-sysfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
> > index 431bc18f0a41..9f666280d80c 100644
> > --- a/arch/sh/drivers/dma/dma-sysfs.c
> > +++ b/arch/sh/drivers/dma/dma-sysfs.c
> > @@ -15,7 +15,7 @@
> >  #include <linux/string.h>
> >  #include <asm/dma.h>
> >  
> > -static struct bus_type dma_subsys = {
> > +static const struct bus_type dma_subsys = {
> >  	.name = "dma",
> >  	.dev_name = "dma",
> >  };
> > 
> > ---
> > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> > change-id: 20240204-bus_cleanup-sh-6d3c136da6bb
> > 
> > Best regards,
> 
> Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> 
> Thanks for your patch. I will merge it into my linux-sh this weekend
> after returning from FOSDEM, either this evening or tomorrow.

Hi John,

thanks for reviewing. I was wondering if your tree should be listed
under SUPERH in the MAINTAINERS file? I didn't find it there and had to
do some searching.

All the best,
-	Ricardo.


> 
> Thanks,
> Adrian
> 
> -- 
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer
> `. `'   Physicist
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913