Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2356915rdb; Mon, 5 Feb 2024 04:17:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyJptncJzy8UWpl63Xm/JHhB8B6M+BZBPmbHJnttfQcATLJMZTg45gyPG9EP40t6D78CPB X-Received: by 2002:a05:622a:d2:b0:42a:a952:68fa with SMTP id p18-20020a05622a00d200b0042aa95268famr7728781qtw.19.1707135437722; Mon, 05 Feb 2024 04:17:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707135437; cv=pass; d=google.com; s=arc-20160816; b=IoJ1AOW7nERR2dBvSY2a/5gyf9AQOmvRUIhYyG9aBMgkT8P84GLieiYuTnEUEXIATs dTrXNDg27KBqYsYG3fi7QkZjwLnOn7NC2FBu+3+OMhQVUdNwbaEJYaSbplMX4VYCtuTj OIwcK7XziyEbcV8uM9QXJamaV4vNlTsW5kQsK1iAJsl8vkE2lxfN3+oz5P9GYd0b9Ssy 9naApVKu0tbK+RTG62OIywLty3RoHZhAN82+9xBg9NHdsNvQBhsgwqfeaij6UxHE3UGu xp5m6j9Mplm2TOPG30B7XI4dvp+kiu8SQMjDZEN6IZMUoE8Qc4vMFdhl/8IQoX+xVy/n yTmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FwnbpE9yWQQbfuStfMSdAVpms2unyg3Uv1emhgdfEDg=; fh=HXtMRPjKleZPwpDGsHIEfXKjxBTvKn2FVmHKmDCceqE=; b=w1BzO4emIlTLKTBGfrzPQjhIX/ERp0fBPLz2ojd1GsUwpF+te11Mp3QX91r5xjOk5i SlCjQ94IVgtVbVI065NZ153OPP0WzUan6UYVZGjSWn8vqiVRhW1oQTkBmd+gPAQ3/nhT 9uGEZq/Tn3fpY3ecRDMPJxnMIuDupWTtD25nT5X4uuYX6egKW4kr1sc6CIgZwvLUO5b0 YSr+6bbbUOzxrVQnYOimQf3Hfxnv2vz6x1KC17WFVUfwd/fN4wFMtq2EbmQGP8ktJO0Y eQHyhOXeBHNOApSE6UcQQKIb3Q240rucrADK6W/YskBLPZaMkpKjs17FkLM0odA9EN3j g7og==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T7Yej6P7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-52578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCXHEVo8Fq3z45mVIp6cwJy6l1B84ZniDjhJV007gzw45vF0UiuFAjLo5HyRBSkgVaF4J8FaZiAASL9v0WlwK/hbHzFBhnQ7uvMFdafVJQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h13-20020ac87d4d000000b0042be2b7459fsi8177805qtb.178.2024.02.05.04.17.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:17:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T7Yej6P7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-52578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7C30C1C225FE for ; Mon, 5 Feb 2024 12:17:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF89A1C290; Mon, 5 Feb 2024 12:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T7Yej6P7" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16B591BF34; Mon, 5 Feb 2024 12:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707135034; cv=none; b=LA8Z9SBN5i64arE/jdv9A15emmTuhAnLx2oWRoM/KbVKvT+dyRByEcpxdAwOKNWOl/w+RMIUObYIxo2wDtLHGEDVqyGZZYcGuqAfq2ABS94HWMD5JIBK5dH0DUmZtRgcwYrrZQiGVCnaDWE4KTbsRkSkOXDhRcgzvcnRsJh0ivo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707135034; c=relaxed/simple; bh=FwnbpE9yWQQbfuStfMSdAVpms2unyg3Uv1emhgdfEDg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g3U49jfyoxisGrImEZMMCFs36TvnUlB6zWXPRxdlwSpyI9xa/6X9xidV6a2i7uGKPp4J32gVtNXQFAr6pu5Ke7FWSU11sP/QoG4voCwZdeDJnhxUaJBvBZ0VPnucSMbXho1vYzOb3EeQznhhyhudjUqTSSZ0Z7tiPTmYJjpRXOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T7Yej6P7; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F5DBC433C7; Mon, 5 Feb 2024 12:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707135033; bh=FwnbpE9yWQQbfuStfMSdAVpms2unyg3Uv1emhgdfEDg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T7Yej6P7z9Hsdya9am6dwVYvGXbWfkQywJJQHhgTZa6OuT8kifDflYil4X0kUJhEH BcuIvFa4B/UFqjChzf9lyzsECV03t2Z31ORZV1BkgofZkogppoChCFEpzdVdR85PsC sTMb/JM/GWvqvPTS16h9qOZpQ6Z8dJRcb4zY+uILLgVMjRWv4Cy08qM5zaFcQ1wM7e +5SY1EDzzwhRS8fKEQyproWj0uY0iWbr7HjhwS2j9vXYtLa9+E3bSM9U6EhqaMhAPs KLgGLlXNjEkOTBWgWgTUcpIIiAOTX6cll8wAAuw22//Rw+Qcvz7gXmHVaZM9yy43VE OhAHfxwcI42OQ== Date: Mon, 5 Feb 2024 13:10:28 +0100 From: Christian Brauner To: Jeff Layton Cc: Al Viro , Chuck Lever , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] filelock: add stubs for new functions when CONFIG_FILE_LOCKING=n Message-ID: <20240205-prall-herde-c413a323b54c@brauner> References: <20240204-flsplit3-v1-1-9820c7d9ce16@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240204-flsplit3-v1-1-9820c7d9ce16@kernel.org> > Another thought too: "locks_" as a prefix is awfully generic. Might it be > better to rename these new functions with a "filelock_" prefix instead? > That would better distinguish to the casual reader that this is dealing > with a file_lock object. I'm happy to respin the set if that's the > consensus. If it's just a rename then just point me to a branch I can pull. I don't think it's worth resending just because you effectively did some variant of s/lock_*/filelock_*/g In any case, folded this one.