Received-SPF: pass (google.com: domain of linux-kernel+bounces-52551-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20240130101344.28936-1-lhenriques@suse.de>
References: <20240130101344.28936-1-lhenriques@suse.de>
To: Luis Henriques <lhenriques@suse.de>
Cc: dhowells@redhat.com, Jarkko Sakkinen <jarkko@kernel.org>,
    Eric Biggers <ebiggers@kernel.org>, keyrings@vger.kernel.org,
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] keys: update key quotas in key_put()
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3007645.1707134664.1@warthog.procyon.org.uk>
Date: Mon, 05 Feb 2024 12:04:24 +0000
Message-ID: <3007646.1707134664@warthog.procyon.org.uk>

Luis Henriques <lhenriques@suse.de> wrote:

> Delaying key quotas update when key's refcount reaches 0 in key_put() has
> been causing some issues in fscrypt testing, specifically in fstest
> generic/581.  This commit fixes this test flakiness by dealing with the
> quotas immediately, and leaving all the other clean-ups to the key garbage
> collector.

Okay, I'll accept this.

> This is done by moving the updates to the qnkeys and qnbytes fields in
> struct key_user from key_gc_unused_keys() into key_put().  Unfortunately,
> this also means that we need to switch to the irq-version of the spinlock
> that protects these fields and use spin_lock_{irqsave,irqrestore} in all the
> code that touches these fields.

.. Which shouldn't be that often.  It only happens when a key is created or
finally let go of.

> Signed-off-by: Luis Henriques <lhenriques@suse.de>

Acked-by: David Howells <dhowells@redhat.com>

Jarkko - could you pick this up?