Received-SPF: pass (google.com: domain of linux-kernel+bounces-52558-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 5 Feb 2024 09:05:57 -0300
From: "Ricardo B. Marliere" <ricardo@marliere.net>
To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Thorsten Scherer <t.scherer@eckelmann.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] siox: make siox_bus_type const
Message-ID: <ysesefska42ctpibulegsfpuaxfr5innla35yrvi7de2llkcwl@dq5hppwwpsxl>
References: <20240204-bus_cleanup-siox-v2-1-3813a6a55dcc@marliere.net>
 <5zjixnsaylidn7t65thchwg5aa2igpwr34bmlfdtevvn4bgx2e@txzz36fi7rqz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5zjixnsaylidn7t65thchwg5aa2igpwr34bmlfdtevvn4bgx2e@txzz36fi7rqz>

On  5 Feb 10:03, Uwe Kleine-König wrote:
> Hello Ricardo,
> 
> On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> > Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> > a const *"), the driver core can properly handle constant struct
> > bus_type. Move the siox_bus_type variable to be a constant structure as
> > well, placing it into read-only memory which can not be modified at
> > runtime.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> 
> I currently have no setup to test this, but compilation is fine, and I
> don't expect any surprises.
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Thanks for your patch,
> Uwe
> 
> PS: b4 gave me:
> 
>   ✗ [PATCH v2] siox: make siox_bus_type const
>   ✗ No key: openpgp/ricardo@marliere.net
>   ✗ BADSIG: DKIM/marliere.net
> 
> when applying your patch. I didn't check the details of the DKIM issue. I
> quickly tried to find your pgp key, but failed (wks, kernel-pgpkeys
> repo, keyserver).

Thanks for the heads up, I'll go check what's wrong. I think I only
published the @gmail.com one.!

Best regards,
-	Ricardo.


> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |