Received-SPF: pass (google.com: domain of linux-kernel+bounces-52609-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <51315925-21ac-427c-abea-4d652ed5280f@arm.com>
Date: Mon, 5 Feb 2024 12:34:28 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: iommu/ipmmu-vmsa: Use devm_platform_get_and_ioremap_resource() in
 ipmmu_probe()
Content-Language: en-GB
To: Markus Elfring <Markus.Elfring@web.de>, iommu@lists.linux.dev,
 kernel-janitors@vger.kernel.org, =?UTF-8?B?SsO2cmcgUsO2ZGVs?=
 <joro@8bytes.org>, Will Deacon <will@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
References: <e01cdb99-8497-4fec-b423-a0bfb483ac75@web.de>
 <324d4e02-6a5a-4112-a3a7-d7aeb5876acc@arm.com>
 <49fc6a59-2c07-4366-b32f-0599c2418916@web.de>
From: Robin Murphy <robin.murphy@arm.com>
In-Reply-To: <49fc6a59-2c07-4366-b32f-0599c2418916@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024-02-05 11:52 am, Markus Elfring wrote:
>>> Thus reuse existing functionality instead of keeping duplicate source code.
>>
>> Much as I detest the get_and_ioremap_resource obfuscator, it's not even appropriate here since nothing else is using "res".
> 
> I got the impression that this local variable is needed to perform
> a desired function call.

Yes, the call to devm_ioremap_resource(). Which you're proposing to 
remove...

Thanks,
Robin.