Received-SPF: pass (google.com: domain of linux-kernel+bounces-52684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 5 Feb 2024 14:07:43 +0100
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: ulf.hansson@linaro.org, yoshihiro.shimoda.uh@renesas.com,
	masaharu.hayakawa.ry@renesas.com, takeshi.saito.xv@renesas.com,
	linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v3] mmc: renesas_sdhi: Fix change point of data handling
Message-ID: <ZcDdn2AVz8FIXzak@shikoro>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Claudiu <claudiu.beznea@tuxon.dev>, ulf.hansson@linaro.org,
	yoshihiro.shimoda.uh@renesas.com, masaharu.hayakawa.ry@renesas.com,
	takeshi.saito.xv@renesas.com, linux-mmc@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
References: <20240205112702.213050-1-claudiu.beznea.uj@bp.renesas.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="OJl2Hke6wUYqvGo9"
Content-Disposition: inline
In-Reply-To: <20240205112702.213050-1-claudiu.beznea.uj@bp.renesas.com>


--OJl2Hke6wUYqvGo9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Claudiu,

thanks for the updated version!

> To comply with this, the patch checks if this mismatch is present and
> updates the priv->smpcmp mask only if it is not. Previous code checked if
> the value of SMPCMP register was zero. However, on RZ/G3S, this leads to
> failues as it may happen, e.g., the following:
> CMPNGU=0x0e, CMPNGD=0x0e, SMPCMP=0x000e000e.

Can you add the current TAP number (variable 'i') to this printout?
According to my understanding, we should only mark this TAP good if it
is in the range 5-7. I need to double check with Renesas, though.

> Along with it, as mmc_send_tuning() may return with error even before the
> MMC command reach the controller (and because at that point cmd_error = 0),
> the update of priv->smpcmp mask has been done only if the return value of
> mmc_send_tuning(mmc, opcode, &cmd_error) is 0 (success).

This is a needed change, for sure.

> This change has been checked on the devices with the following DTSes by
> doing 100 consecutive boots and checking for the tuning failure message:

Boot failure is one test. Read/write tests should be another, I think.
Because if we select a bad TAP, bad things might happen later. To reduce
the amount of testing, read/write testing could only be triggered if the
new code path was excecuted?

Happy hacking,

   Wolfram


--OJl2Hke6wUYqvGo9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXA3ZsACgkQFA3kzBSg
Kba1EQ//XACdt4i/fR0oXUL7zqQ/iNlftWWZFRf6sI4jYTfUTFcUM6Iy3b5qMnqa
Jo2HLRrVc/80MUkGVYHSr6MN/JnwrBOYwrHMwhVwT2Y2uZrHJPLxGqm7PJ/pexxU
h8+3uc5NL/xUoSETj6PFMlmB1H0Zx7rHO2vj1NLhnk4USThgZU0HBPAE1pw64UL9
m0kRyTcY+KBaVE1DaA5RJriDlH0oVpP43L/Uw2y624IK29EzrsxLmY0NWWlZoKE3
ncsqMWDyMrQnBzoM+wDyc8NsCS80WbTYZvqoh70Hv7z5K2yAmi7v5pUsbWYZC29E
6PV1Tjdstn1+zxVt+gcqE/i2X12ltvzCm8XHMDJriqaMp7Gm1sT4ZVxJ8+dTj1x3
Q21ojW9O1J6v3gf4pjqlcqUiJBvz+zq3oXRgBocKS3eP1bJDXkh25JocyB/a1LIY
NXeg0ZkBKlA0ag7ke9LB5088remEfliVX9a8l7J6CoJ+ZRKMhmkcsmsWXSFmfkhx
+sDMAUgPL311MTKMGt/QqFrXA08mlMCVxuPvcIgrINkuzXNRZXpVr5dAkTuZEBSi
1mZCtrmhOQF6f52hKqTkIYag3p61rDVc95OwdP5Xu7ftd+cILcmBBlZlwgVA17ER
rWuRXOEjvXSdC1veNWw9loJhb73nz0lEb6vBaRWMmwq1ayhdC48=
=fH1y
-----END PGP SIGNATURE-----

--OJl2Hke6wUYqvGo9--