Received-SPF: pass (google.com: domain of linux-kernel+bounces-52708-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 5 Feb 2024 14:24:01 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC: <fenghua.yu@intel.com>, Reinette Chatre <reinette.chatre@intel.com>,
	<shuah@kernel.org>, <linux-kselftest@vger.kernel.org>, LKML
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] selftests/resctrl: Split
 validate_resctrl_feature_request()
Message-ID: <zo7bbgj4f367g6bxpgyqs4tmkwqzimjqgcrx32ywoylrsc7v7k@kkqaqby6fueb>
References: <cover.1707130307.git.maciej.wieczor-retman@intel.com>
 <e4b1887682e8262a3416dbd7bc63695af0d63ee0.1707130307.git.maciej.wieczor-retman@intel.com>
 <65652533-8333-064a-c446-95232c7da76c@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <65652533-8333-064a-c446-95232c7da76c@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?YePVuwDHYnrUCDeEzIEKSFUNwEILr45MTUn6XNMF9J3/zKZCWbzIl+p/4P?=
 =?iso-8859-1?Q?Lkxz6Z1jJfLmL+PDsfpHierinBSTnrZraEaZzKewUc9HVqR7eEuzuEfRW7?=
 =?iso-8859-1?Q?XEIQHs7QOHwEmpQX3ub9BYp6V2yP5FukPELBpPYJQDa+frTT43fdAjbhUW?=
 =?iso-8859-1?Q?2uLBtfLh1VfPYy6PWI8CefTGkNk9P0fY+XhJ56halWv7nbls2K4qrIoCeS?=
 =?iso-8859-1?Q?aFm6o2j+y4+TZNmk29aHm8V2HbiYl8VroKJOwfzgFdNGUjGpfGbS0w1f43?=
 =?iso-8859-1?Q?CY5SmcIT6yk32vM5RQsMeT6dSZNcikjBjersmXPK3iZ7iFrFGZL9NyfRCK?=
 =?iso-8859-1?Q?84IQ4P7Wt4Rtqh50/rSS0+Q7vILPnRVCVMDJFK0XA7+GRrRccaQPwnOKGv?=
 =?iso-8859-1?Q?s3UvT6dn0PMmYbmTI4GrP/OElt+wgA8lseVmgXyeChCqk/Yo3DYXoTM01T?=
 =?iso-8859-1?Q?+v/vey8RGwkbYU+f7WYOdw0gmC+UU77afyVs9gPkhRVFnl1sR5C601oq1n?=
 =?iso-8859-1?Q?N7PIqeLsS/y9QZj5yhiLncZBosy+V4oOBLoMBbT2jbrNemQM9qL+/QpyRw?=
 =?iso-8859-1?Q?xYnUdpIHR55V82incBRdhZvUvuwMUNY9AR2D2kJ7ewT6zLWD8rgd53L8Uv?=
 =?iso-8859-1?Q?Ke5Qo5diy9g21A3F4jtTj11V3sTmDPWivrxTWefmYoC74LtqNZlk51/TQS?=
 =?iso-8859-1?Q?V82Ci8xY/3yvbOaFpao2PeA5QI5B+CXb4JtVDsLq58VOHTQu6el5IsE3W5?=
 =?iso-8859-1?Q?kyq7p2jnsZcEnk7VRkzK42uxdg94v3PcCnFixGf5mrj4o9kTgqh4SM1p7T?=
 =?iso-8859-1?Q?QfEhNs360J+lQJxiLFCtOtdhVBYrhOkPhP6NiFcoD+7zvPzNhP9WFt45hZ?=
 =?iso-8859-1?Q?KezITvfSZaaiB+u33OMRTHKw6SLYEegn5EZwaTZBNXQJoAdVHZNAEkwlrh?=
 =?iso-8859-1?Q?ZV/ACdgrCdeniCdQwfge5R5va7YaTv014nT+lYQ+xdImCnmLu4XynM18Yg?=
 =?iso-8859-1?Q?fcWmRj0ZY7P90+Ip1a3El2XBZdf/IhL6YAZSb4XBBBCKyILvm9L4bdB4JY?=
 =?iso-8859-1?Q?N/VwCSDpyK5ArY9I4pbBUPdEK5mqzKReHZW+KyjMX66w8DBsZJu5G/mHhJ?=
 =?iso-8859-1?Q?zRlOTwdKwzfvd1qZqxJXBfvXqg1eepS20rKoXPkAzhgw2g59jklRc6htib?=
 =?iso-8859-1?Q?RQiEuUUDrVnEYYwO0/UCnQn/DzuWorJoqVrr18VF9vJkZ0tAp0G/n+E7cf?=
 =?iso-8859-1?Q?Ll5m4NwwFWsRnCaXgp0siAaivdexuN4k1yLAMqfJdTikkDFhaa+/dtxbl+?=
 =?iso-8859-1?Q?XR7xYRErlrRYbf48VfYSD8cVQP15j3ONQ1lvGJxMkRUdHG5IWXpYZ7EmKm?=
 =?iso-8859-1?Q?MJ8xxssUh+H4zBzeiG19gHL4GxQ6jKc8A6B7nw7HOLBMT3DFdzNYcPtMr1?=
 =?iso-8859-1?Q?XhZrARToKPir68OtFE8OzRHgOhBHdScJTqdDUP8v4L1JVtVH+7sDJUSr4Z?=
 =?iso-8859-1?Q?9GJsHR7jdhupgucChQFgmbD0hlLO6g4S0PIu/izfk3CqaPTu344WZu1Jnq?=
 =?iso-8859-1?Q?yLywkawcgfeCOBQbKIFfhUqmF6qdkf+Kej0WPmi/bGpYcEGO1UwjagCELL?=
 =?iso-8859-1?Q?ZTuQlQlIHd3QhJZkeB2r6Y3yEG9tRuHC/reJHQI4qAMf8sjn4JhBiqpoTM?=
 =?iso-8859-1?Q?NNH7NHqn+I4/cNqYMgg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c405975c-0c1c-46e7-f690-08dc264dbc5a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 13:24:09.6256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8GpWlcQqLHjuxv8RawWI9hu/DBMIsMUsyz/YrqgYhKWDRVqfTt8Wk7r5x/uSjiqY0Bbc8LXffd5TriKuAVKRRwZZaS/lnQllkSIRzUmLZXU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8657
X-OriginatorOrg: intel.com

On 2024-02-05 at 14:41:30 +0200, Ilpo J?rvinen wrote:
>On Mon, 5 Feb 2024, Maciej Wieczor-Retman wrote:
>
>> validate_resctrl_feature_request() is used to test both if a resource is
>> present in the info directory, and if a passed monitoring feature is
>> present in the mon_features file.
>> 
>> Refactor validate_resctrl_feature_request() into two smaller functions
>> that each accomplish one check to give feature checking more
>> granularity:
>> - Resource directory presence in the /sys/fs/resctrl/info directory.
>> - Feature name presence in the /sys/fs/resctrl/info/L3_MON/mon_features
>>   file.
>> 
>> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>> ---
>> Changelog v4:
>> - Roll back to using test_resource_feature_check() for CMT and MBA.
>>   (Ilpo).
>> 
>> Changelog v3:
>> - Move new function to a separate patch. (Reinette)
>> - Rewrite resctrl_mon_feature_exists() only for L3_MON.
>> 
>> Changelog v2:
>> - Add this patch.
>> 
>>  tools/testing/selftests/resctrl/cmt_test.c  |  2 +-
>>  tools/testing/selftests/resctrl/mba_test.c  |  2 +-
>>  tools/testing/selftests/resctrl/mbm_test.c  |  6 ++--
>>  tools/testing/selftests/resctrl/resctrl.h   |  3 +-
>>  tools/testing/selftests/resctrl/resctrlfs.c | 33 +++++++++++++--------
>>  5 files changed, 28 insertions(+), 18 deletions(-)
>> 
>
>> diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c
>> index dd5ca343c469..c1157917a814 100644
>> --- a/tools/testing/selftests/resctrl/cmt_test.c
>> +++ b/tools/testing/selftests/resctrl/cmt_test.c
>> @@ -170,7 +170,7 @@ static int cmt_run_test(const struct resctrl_test *test, const struct user_param
>>  static bool cmt_feature_check(const struct resctrl_test *test)
>>  {
>>  	return test_resource_feature_check(test) &&
>> -	       validate_resctrl_feature_request("L3_MON", "llc_occupancy");
>> +	       resctrl_resource_exists("L3");
>
>This not correctly transformed.

Oops, sorry, I'll fix it for the next version.

>
>> +/*
>> + * resctrl_mon_feature_exists - Check if requested monitoring L3_MON feature is valid.
>> + * @feature:	Required monitor feature (in mon_features file).
>> + *
>> + * Return: True if the feature is supported, else false.
>> + */
>> +bool resctrl_mon_feature_exists(const char *feature)
>> +{
>> +	char *res;
>> +	FILE *inf;
>> +
>>  	if (!feature)
>> -		return true;
>> +		return false;
>>  
>> -	snprintf(res_path, sizeof(res_path), "%s/%s/mon_features", INFO_PATH, resource);
>> -	inf = fopen(res_path, "r");
>> +	inf = fopen("/sys/fs/resctrl/info/L3_MON/mon_features", "r");
>
>This became less generic? Could there be other MON resource besides L3 
>one? Perhaps there aren't today but why remove the ability give it as a 
>parameter?

During v2 discussion [1] Reinette made me realize this functionality only
interfaces with L3_MON/mon_features file and the 'resource' parameter isn't
needed. The 'mon_features' file is only mentioned for L3_MON and I don't know of
any plans for other MON resources so I assumed it doesn't need to be generic.

But sure, I can make it use a parameter if Reinette doesn't mind.

[1] https://lore.kernel.org/all/2o7adr2cos6qcikcu7oop4ss7vib2n6ue33djgfeds3v6gj53f@uu45lomrp5qv/

>
>
>-- 
> i.
>

-- 
Kind regards
Maciej Wiecz?r-Retman