Received-SPF: pass (google.com: domain of linux-kernel+bounces-52674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <28399201-e99f-4b03-b2c0-b66cc0d21ce6@oracle.com>
Date: Mon, 5 Feb 2024 12:58:30 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/6] fs: Add FS_XFLAG_ATOMICWRITES flag
Content-Language: en-US
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com
References: <20240124142645.9334-1-john.g.garry@oracle.com>
 <20240124142645.9334-3-john.g.garry@oracle.com>
 <20240202175701.GI6184@frogsfrogsfrogs>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240202175701.GI6184@frogsfrogsfrogs>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?N3QvNGpFcFJVU2c2STU4YnRud1NoTUVHL2NPdHpFdHRkWm5ucDBoVTZuTVF0?=
 =?utf-8?B?MUFLRHYwM0R0ZnJLZWRlMkptRURmOTd6KzUrdlh4eTIydFRwcUowYnJmbFRJ?=
 =?utf-8?B?RTZFSEJiclErdlQrYThZTndFdHE1ZDVsdEU3Z2NtUDl1dGpxeUJMSUhpekF1?=
 =?utf-8?B?aDF3TXRwZlZHemJBTHdQcTU5UkptQ3JzRGFlREwwL0RCeGwzend3eEhkNHBy?=
 =?utf-8?B?NDZVckVLelJCT3F6OXp2U1FZKzh0ZmtLM2FPaG5pNUVsVWRYYUc2NDRGN0RF?=
 =?utf-8?B?dmo2RWhOUzJCYjN6VnBIZ0tDeGdoUEVSL0t3M3BnYy9CeVFJcjVvaUhUME94?=
 =?utf-8?B?SUhTdWxqTjUwTDBFQ0dhRUVlOTZ6dGY3anFFOFV5Z2hUNDBNTzVBSzNwM1ZJ?=
 =?utf-8?B?M29xRzlVTFd6NmcxSi9FREY0L3VDZzhlQUdhS2tsN2h6QWkyck1hNFc3UzBu?=
 =?utf-8?B?WFk2S0tkYXdCd3NSVFJMTENiNWxVTXlHUUwzRVUyU2YyNFZMNDRoVFpSUDlh?=
 =?utf-8?B?NEN2RFhBb29rM0JYOU4xb2xtTXBkTm1QcmU3bDBodE0rSjh4Ykh5VGpCNitq?=
 =?utf-8?B?bFBBSVg4QUwrRTlHSEU3RURlM3N2RkVOUVNnV2ZreFdHQzJFTDZReUVQOVZn?=
 =?utf-8?B?dTA0YmY0dllvVXJoMGtLRFBXVlJmYlRsNVdKSVFCR3R5L2J0d0pkVEw4Z1pj?=
 =?utf-8?B?VmhsZDNTQWxudkwycW5nYW10bWNncDNLQ25FM3ErTGRuQzZxRFdRVzNicG8y?=
 =?utf-8?B?SUJTMUJxOWxzaDR2TzBua1F4MHhPakpCRE1oblphMFJTZ1NzZW9uV0NuNFNy?=
 =?utf-8?B?cEh2ZFhMMysrSkNqTXVPTlM3RTNhb2NWWW1YanlhMzJWN21NUTV4T0t5TDFq?=
 =?utf-8?B?QVdPYnIwRElLR01wU1NFSVhQajlySHpRelU4R2tCMmdNYkgyUnFxVWFDWXJO?=
 =?utf-8?B?Q2RZaWtQdW1WTDBpWE9BNTdxVzFKSXRMbG5zTnVzUThQSlIrV21DTE5PQ3d6?=
 =?utf-8?B?OTNuVTc4bTlTQlNSbjdHRmFVbDhoUzc2K2grd0ZRVWF5eWM4RGVBbHh5NEJo?=
 =?utf-8?B?TEVwQ3pEcWp5c3VWM3hPYTJNMGhxKzVNVjdCM1ZHSGZRUElVT0w1ODRZeTBV?=
 =?utf-8?B?OU41MndUWWdCVmJva0poUUF5Y3h2K09MLzNueDlrbE5EUzU1UEhudE5MUGlw?=
 =?utf-8?B?Myt5c2RxeDd1b09QN1BpeFRqUm9KUDFVV0pZZWxudyt6a1BUeHNCV3R3aWNa?=
 =?utf-8?B?UE9FRkZVYTRza1NieEFjeG96UGJMeXRGanllc3ArMUtHS2k2U1dNTjh2V2FQ?=
 =?utf-8?B?RXlySW9ra1daSm5XaTZVQmRDYWdpMldzNnlvanFUV05aT3RaUDF4b3FnM0w3?=
 =?utf-8?B?ZlJ3RE9ENHNPeGNMejh6OE84MXQyWUNaVkFsM25XNFRxRE4zU09iOTlOOW9r?=
 =?utf-8?B?MnpMRkd2a1FZM1BFcndqdXo1RG5WRkV5Q0tMQmlhdjEwMEMyaDlwYS9Hd0xv?=
 =?utf-8?B?YmJhbWdlUTJCRHhDTkdMQjdSNzNlV3IvMDUzYytlRFltY0FnamlmRCtNL0dE?=
 =?utf-8?B?bDZlNFpKdzBrelRuM2V2TnF6QnBsTFlJQlJBRkt3OTBMQjJXdzMrSldTYnU5?=
 =?utf-8?B?QzdFM2grU1NKRXJPVlJlSk5QMHRsdHJJelpRMEVjSlpzYXJhQVFCRXZQaFNq?=
 =?utf-8?B?a3RZbSthc0pYSmJ0aE94am8xREZzUnErZk5OZGtyakdkWnE0aVZQVW9CdVIr?=
 =?utf-8?B?dzFHaWRGRlpDODE1eFU5Y3AxdTVxVlNvekM1T3A0Y0preW5VRW9jUytvd0Ex?=
 =?utf-8?B?N1EvOUlzK3RERk1EYVkvMnNuYUR4NnorV3lBdlJ5eDc3WGthMThSQlRvazIr?=
 =?utf-8?B?R2EzUS9uL1dkNzhvV0k3dzk3d09NRmg5L291YTFaUnZiZll4bEdZK2k5VmEz?=
 =?utf-8?B?UjZUMDdUaFd0RVRKaWg3d21zeVVqZVB6ZmszOUgvbElzNjU2Rmx0TUwrQU9p?=
 =?utf-8?B?cEQwRk1xMWZ3c016dUZwVHBSQWlNNithU0pFd04wa3FWUGE0M3VYOXNWakIz?=
 =?utf-8?B?YnowVWdhSXdmSHQyM3BzMUtIUlFPc0lUMG9TalBDZnBuYlMxL0dUL25jeE9L?=
 =?utf-8?Q?bq4McGcwu1dd7lY0vpGYpN1fX?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	bvVZR949WCVUnQs94xvl+Ae37EhLb01nuEer4+t1HDp+FSuhhO3lpq0RCs5r0wuJTX/AihdT8ySJVfW1fOmLGCNAGnt7VB+Iyay/6J58sDT0QwJGz1J0wx6/4sViS3ga/y6batBrFDjbfPMAN6cUJGQQDsHUpmyqUuwTKAvVTLxTVrdDABF9K1ntoEAEAK7b4fg6oOjYXP7IN3QzlhyOXxlObw0464+v6ogXEhh4Q5yHqJWJ16ZK/K9WGsynC81HtPX4jHlKjaR5I63hb5dNSljg7PwgZIj8n7PxUPrrxfflF7NhEzhFTkreylkW6/d2fW4ECkKusV9NF2esqAPHCNqmnDh4Fdd5rwUW58Ak+fTN1xxOTDu9bSPhAwWisbkMZh0nANh53gmC7d4oiH4QqZRk8824V6i7XUFn/lp2q57LMQsVRhnGLoWjTqB3Vdx0IFLMDBB3qoZHcskMzfSWjr2mzA80V4ruohHkh4sOOgEWvUw8XJetiefjW2BKEeWk6xsUbEhh/7cBz8GNPbaXA6HzDKj8jVuh2HEyMN4EqnZnXmQBhrudXYAc3hTt1LhLFCHaANxG9uGbSVXYi9qaxcuMl55UcGBU3MS6k8zoG9k=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeddd372-0469-44fa-8921-08dc264a2a47
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 12:58:36.0509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wnqRwCSVcEabJ6Dp8F+Nycovwmro4rM5IDoWjhj/Yv4fHU2DGQEJ3Sxc7zlSvPamQ1nav+3tRTk+bV2GCA8Yhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6730
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-05_07,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 phishscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402050098
X-Proofpoint-GUID: vWoaa22YWDavXvqJye6pggubXnPj-IKT
X-Proofpoint-ORIG-GUID: vWoaa22YWDavXvqJye6pggubXnPj-IKT

On 02/02/2024 17:57, Darrick J. Wong wrote:
> On Wed, Jan 24, 2024 at 02:26:41PM +0000, John Garry wrote:
>> Add a flag indicating that a regular file is enabled for atomic writes.
> 
> This is a file attribute that mirrors an ondisk inode flag.  Actual
> support for untorn file writes (for now) depends on both the iflag and
> the underlying storage devices, which we can only really check at statx
> and pwrite time.  This is the same story as FS_XFLAG_DAX, which signals
> to the fs that we should try to enable the fsdax IO path on the file
> (instead of the regular page cache), but applications have to query
> STAT_ATTR_DAX to find out if they really got that IO path.

To be clear, are you suggesting to add this info to the commit message?

> 
> "try to enable atomic writes", perhaps? >
> (and the comment for FS_XFLAG_DAX ought to read "try to use DAX for IO")

To me that sounds like "try to use DAX for IO, and, if not possible, 
fall back on some other method" - is that reality of what that flag does?

Thanks,
John

> 
> --D
> 
>>
>> Signed-off-by: John Garry <john.g.garry@oracle.com>
>> ---
>>   include/uapi/linux/fs.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
>> index a0975ae81e64..b5b4e1db9576 100644
>> --- a/include/uapi/linux/fs.h
>> +++ b/include/uapi/linux/fs.h
>> @@ -140,6 +140,7 @@ struct fsxattr {
>>   #define FS_XFLAG_FILESTREAM	0x00004000	/* use filestream allocator */
>>   #define FS_XFLAG_DAX		0x00008000	/* use DAX for IO */
>>   #define FS_XFLAG_COWEXTSIZE	0x00010000	/* CoW extent size allocator hint */
>> +#define FS_XFLAG_ATOMICWRITES	0x00020000	/* atomic writes enabled */
>>   #define FS_XFLAG_HASATTR	0x80000000	/* no DIFLAG for this	*/
>>   
>>   /* the read-only stuff doesn't really belong here, but any other place is
>> -- 
>> 2.31.1
>>
>>