Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2420196rdb; Mon, 5 Feb 2024 06:12:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4fLIpCMn2hIbZupeUuuXxG0mV/7UKiC0m8hbj0xsExE/zdM1oqqq8uYA/7A/rtwFnK8b1 X-Received: by 2002:a17:90a:6506:b0:290:2e08:74f1 with SMTP id i6-20020a17090a650600b002902e0874f1mr11352210pjj.21.1707142362853; Mon, 05 Feb 2024 06:12:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707142362; cv=pass; d=google.com; s=arc-20160816; b=F1+/bPvR3ntJMV3NT2biB/zrEyr9C86w3Znz44KmZadD02UEnfQh9t5BnWHgGJIIRY X32Rqx6UybSoZfOE288aWl9ykqMyuv8X4w4mBqBE0dZGijfmFdMgOKFd3NHVp30QAeT5 u7LBRm8RoHhNaFZ1kwVKEqkTd7gjY/G9aKIMuLhLTJCARQTJ0gpRvHco4vh2zCXtT5yO Taw9sf0JNzyV9/clIUAT7KB3GsY0fDNNrZ9J4pHioTS6JVZG9TogRwPhcRvCY23ms/FC 00zz33VOfjO57nfVxCIh3o6NUXcQ2eOiae6qiSzZgVWg3xseDuPsaP4MF7tTjBQLCUOF xD1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature:dkim-filter; bh=YDCpBdBH44n875Uo+Dp3bavm/xtQGfLpbCMNSBVJmnM=; fh=BCwLCnr+UTQXZDc9wdaOW6DK4nD6Kw5sgtnOAdXlpLE=; b=I/Ua8ra2cc0S92eLGhatBfHmYiN0fELIsjAObDajKciLl2n0lbu3uy7LxZ38DgtHyn wHRawf9ZXw5lrSCrpVTeACCKRuVfSneamy9rEGB/JpjKfWfJ3a2OXMbhYE2Ha/YYVkH8 oEhXEaD+hR/yhsXYaX9xHyP6hFNWtHe9UOpAmVpmahPKeP4zxAdonU+lbLrJgqe9AuJb O6i3MhPeLnE8nIx/hTvXFpewpMdnbC0mIb43IHjOiZAwLPt8HGmA1x20w/8HWXVZuEE/ 4cVfRM212o6IUTi1gwTK8mr9wtOMBFLqF2r1wzsnEMK/T4SKuMqmFpDwbgiGIXtViCBH +aBA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=Z9XEH17V; arc=pass (i=1 spf=pass spfdomain=ispras.ru dkim=pass dkdomain=ispras.ru dmarc=pass fromdomain=ispras.ru); spf=pass (google.com: domain of linux-kernel+bounces-52739-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52739-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru X-Forwarded-Encrypted: i=1; AJvYcCVHvNFEj0H/hdyqOlAqJv48V+GuODNfJoUu9b7Ps+6u2JwTHty1mx0PVSE+5vsnPVEKpbuXyBt8iOyGFfkisRCF7wvUyHbxe6Qumi+XsA== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id cs19-20020a17090af51300b002967fbbe555si2888631pjb.94.2024.02.05.06.12.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 06:12:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52739-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=Z9XEH17V; arc=pass (i=1 spf=pass spfdomain=ispras.ru dkim=pass dkdomain=ispras.ru dmarc=pass fromdomain=ispras.ru); spf=pass (google.com: domain of linux-kernel+bounces-52739-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52739-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 18388B26FBE for ; Mon, 5 Feb 2024 13:41:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 84D7122EF8; Mon, 5 Feb 2024 13:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="Z9XEH17V" Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE8D4210E0 for ; Mon, 5 Feb 2024 13:41:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140504; cv=none; b=JgQ2HnIaSww+osSgZZlHZlz/3ygjKN3JuUCiXeVsJS/rTX25Da0JKHCEu9Ii6X45cPT3PlgMAFbar0Fk90igVeh9gL18xCXEr7/VeMHX2u39EYWfFXEkcZtNYLig5Yyn0nTquxvR4qVm6wGkKOR2eNkchoHDjeJRGu2T+XKleTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140504; c=relaxed/simple; bh=YDCpBdBH44n875Uo+Dp3bavm/xtQGfLpbCMNSBVJmnM=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Gfl5JWF4J+EvnidaXetnVcNUXiQpMKRq00GjRWrzuw1hy3MI57/0UYOiXwoHrtIMIvIYpJog0VeexJi7trCG8yJdrvlyvSXwnFGg0qFmxXKlC5V+q3jhkRaB3N+pdQpy4ikuT/guaDa12sfLw5/TVAhizXqtrg2vopXT4NPaCqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=Z9XEH17V; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Received: from [10.10.2.52] (unknown [10.10.2.52]) by mail.ispras.ru (Postfix) with ESMTPSA id 69A4B40F1DC3; Mon, 5 Feb 2024 13:41:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 69A4B40F1DC3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1707140497; bh=YDCpBdBH44n875Uo+Dp3bavm/xtQGfLpbCMNSBVJmnM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Z9XEH17V488MN4orxS8XupWyLBttTuNEfX6vlHM0qtvrEDQcHVfOz/eF5MUDbxdfe rP3kfIIx/oU8hqAS5AiAaVdjGCKkQWinaQz69DXbGJYLves2mq7ysAmS/ulwIjEvDT pnE+hOQf2UjxwuFxnMnN+SF3n8DK4wPQlMN9OlLM= Subject: Re: [lvc-project] [PATCH] drm/amd/pm: check return value of amdgpu_irq_add_id() To: Igor Artemiev , Alex Deucher Cc: lvc-project@linuxtesting.org, "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Evan Quan , David Airlie , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20240205122522.81627-1-Igor.A.Artemiev@mcst.ru> From: Alexey Khoroshilov Message-ID: Date: Mon, 5 Feb 2024 16:41:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240205122522.81627-1-Igor.A.Artemiev@mcst.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.02.2024 15:25, Igor Artemiev wrote: > amdgpu_irq_ad_id() may fail and the irq handlers will not be registered. > This patch adds error code check. But what is about deallocation of already allocated memory? -- Alexey