Received-SPF: pass (google.com: domain of linux-kernel+bounces-52804-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Zi Yan <ziy@nvidia.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 "\"Huang, Ying\"" <ying.huang@intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>,
 "\"Yin, Fengwei\"" <fengwei.yin@intel.com>, Yu Zhao <yuzhao@google.com>,
 Vlastimil Babka <vbabka@suse.cz>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Johannes Weiner <hannes@cmpxchg.org>, Kemeng Shi <shikemeng@huaweicloud.com>,
 Mel Gorman <mgorman@techsingularity.net>,
 Rohan Puri <rohan.puri15@gmail.com>, Mcgrof Chamberlain <mcgrof@kernel.org>,
 Adam Manzanares <a.manzanares@samsung.com>,
 "\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v3 0/3] Enable >0 order folio memory compaction
Date: Mon, 05 Feb 2024 09:18:20 -0500
Message-ID: <9E4B4BE2-0A00-4D76-A0A2-8EA67BBEEBDA@nvidia.com>
In-Reply-To: <36d709fb-967c-42fa-a47a-465e29e13ef6@linux.alibaba.com>
References: <20240202161554.565023-1-zi.yan@sent.com>
 <36d709fb-967c-42fa-a47a-465e29e13ef6@linux.alibaba.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_93F9D700-CF0D-4982-BD69-0710D70938B2_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?U5sVzGJLzAx/F4Tvywu6xQIdIZRwrc0X6weYl7XCxnoNz4AI+yGPLACGcqWC?=
 =?us-ascii?Q?jsCwk6UcjN5rTHCScObKzJMe95vCMjc7eZArFfRQrl5q+q/6NdBvjM0SEDE5?=
 =?us-ascii?Q?272ngMU0Sazd7vtJPIQEx3fc3VlCNnnt5NFJuTPrjLR8o6NUzhRbOBiDldgP?=
 =?us-ascii?Q?eDJSMhOCJggZQ+QVO0vVVUO8QHrVYBuHrOnHmalsq4fUVmIntI5dJg+gnve6?=
 =?us-ascii?Q?pZJCLYeHTy93jGJD+Ksvie9eajd22R+YrRE38VTLRT/33wIqNdu+Cp5LguOt?=
 =?us-ascii?Q?jHjazXAidNjOvjFWQUJCqjKO2QFmU9W6vgs33qRqMasPrhQ/Q0h95XHR/Ot8?=
 =?us-ascii?Q?JNiySStI+ar9awwQCzb/5n9kedR4IKrgbKePtr2jNbTSk9VYpeBu4gUGrbPc?=
 =?us-ascii?Q?IGgEGvm5kIcYToyCjBTUgyIamBfp06aRMhcA5HDeXY/Wikrb7hhexvOE0dko?=
 =?us-ascii?Q?q4dIt0vfrS1yAEwcZdITnU4KQvnCT+XouZAjUCOhHMcqQ5rVQmhtad5//YxY?=
 =?us-ascii?Q?feffJWDqKHoLJGQZqE3hRA/OQ9MUQDt1Pb0iX1W3y+kZb1I8nzkpiMxBeYk+?=
 =?us-ascii?Q?yEih8FIo8boFY/KyfyKSzp65aVkpATK/LO9P8mlXrqGJmDvT9xk22NJrxinw?=
 =?us-ascii?Q?frWAe7tWVIliihFLFs7Gzenr3da4H8poNcUyO2M8269G9XDp8svdvgHOo19t?=
 =?us-ascii?Q?2WzquQvVTe82BZjgbkzpmOER+Z6lgp+ipJ+Vm8NsRuPvfY1qWdglbIwhoRbm?=
 =?us-ascii?Q?smX9ETQ2h9/KPQmPHSqZxv5JQkeG4Gf93Wfv/GypD5UOPQsONhwESXak6Wna?=
 =?us-ascii?Q?mUeeXoSvqT+ExWekCp6eif3R3mAmZh7i8iwxPsdHYdZGG9nsXCJfA/h47SoG?=
 =?us-ascii?Q?T2AJC46Jl4oIRkwL8OFJvFpfjtpipYn3JpTTEbf1QLM/FE/G/pBWuMxW7x7I?=
 =?us-ascii?Q?YqP6s+LxA6ppvUMt0jw2KySE9nt4yCPWun0KsFSi8xu4Q5MjSCFCK+Rgzfr9?=
 =?us-ascii?Q?CLHUJm4716ZE9muvi/IxcGWYBRcIKz3IEsbd5iNRDtPfzMgCzb47LZ9+ZtTr?=
 =?us-ascii?Q?iW/kjPG8JGQUhpvB8f5+Vn3bnY18YAR0yLwLbHImkOozEs8zUvX2Vl+Xsp7h?=
 =?us-ascii?Q?2VwRprnyWLenQFAW2penLUe56pDDxmLl8sZAIGDN0ZL8dDCJaJIcW0/H8L/6?=
 =?us-ascii?Q?WwzI/nopApoKzq8bwdjAvdg7dzeTrzfA5j9Xzz5Ou+7k0hJ9TMF15QnFUUxL?=
 =?us-ascii?Q?xTZ7TuIDuV8Vg3G5QaNK4+F50xYYhr0Z5quBtLrvJKl7E8KPqLwvQBl9uziy?=
 =?us-ascii?Q?WNqpZngTNh8oxIyfmGDziYCHVBYllzdGewjBUerM9e1WCxGLfYBh8c/iLpV/?=
 =?us-ascii?Q?pMfxRaOT6kPOijZOGNywk83dz7i5DG+mUt+pp7uz9lmicI0P/RmifrYOBw2/?=
 =?us-ascii?Q?XbmTbcfHlLYRd3NwNeZLn+CfkvxjnAFBvMzVVqqPJkePeCCGO51RM4xH7PJO?=
 =?us-ascii?Q?iVcjODUNpTnXjww65J5a1jejYd6o2SRb5UdKKSZkkjmEnIAp+SnrNUl4A1r3?=
 =?us-ascii?Q?unNnrh4ttivYrIIdVzE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0016c28e-8e0d-4d29-52a1-08dc26554f9c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 14:18:23.2163
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ey4v84UYTtuCMuK/OlEsB4aXL45tKZKbo5gvG09ydmMVEyLdBSHr2gs6vAC1m9f8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4070

--=_MailMate_93F9D700-CF0D-4982-BD69-0710D70938B2_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 5 Feb 2024, at 3:16, Baolin Wang wrote:

> On 2/3/2024 12:15 AM, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> Hi all,
>>
>> This patchset enables >0 order folio memory compaction, which is one o=
f
>> the prerequisitions for large folio support[1]. It includes the fix[4]=
 for
>> V2 and is on top of mm-everything-2024-01-29-07-19.
>>
>> I am aware of that split free pages is necessary for folio
>> migration in compaction, since if >0 order free pages are never split
>> and no order-0 free page is scanned, compaction will end prematurely d=
ue
>> to migration returns -ENOMEM. Free page split becomes a must instead o=
f
>> an optimization.
>>
>> lkp ncompare results for default LRU (-no-mglru) and CONFIG_LRU_GEN ar=
e
>> shown at the bottom (on a 8-CPU (Intel Xeon E5-2650 v4 @ 2.20GHz) 16G =
VM).
>> In sum, most of vm-scalability applications do not see performance cha=
nge,
>> and the others see ~4% to ~26% performance boost under default LRU and=

>> ~2% to ~6% performance boost under CONFIG_LRU_GEN.
>
> For the whole series, looks good to me. And I did not find any regressi=
on after running thpcompact. So feel free to add:
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>

Thank you for the review and testing.

--
Best Regards,
Yan, Zi

--=_MailMate_93F9D700-CF0D-4982-BD69-0710D70938B2_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXA7iwPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUZrYP+wRGXfeWoSNa8mVuDhnRtrMzBQm2Zvq5dSs+
1TESZ2DebfMqlVbVOYq+KSeTKwthCKdjc/FQdPosLMkVVB8VISK2cj8hOJH8FEgH
wlxM/QVipm9dRaD5ICZjY4eojphpcblCZUUHpu7am5rtBHXW8Iu2njbI+Mcy61vM
6OCLxQd3hEBZXczoQxj1/6oaNraOG1mszJj+4XccE+drQzfICB81JwLQXnyHAH8H
8m4mpJxcNthXat4b6xiJWZqf2xmCxfHNvMmgVQD6A+yCrs3EKiEFnfmKSKhiKIQQ
6dT/qXexLKKxZ5J/hKuFw5JoRqb0hEL69lD+vo0KzNCYFwNm6gjDeewfo0Hr/ZO4
LNNq4A5Dq2MB8t+xBs3zZqUuNcCYom0JxgDKJON0739NRF0RewH6y2hUXhiviAvN
Dtgvr/Xx/cfRL4eBZV1ilvxdXpuJ13jq1SvrOJNhG55IENVFC0HBnllwYj91WJ1R
dQkIp4oQaA3CeElnvFMcxIWHwQQMEG2ltHVTGbrbppsXu0pkBRUEa2Q84v3q0Zb2
5wMPeamBqyKjoipy6z3LG9+C6rPV+lSUwccuiUfXDWOZmrB15RQilhW0+1GW9RzQ
xSeSz/JowOjIxgmrTPezQnwHjBZXvAmbti4QHnbg3irLqgkaD6aY/eleX9+oVJ+6
fiFwmROi
=2SXr
-----END PGP SIGNATURE-----

--=_MailMate_93F9D700-CF0D-4982-BD69-0710D70938B2_=--