Received-SPF: pass (google.com: domain of linux-kernel+bounces-52814-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
	miquel.raynal@bootlin.com,
	richard@nod.at
Cc: linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Takahiro.Kuwano@infineon.com
Subject: Re: [PATCH] mtd: flashchip: explicitly include <linux/wait.h>
Date: Mon,  5 Feb 2024 15:26:20 +0100
Message-Id: <20240205142620.390286-1-miquel.raynal@bootlin.com>
In-Reply-To: <20240205100955.149755-1-tudor.ambarus@linaro.org>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On Mon, 2024-02-05 at 10:09:55 UTC, Tudor Ambarus wrote:
> While reviewing the hyperbus sfdp proposal the following problem was
> noticed:
> 
> In file included from ./include/linux/mtd/gen_probe.h:10,
>                  from drivers/mtd/hyperbus/hyperbus-sfdp.c:6:
> ./include/linux/mtd/flashchip.h:77:9: error: unknown type name ‘wait_queue_head_t’
>    77 |         wait_queue_head_t wq; /* Wait on here when we're waiting for the chip
>       |         ^~~~~~~~~~~~~~~~~
> 
> It is good practice to directly include all headers used, it avoids
> implicit dependencies and spurious breakage if someone rearranges
> headers and causes the implicit include to vanish.
> 
> Explicitly include <linux/wait.h> in include/linux/mtd/flashchip.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel