Received-SPF: pass (google.com: domain of linux-kernel+bounces-52771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240205110244.676779-1-naresh.solanki@9elements.com> <8714b420-58b9-4d5b-a489-31670c8d325f@linaro.org>
In-Reply-To: <8714b420-58b9-4d5b-a489-31670c8d325f@linaro.org>
From: Naresh Solanki <naresh.solanki@9elements.com>
Date: Mon, 5 Feb 2024 19:30:42 +0530
Message-ID: <CABqG17jfHpi5oDt+=E925Fp6DN2OftmDEjpmvb5=3nxMt+d2iw@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: mfd: Update pattern property case
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Patrick Rudolph <patrick.rudolph@9elements.com>, mazziesaccount@gmail.com, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Hi Krzysztof,


On Mon, 5 Feb 2024 at 18:38, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 05/02/2024 12:02, Naresh Solanki wrote:
> > Driver expects regulator child node in upper case.
> > Hence align with the same.
>
> Did the driver have DT support before? I think no, so why aligning that
> way? I would argue that driver should be aligned with bindings, the
> moment you add DT for the first time.
Yes the driver has DT support already.
This patch is to align with driver:
https://github.com/torvalds/linux/blob/master/drivers/regulator/max5970-regulator.c#L381

It was aligned but I missed on case sensitivity.
Driver expects it to be SW0/SW1
but DT had it as sw0/sw1.

Regards,
Naresh

>
> Best regards,
> Krzysztof
>