Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2432211rdb; Mon, 5 Feb 2024 06:31:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8HY7zKNQmK+Aq453/TwWF5y8uP66uhlug4VmL/0PcC2x9WxpY5rcWxm8d9hmtxoO9qScO X-Received: by 2002:a05:6a20:1e60:b0:19e:3343:43c4 with SMTP id cy32-20020a056a201e6000b0019e334343c4mr11477383pzb.36.1707143515569; Mon, 05 Feb 2024 06:31:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707143515; cv=pass; d=google.com; s=arc-20160816; b=gRLVlUPm9a8cTRum7C93VcGD72+3TjgK+iehIEbm3fUdDUbwqo7M9cLwUC6qmmBt9f vV29mx5meKRt3TjhtyWp7q2Tr9X5Yoaf/Ei6AK5oNlj+W6uty8U5AX2Vjpr0Ghv0Fun7 1o8OLH2N5mFAn/eDvRV3VtxNUiKlw+sk15Ib3FSYAq0Wcd5GRFvwh5SLf5O47bQ9S9Jg 4ls6146Gz18YKAIcL0t8jKp3vReStzqvX3BJVUKsc8J1T60Hpi73VzvWoTbvMHktU83B dONVWd38Yw2VxYn+EHpiya80Q+2mMDhXSzXIcOJZfX3qfvA13rQHA723+7slatY7Prt3 Q2sA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=b2JAI2uMtVsoAej+dzrBCr0K8iDdaCg3Co8PUqB8W7M=; fh=bBueVa+BnaxLnq3Oty3GqLnTaPV7cUFuEqForVshIYs=; b=ekzJFm8ZbWP2CqcUuiS2rDfhOg+FiifdF5TfTYwG1voiu74La6gLBaaDWGjHwKx/EB nTydPg/BA+FkzKAaswxVgxlF918lz70I0d6RkX9R5hxxGVp7gKHwVufMcXnQDjyVD3K/ AvnKZnkgu4JOwzTknR33F4kolxJysFzVvgyrWP9kLLTt0GYjF5Brgc7OnQTXKPwfDfSv uHGTONgbma2fQKczEaSOy09fMPUkyfFhELy0CYfuCJlmgOy/Nz2PXxlEtRzSIarHUuyp x1XFG4g6L9z2FjxcyXR13x058MaOz1YQHhNA7AbyxrFAKUZhN+yKtspC8pfl6iYOq9GP sxcw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=davidv.dev); spf=pass (google.com: domain of linux-kernel+bounces-52825-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52825-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCV9DTFHGrTgyD9UBbHFN/CiV+KMEAKJDeHUuRudbNqbmMlLS8nm99v/fxxfCkI8lcV1TbQLtYeLjHMBQUJ+TnCRIyoJNLIgIbkiLS4uvg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jw4-20020a056a00928400b006e03b590869si2747847pfb.241.2024.02.05.06.31.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 06:31:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52825-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=davidv.dev); spf=pass (google.com: domain of linux-kernel+bounces-52825-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52825-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3FA6B281832 for ; Mon, 5 Feb 2024 14:31:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3D37F2C1A8; Mon, 5 Feb 2024 14:31:43 +0000 (UTC) Received: from davidv.dev (mail.davidv.dev [78.46.233.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AC092C693 for ; Mon, 5 Feb 2024 14:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.46.233.60 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707143502; cv=none; b=WyexcppPH51eR6ZH5YVSfzlKWlU36YwR525iLQNZdrDB1MQkCPL98KpnFiiHPAs4I2dWtsUUdMLCDchFE80h3IWZJYCbiRofpWEN2w5tcwaXoEqKGRdQGZFrASeqIm40HAHNnEVARFEgpANADkpN1Iq7fdXnldRGIm6dA3/lpR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707143502; c=relaxed/simple; bh=GGTif6QrhiFR3v2KdIfHhHcqC9cZcUSFm6BvXU/Sy0I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n/MUW7w8BRfXu6k74fNimzcaTeUo1MymxSKtKPWG1lxNpa/A8jsqW9g1i+4ugwTMM2U0VtyUzml/3hp4rwBvI/4MllGDRRbxoFay/aM4OUq2/DB+KD78Gsgdbudsr8s5aVX8vRXyJ0wLAIsqn05xXzBixMmwvmNH7qgf2a2Blng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=davidv.dev; spf=pass smtp.mailfrom=davidv.dev; arc=none smtp.client-ip=78.46.233.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=davidv.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=davidv.dev Received: from [192.168.2.153] by mail.davidv.dev (chasquid) with ESMTPSA tls TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (over submission+TLS, TLS-1.2, envelope from "david@davidv.dev") ; Mon, 05 Feb 2024 15:31:39 +0100 Message-ID: Date: Mon, 5 Feb 2024 15:31:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: make driver settling time configurable Content-Language: en-US To: Andrew Lunn Cc: Jonathan Corbet , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , "Paul E. McKenney" , Randy Dunlap , Xiongwei Song , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20240205114609.440597-1-david@davidv.dev> <1e08910b-8ae2-4985-8423-45a1a823cefc@lunn.ch> From: David In-Reply-To: <1e08910b-8ae2-4985-8423-45a1a823cefc@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/5/24 15:06, Andrew Lunn wrote: > On Mon, Feb 05, 2024 at 12:44:40PM +0100, David Ventura wrote: >> During IP auto configuration, some drivers apparently need to wait a >> certain length of time to settle; as this is not true for all drivers, >> make this length of time configurable. > Do you see this problem with multiple drivers, or just one in > particular. To me this seems like a driver bug, and you are just > papering over the cracks. > > Andrew I don't know of any drivers that may need to wait -- I noticed this code path being hit when building a minimal kernel that only had a virtio network device. At least for the virtio device, the wait is unnecessary and bloats the time to boot a minimal kernel from 15ms to 33ms.     David