Received-SPF: pass (google.com: domain of linux-kernel+bounces-52876-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 5 Feb 2024 09:10:41 -0600
From: David Vernet <void@manifault.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org,
	juri.lelli@redhat.com, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	bristot@redhat.com, vschneid@redhat.com, kernel-team@meta.com
Subject: Re: [PATCH v2 3/3] sched/fair: Simplify some logic in
 update_sd_pick_busiest()
Message-ID: <20240205151041.GD120243@maniforge>
References: <20240204044618.46100-1-void@manifault.com>
 <20240204044618.46100-4-void@manifault.com>
 <CAKfTPtB5NbvJt58zpi9aM-8kOxchgzYccY03wUEQLypaWjUXew@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="UEH2QWNLig8kLnOw"
Content-Disposition: inline
In-Reply-To: <CAKfTPtB5NbvJt58zpi9aM-8kOxchgzYccY03wUEQLypaWjUXew@mail.gmail.com>
User-Agent: Mutt/2.2.12 (2023-09-09)


--UEH2QWNLig8kLnOw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 04, 2024 at 12:48:11PM +0100, Vincent Guittot wrote:
> On Sun, 4 Feb 2024 at 05:46, David Vernet <void@manifault.com> wrote:
> >
> > When comparing the current struct sched_group with the yet-busiest
> > domain in update_sd_pick_busiest(), if the two groups have the same
> > group type, we're currently doing a bit of unnecessary work for any
> > group >=3D group_misfit_task. We're comparing the two groups, and then
> > returning only if false (the group in question is not the busiest).
> > Othewise, we break, do an extra unnecessary conditional check that's
> > vacuously false for any group type > group_fully_busy, and then always
> > return true.
> >
> > Let's just return directly in the switch statement instead. This doesn't
> > change the size of vmlinux with llvm 17 (not surprising given that all
> > of this is inlined in load_balance()), but it does shrink load_balance()
> > by 88 bytes on x86. Given that it also improves readability, this seems
> > worth doing.
> >
> > As a bonus, remove an unnecessary goto in update_sd_lb_stats().
>=20
> The line above is not relevant to the content of the patch.

Ah, thanks for catching that.

Should I send a v3 of the patch set? Or should I just let whomever
applies remove that line?

> Other than that
>=20
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

Thanks,
David

--UEH2QWNLig8kLnOw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRBxU1So5MTLwphjdFZ5LhpZcTzZAUCZcD6cQAKCRBZ5LhpZcTz
ZPMwAP0SnSO7/DMjdqfi6y8VLiWP7NqgRp5M8t7ljMgXl2Dz6wD/fIq8Rk7xK/2f
A/4uSvbmiWD+YTbJSjC2O6ry/+8csw4=
=alps
-----END PGP SIGNATURE-----

--UEH2QWNLig8kLnOw--