Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2465467rdb; Mon, 5 Feb 2024 07:25:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFKdOEZQS3VBmi9pRD+emGrGXsIDWpSIYp4UHVcRI370A9Mk9rZ79FjZyJidmRIdoXC3qce X-Received: by 2002:a17:906:d14b:b0:a36:7189:af7f with SMTP id br11-20020a170906d14b00b00a367189af7fmr12489122ejb.50.1707146755359; Mon, 05 Feb 2024 07:25:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707146755; cv=pass; d=google.com; s=arc-20160816; b=DV2nMUuW3zGePUz+5Fjcp84/vCTBWU8Jt6Btc8s+mahNI/Bx73Rbd1VS2xMT/HC7/v XAqlS12+OCd4ecAUEjdpiivCLczUuNdzRoDKPE9FGMfez8xR4Se0CCwc77QEDbkIRFuI z1t8YasOgMqdzNmE9xKyXEdYsN5zHW4HK9TuEmtA4VXDu/gCc8JeVCfIsu+JFHgqwRVp 6H2SFx1JK2POgqeDAN0BqgUneKcYCHf77IOfcyWz6fahaGLFj9NaMbz3+0Ind0lZLTSO EjylCaipGJJgWMId/E4Elfe0reUlAAqGpOfNy3q81TXBV+exlsVDXNbTX00PDtZP9XxB uRdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=HKwxeUSsLvhmFJpMmpEtAXXRzIFcWThX4sy4vjHNQ7Y=; fh=9/siILW8B8ALkAN0twauxFnhSMGjBL3FY1ME6IgUgME=; b=zCloEvoNaFSVnGkXEvHiXrLLr4r1Z/WsKkFmBLephxrGcNOrbcA87XiwJT/MqaYrUd r/vO1tZm8+XgIb9HLLOkFij5Jyqp8g7e2gHpGnQXfQnDqUkqOLOmo3axtvcBfZ1THTsa OGPlFGf0NYD/xpebgdZgoTRmKU8zOW3x+iMm08sY9kAgjghB9F1pPBzSvuCaL5qM24B1 2biV2+2/OfvbXqnC1GH3TimQS6q9+YvgoBuXUzALExrXM0eeKpLNBSPEyncWwO2+EeXl k/wWgvM+x/JpVSRvyg2Kh15teFY10DK8DsVfwLOVCKRhdCsTpj/NvLm8+/t4GqXx/Hdt kCJQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kpj4suvj; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-52899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCWAQF9DkTnqX4+osHdPeUkaQWnN+xPb/IwQ3/8frvBEdSW3spO01zm5m/PYD/vl2gJTZ+nuXWh+eU/t2doREjCfkvqq9wiiPn8tf/ES5g== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id d21-20020a170906041500b00a37654d0804si2409190eja.145.2024.02.05.07.25.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 07:25:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kpj4suvj; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-52899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 114121F260B1 for ; Mon, 5 Feb 2024 15:25:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D6682E41C; Mon, 5 Feb 2024 15:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kpj4suvj" Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 864EF3A1BA for ; Mon, 5 Feb 2024 15:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707146705; cv=none; b=IHGpCBqZAqW4lsTp5OS0ohKmHZV6+pelU4jCsN+9dHZ82h9JVdZftj8+uL1HDgoRpi/NsCBKy90odsm6gde1GQhFu6a4NYGjwX9gnVBWFkJ7kp4Suj3pWDFv1zNbHRvfvnH98q+BwOEA8xwwZ79G7k6Xm88+fCZuK47I8scF/lc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707146705; c=relaxed/simple; bh=HKwxeUSsLvhmFJpMmpEtAXXRzIFcWThX4sy4vjHNQ7Y=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=EETeZDLkgrLPgvsBr1Po8d4ABLOUkg8CEG3reh+0Jo7e4nnMZhzo/XZ51I54Hke8vxSi3ceAHdBI9BbZ9MRPMDS1JW2WHcT1oLc0sAg9tKfAXl5c4qE9fAtmoT4D+vowtDiLC/m89BkIWWsOrWOoXOsmsvU8ggcUJqiba673KOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kpj4suvj; arc=none smtp.client-ip=209.85.160.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-2185739b64cso2999747fac.0 for ; Mon, 05 Feb 2024 07:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707146702; x=1707751502; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HKwxeUSsLvhmFJpMmpEtAXXRzIFcWThX4sy4vjHNQ7Y=; b=kpj4suvjEaFOuSQ5DCte0p/y4dABRIygiWIT+hNr+j5yZQPs2Gvqp1FF+FVXLV4v3m a+yeSJTeF1mhDnCepLLExo2TB4t6yi05qwz3wqiubAklu68qxDPXBGANRy89V8yJlRgP vdA64R0AP4y/OCqz0+as+RGEZACAThDYuIV1QtTnnDQl+l6mQe7rWcKkjLMR++FeQ8dp 1ddmlpGhySzqTrOnoubhe/XSJAb8WwcpQSNQkMwyTyN1OOtc3VqLcNfbWp0S40MQqVyL DB7W1T7M9dB5131LVqiMtozFgCP6TiI0p86PBjodOxHyu5hpGnYJuIHYkw2iXc8Xpsc6 uwRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707146702; x=1707751502; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HKwxeUSsLvhmFJpMmpEtAXXRzIFcWThX4sy4vjHNQ7Y=; b=AwmE59l9PFHC9XqRPfV/9aPS3uF43QVTm52a+zVstP4IB4m6GJTnMkdj2OS5EUTj69 7ACgobr+GNFM7rP/SN57GLST0Y1JlXddASyd/aBzp4Q6/jSFmn/WRCe7YNkyhcjgcPve MxXxo68yokQ+AriqCK2XJjPPVqzuAxjDv2IlO/hamZoQwcBw2Dj2pkEmX6nVtlWQpOx5 iYq8oluzKPx9idZwGSEhr8NzoZ49Ip0LdkPPWTjmd1+GPHV9uj6vXSReMZQ4ovSo8btL mDKpnHe1QmSg9SdumyMXeYRMo5s/pi+B2lGctbLzg4dyoRGYYg02jKdLoTFRoM/q93E1 4uZg== X-Gm-Message-State: AOJu0YxGn8w8xbT6Sa3cPModfr343PcB1UpX3mlxGdNX5LuzuTYU8Y2k KK5xIrmxAl5TBbAeIKVHLJz7TSh0w5x686wd+HW8w3Qk3t9KJuqSWYrQkZneolZcUn0kfJltQOX XpzCkRELtjP9xVYFfLJux1PoVjbLikvzAC9o6bA== X-Received: by 2002:a05:6870:390e:b0:219:476a:c1a8 with SMTP id b14-20020a056870390e00b00219476ac1a8mr13118oap.6.1707146702651; Mon, 05 Feb 2024 07:25:02 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240205124513.447875-1-tudor.ambarus@linaro.org> <20240205124513.447875-2-tudor.ambarus@linaro.org> In-Reply-To: <20240205124513.447875-2-tudor.ambarus@linaro.org> From: Peter Griffin Date: Mon, 5 Feb 2024 15:24:51 +0000 Message-ID: Subject: Re: [PATCH v4 01/16] spi: s3c64xx: explicitly include To: Tudor Ambarus Cc: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com Content-Type: text/plain; charset="UTF-8" On Mon, 5 Feb 2024 at 12:45, Tudor Ambarus wrote: > > The driver uses readl() but does not include . > > It is good practice to directly include all headers used, it avoids > implicit dependencies and spurious breakage if someone rearranges > headers and causes the implicit include to vanish. > > Include the missing header. > > Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver") > Signed-off-by: Tudor Ambarus > --- Reviewed-by: Peter Griffin