Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2465655rdb; Mon, 5 Feb 2024 07:26:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEbid538Upfz/DBXm7ZEaPG6PqUilthpnDDwp9BK/LSS+l4iR3fJqd7PynG/xESDQoQ1KHi X-Received: by 2002:a17:906:22d6:b0:a36:c845:86c2 with SMTP id q22-20020a17090622d600b00a36c84586c2mr8149607eja.51.1707146771243; Mon, 05 Feb 2024 07:26:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707146771; cv=pass; d=google.com; s=arc-20160816; b=GV9Gc6UBJ60pN9m0DGCd9Xb8cW8A1qi4IND010ABKX2JO7+hUHTx9RiTeETi/E0Kzt lal4DnCI8AYtm2JqTjlW2oxCIC3nEUDuJ92rkki701SXN2/2XuosLHldLnXQnrwTaFxq BmVTR4PSfd+pVWdREK74fXvxybLm1WB9rq6ac4NFXGjh+C39MP+PFEwUvw7TmgIsdyl5 OSXXPrJWG0cYkzEd3mwbcG/NHY0s/RongMI/Y+OTi4gLtjIIrQ9Ol0Oj+HOo1uZYDtjg DWbM7oGKJI8nK2kU83MtDg87CKlUxE4PMM4sy4ue+B/DqHl5UfHQsli2dVTI8ISPQGsl QG2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=4KcubRPRLUqgqIoz5G5H+XPel1vrIIpMYFvwjaw9uKE=; fh=d92E7pi98dK9F0nC6O+Kd+gnm5vqmnx0e32Smb31VFw=; b=tcfAsxRj3MfUp88yHsRFikDAEuEMB4y8Z8K3hAp9mrqcivjdh444zBnvXF5kbomoIw SoYmZeQMOiMKQ8aDgQbuVH8uQqAklEx4+iqQV2/pm4Od31Pd9/m4/OZvYPA+9U8YEvt6 zjPRLeQqzk6rCWAOUMGQnW/6ZN3gCfRHbe+ChxzHzKoXoRtiGeX2fTE7n3jC9/XIfLkO kyGRXZZRs7cAzXC3o7ffX16BW3AIxgd1mTBd+7UkMnNUHzc5xmWd+qocYukEotD/qe4E 8cUqz0zztE/qiRvsIOqoIRgLhcsqlFLYOlrWcCbRyW1oY8Gb7q4cxtKdYI6f/pOUCY03 Q8JA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sAoqS10W; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-52900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCVAYtMFKgeYgjI7QBOVAh8/gFSc8yMWwdYSMI8d6Km1GXDApDkk+6Guq1E3Ox969o47UMk2zuRTklwC3dgw4Ok9BswEhqqbxB1g0BsqrA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ca24-20020a170906a3d800b00a28ba5dd13asi3699696ejb.1055.2024.02.05.07.26.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 07:26:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sAoqS10W; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-52900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 026461F264A5 for ; Mon, 5 Feb 2024 15:26:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E15CB2D03B; Mon, 5 Feb 2024 15:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sAoqS10W" Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A7F23A1CF for ; Mon, 5 Feb 2024 15:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707146731; cv=none; b=IbPqJWxBGTQTPlUkRdndKFqlI2rI7dGpLU5r2P6CH1mwmpdbF9CNgthlczW66Rj8LPcSArkd9Ov8c1AvkFUGmPoWars0JfOUNKaZJLyK/qjrrhEZ9o8ioqe7s7bRcPoZJXzuSTG7b0UC68JYF/GjpVP9AjZIuZK8yKFBXtKfkNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707146731; c=relaxed/simple; bh=4KcubRPRLUqgqIoz5G5H+XPel1vrIIpMYFvwjaw9uKE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ByA8bB7MDb/K2ato5PGp0fWtXsDtzBCblIa2SX7quZEcU8kyUSfIC601vdAdqoYnVSdzwWSUcQFBeBVcHCUitgCu50m9t2dTPB3Ebk9TIBzw9pN9VQ5AC5jY1v4KWjOL+yHLviZbguXef3zMNafnjl1w3mCuvdNdgxPBGlEcFwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sAoqS10W; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-56077dd7936so1022180a12.2 for ; Mon, 05 Feb 2024 07:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707146727; x=1707751527; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4KcubRPRLUqgqIoz5G5H+XPel1vrIIpMYFvwjaw9uKE=; b=sAoqS10WJHJI2Fk6qNhhy72Kz0PgZl7A/mdvMk8hbtAf3uMeMi7mWi0RhlQKZfNDEK JgWwedqF6je0KSWvm9xmn91PfbOpU8WZZKYhu+qjdDn5vXluyw2ng63+ouNH7obcY8Ms c5/F/tpjpaDgdAUx8XxUsD78Lm3vfgvbFtmyGxyrWGVylG1iMcxohPPMsdhFuvT4rV1T EDqIGUfhickbzISEVES5KxXzdIhiib1xkGq95l0mWTkIXOu7qSClUdb8jf/xrOr3g8gp QieNq2n0XSIzjK9gFsohWdJ6K1TVYmVNGSNr1WNmwotHZ8BpkFNp40FGX2MoJ/OyX1B/ QVLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707146727; x=1707751527; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4KcubRPRLUqgqIoz5G5H+XPel1vrIIpMYFvwjaw9uKE=; b=p+OQ2v+YcioEcokyAgCshzm4pECxwb6pt4CPAYzQQt1lSg9/jSBGjtyBV72WgcYLjl l7yQIjHF8cR5+5mFmyNV/9T7JQsQrOsJ1PTr31Rt6kOenAZdq7jpj2RL47rT+fCnW8fn kMMO7j+EXVW6kIG3cRb+mriV89JgLfJKxCjj3ke9VC0XAcsf71VHDGm32oPgRGmLL+MN l2YI5QhKdK5i7jpk1C719fZbNtJnIZ2GVkhFZEaON3SZHdyc8ArmIMqn1HeyHfDfvXTl fTkUsLhIX3yBpD6ejV+bqnNYzGi80yWPWokRNMcS4JDUL35VQxKVHEmFbT6qRylksm8Y TIjA== X-Gm-Message-State: AOJu0YwHs/lkP5ZNsGX3/+bvo8kp8TfFe11vUkCsCnM+7NxwUas/MXEM L45ghYpy8Duv50y/8yu63FPTedEKEHsmjbvSL6hwhtUdR6Wj5K0ZcOtmeOar6w446DpIdLhTP2N iFxxMuadg/KdoTghJ64jOMXddbi9qQx8SpswSew== X-Received: by 2002:aa7:c0d1:0:b0:560:32f:4360 with SMTP id j17-20020aa7c0d1000000b00560032f4360mr4634382edp.33.1707146727621; Mon, 05 Feb 2024 07:25:27 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240205124513.447875-1-tudor.ambarus@linaro.org> <20240205124513.447875-3-tudor.ambarus@linaro.org> In-Reply-To: <20240205124513.447875-3-tudor.ambarus@linaro.org> From: Peter Griffin Date: Mon, 5 Feb 2024 15:25:14 +0000 Message-ID: Subject: Re: [PATCH v4 02/16] spi: s3c64xx: explicitly include To: Tudor Ambarus Cc: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com Content-Type: text/plain; charset="UTF-8" On Mon, 5 Feb 2024 at 12:45, Tudor Ambarus wrote: > > The driver uses GENMASK() but does not include . > > It is good practice to directly include all headers used, it avoids > implicit dependencies and spurious breakage if someone rearranges > headers and causes the implicit include to vanish. > > Include the missing header. > > Fixes: 1224e29572f6 ("spi: s3c64xx: Fix large transfers with DMA") > Signed-off-by: Tudor Ambarus > --- Reviewed-by: Peter Griffin