Received-SPF: pass (google.com: domain of linux-kernel+bounces-52912-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 5 Feb 2024 15:32:14 +0000
From: Mark Brown <broonie@kernel.org>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Liam Beguin <liambeguin@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Maksim Kiselev <bigunclemax@gmail.com>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Marius Cristea <marius.cristea@microchip.com>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	Okan Sahin <okan.sahin@analog.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ti-ads1298: Add driver
Message-ID: <ZcD/fnVVLdR2TFr1@finisterre.sirena.org.uk>
References: <ZcDo6QvoE_e5s_f1@smile.fi.intel.com>
 <7d7ea4e4-fcae-4966-b194-e1d328751b6b@topic.nl>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FV/jdPwiWoSPXR4m"
Content-Disposition: inline
In-Reply-To: <7d7ea4e4-fcae-4966-b194-e1d328751b6b@topic.nl>


--FV/jdPwiWoSPXR4m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 05, 2024 at 04:25:19PM +0100, Mike Looijmans wrote:
> On 05-02-2024 14:55, Andy Shevchenko wrote:

> > > > +	.cache_type = REGCACHE_RBTREE,

> > Why not MAPPLE TREE?

> Reading the description this driver isn't a good candidate - the map isn't
> sparse and the hardware can do bulk read/write (though the driver doesn't
> use it).

If your driver is a good candidate for rbtree it's a good candidate for
maple tree.  There are very few specialist cases where there's an
advantage to sticking with rbtree.  The maple cache has no meaningful
overhead compared to rbtree for non-sparse regmaps and will generate
bulk writes just fine.

--FV/jdPwiWoSPXR4m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXA/30ACgkQJNaLcl1U
h9ApSwf+OwSOaTAWvNTxBwn5cVSksk9dF5DFAZBL5mKj9G4dZWY4eJ5VbtBKncbX
WbsBVkA5dJRmRmwl5hgSBsw0KnnZ624s4JDOXfQ3Aic1Q1n7eFY5RbE02Ba+nk95
ob+9fsminr/iwZphEJFOO9Xb2B8LXWZAuJ66Y66UaIFm++9eD+tLDbjFOcsFu3Du
6ZAUt230YdQA8jTu+ZwFRtp3Qb1830MJTx7wsmGEmII/e7j22I5rW0YXkjS81MDj
LiNGSP5BcuwcIJE/NqYZbO2c3Mx6WKogIeu/7Lktb/Hbjjptne7wSLG10KbaY2By
mIPP+d/Frr5LsVbR6NLv8CtVMbok2Q==
=vGvm
-----END PGP SIGNATURE-----

--FV/jdPwiWoSPXR4m--