Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2474502rdb; Mon, 5 Feb 2024 07:40:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0DKtnaRyt6icCvG2Jv4ncUnbjQv9cva+uTu79m/r1c2L0GRX0jcVavkXylsz8/ukbXM79 X-Received: by 2002:a62:cd48:0:b0:6e0:520f:bb7c with SMTP id o69-20020a62cd48000000b006e0520fbb7cmr617163pfg.23.1707147658230; Mon, 05 Feb 2024 07:40:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707147658; cv=pass; d=google.com; s=arc-20160816; b=dHWw+PE0uKPtRRhl7ZGo7VClCJl/+gJ3mqru5hh+ac3j92thdaa3D/HX6fKrVSNFZP VHICXnO93N+pQFPxO30DmbMaK1zxqVyEOtgQg4lFPSIZNqcM7/gR9YkC4j7L+0gu+lc4 UVeAExiNSqaQz/Hyd8QAxby56EMaCggdN2azdRU/C3iKKZAoQxZtH+yDnKoni32a0dlH we8kfgWTL3glu9amflNiJP+q36lGmINOkhQmx15J72CB0O30pUY9YOhGKYIA6wXc0/U0 KH9jJH238rLVzRFmymHwHdL6jHvAMDunTAMmYgLUbGDVuYT/oQnBhdV8SuVzQZO1loWv 6KaQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5H8U2s8sxkPgAP0CEtiqkR+kDtyMBSLYUju/2rUteGc=; fh=VIRP8J21pw9shcr47znzjPmsMniVnmw4NETAhNedoAk=; b=UQ88l/26S+wFuA5Y52UKjT/M3zfUidXfH2sQx5L3SzBGD+O+XMZ3v7rKaE1CaNMmSV lJLaGSYVf2FUfFpHEZlHFjbhWli9fwf5Qt5g6II3uWsceQYZZwrRnNi6cKlWfKnxCJBV ImBk5IoqCUEJEmLNZDuS/iWbBR/gn2fVbR/XZ9+JyfBnLGC3hfQ+Mx4zgmPu5DIMPjy5 voE1rvKQGe0BLDROyym5bjlSM/40QOjvAalCsh1Kb57aSQn9feJU+IIOrvv8ikxl5iav HFZ3rrkLl4qPva3sFaFSw26eAnywWUQQWA+Bg4peB+6w1x2loXJqFNpcm91ALacbwo5P mJ1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UJu5utXo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-52880-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52880-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCXD+TC7H3y+BGtrCTEeG+rpU7KRUq9dCAFVQg/UNN6B5qrpUOZ/957JVHCf1gK04NNEWEIytLuSXdsOI3KmwlIuxjRtNZ7A/Vrix8QU/A== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id y26-20020aa793da000000b006d9a6f39e36si2762498pff.252.2024.02.05.07.40.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 07:40:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52880-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UJu5utXo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-52880-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52880-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2985BB27267 for ; Mon, 5 Feb 2024 15:12:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E3ABB2C860; Mon, 5 Feb 2024 15:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UJu5utXo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14CCA2C6B2; Mon, 5 Feb 2024 15:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707145935; cv=none; b=GF8n/iqAqtDq5nHpng92QVa1OxyTsw+y3OER3Mlty60NeQyleaYIxkBBa01QtRGm/T7DL/0toT9KrYQn9vlljnmgHdTWHqR/GQ00eDizWAmgPWfce4sS5Ji8yo/DMqkKpSBv/wYhWf26GCaFTNGLdV210Dz5t2Tjw3R66/VtyTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707145935; c=relaxed/simple; bh=5H8U2s8sxkPgAP0CEtiqkR+kDtyMBSLYUju/2rUteGc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FnZq4D14+UMXsIqghmy+AGaoKpwbLUrb5Eo8qiKrqCGGgkJpHLIXmPzE0aVYaLIHvF7Hq6weZ/+6SkFkJzPJ7kE2lBRbd6o8HHsyKpq9d/LMdCp8r4mw2QMv0iq8QEdxCMX4Z2Yx1PFr4hWxOpBe/HA6NYa3SnsRhNl3oaleyUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UJu5utXo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04E15C43390; Mon, 5 Feb 2024 15:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707145934; bh=5H8U2s8sxkPgAP0CEtiqkR+kDtyMBSLYUju/2rUteGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UJu5utXosnVRMOlcxFwUY7MZwzXvK31M33fxvYsmMhR7V9H5Pk7VuW2TpohuaVDNo 8XTwfhmnH6CSgzJFzlY6xgNTiGrV9ytpdlR3KhyVBikmjB8HDVGEPC8BCg5X8sbZ6i Js42Zcv+aWIfhIj/7sh5Y3CUtR4xYVQV3o+rQX93atZD+aWXbOhzJVyyG81cvtj2Yq ANG3QWgUit5pSuYDR5REHLChCAMQbc6AGdwLyCP+YhpUvbBlHzZ+OxNZRXkhofAGCk CelhVzehpbFp+qy1nzpwzMi3gFAWlGorDq7YdGxwALxOrbkMWQS5Jr1VAc8c4pJoet BP3dyGzq0ufeg== Date: Mon, 5 Feb 2024 15:12:10 +0000 From: Mark Brown To: =?iso-8859-1?Q?Th=E9o?= Lebrun Cc: Apurva Nandan , Dhruva Gole , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory CLEMENT , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH v2 2/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks Message-ID: References: <20240205-cdns-qspi-pm-fix-v2-0-2e7bbad49a46@bootlin.com> <20240205-cdns-qspi-pm-fix-v2-2-2e7bbad49a46@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+uhCJxiPCY2G8BG8" Content-Disposition: inline In-Reply-To: <20240205-cdns-qspi-pm-fix-v2-2-2e7bbad49a46@bootlin.com> X-Cookie: You might have mail. --+uhCJxiPCY2G8BG8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 05, 2024 at 03:57:30PM +0100, Th=E9o Lebrun wrote: > dev_get_drvdata() gets used to acquire the pointer to cqspi and the SPI > controller. Neither embed the other; this lead to memory corruption. >=20 > On a given platform (Mobileye EyeQ5) the memory corruption is hidden > inside cqspi->f_pdata. Also, this uninitialised memory is used as a > mutex (ctlr->bus_lock_mutex) by spi_controller_suspend(). Please place fixes at the start of serieses so that they don't end up with spurious dependencies on other changes and can more easily be applied as fixes. --+uhCJxiPCY2G8BG8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXA+skACgkQJNaLcl1U h9Br2Af+IML/4cSLO5Z+eiyFrEeWD5eTxDuA+9NYjzuwi7DYscVI3Rb0kbq+LwYE 0aSMKVOV66iXYqmEZ0+hWfonkZnD3WD7CqRJQ3Tp6yJKMc/GseDor4mqc5qv8mQG dlEws4QRZJL8608KYcFHtw3lsJIYXLNt/bDBEbDJQX3adxRz8SV+jjRqihXDO8A6 nxPDAKbDYbHhGu6Celc9dOxwFAa9g+86/pk7ARZNCPXleKnwDpQaF3gd3T5DSuge 7oUz3xQSiVBXkafd8uWmjbfYyckF5xEwWD09ckuQQ8K2ZrDYXn1lnYUlBQerc+Dv OZR70PQxyvWSso2Z2EH89yx+SbB1mg== =wk0H -----END PGP SIGNATURE----- --+uhCJxiPCY2G8BG8--