Received-SPF: pass (google.com: domain of linux-kernel+bounces-52939-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <d342be4b-e83b-47e0-8d45-9621900e15bf@oracle.com>
Date: Mon, 5 Feb 2024 15:41:21 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/6] fs: iomap: Atomic write support
To: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
Cc: hch@lst.de, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        p.raghav@samsung.com
References: <20240124142645.9334-1-john.g.garry@oracle.com>
 <20240124142645.9334-2-john.g.garry@oracle.com>
 <7ttdwk46hkj6ohdyq3ruwb2zkskzrpicz7dpf4g53v32nh7mgy@5g63yuoyotyi>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <7ttdwk46hkj6ohdyq3ruwb2zkskzrpicz7dpf4g53v32nh7mgy@5g63yuoyotyi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bnh3MlA3dVZGeGpaa1Qzem9aejBwMzRlZDBlY3JpS2xnU2M5VjlyNzRGc0hr?=
 =?utf-8?B?WGx3UzBUc3U1OFd0QXhPSVRzVUVBekcwY2dwOHBOdFlCME9KMFd2YzNTTGtl?=
 =?utf-8?B?Qm1paEFOMEhnbERORzU5S2drbGFOZHdjWDhqSUZ0cUlUdEFYKzN1cUE3aFNw?=
 =?utf-8?B?akpKVXlQV0pwL1BQV0xXcXVTdDZBa0hVaDJuYXg4aUg5c0RYa004K0RsdUFQ?=
 =?utf-8?B?MVNuUDY0N0dtcFJHeW1RV0ZPZlI4L0dRWW9vUGozNW5qS1lsNklORkRxQWpu?=
 =?utf-8?B?ZUZ1d3JEQXhMb2xIUkw0NEQyMEZKb09TWXpGVG9Ud1BhcjRoWXZSWDNTOEVs?=
 =?utf-8?B?bStOT0x6WlVaUjZ6d0IyelNuaWhnNWp4WDF1eFpZZHJjK3RFbUNIYTJxeEZt?=
 =?utf-8?B?ME9tUDdNeHQwai9DMFl1bWdHak5XTSt6SVl0OUhlbW1xK3dxS1VSazNTeGhH?=
 =?utf-8?B?eFd4WVJuVHpnS1ZhYklrZXRNL0VFSm8yZDVqaTBPNVpGdVBpOGpISFlMdHR5?=
 =?utf-8?B?TXkrOVg1NHBWSHVxaHY3NEFCNDNwZDlhTkRBNldiLy9ZLzRZd0x2NTZsa2VO?=
 =?utf-8?B?R3FpRTNidmtpYWh6UVVXdE03R1FHalJHM3NGdXErR1JsSmIybHdyYmxPYTFx?=
 =?utf-8?B?TVBiWitMUUJrOHBQT1QyRXBJSDFyaVFNWEZRdGhBWWZPTWtiTERqQjN1QUZZ?=
 =?utf-8?B?TEw1MVNtSGJkbk9iTStMYTRNMEVvenFFalZIcjFTbWtmVkJWbnhGSWJTSkQw?=
 =?utf-8?B?eHEzcmFsZ2pBN0hscTA4YUcwZUJEak55RkxvVTdnUjJqdzNGeWNjTENmVkkz?=
 =?utf-8?B?SmVDUDRUOVplOWM5bVFacFEwZjdaa3c1YXdKQVRqVWNHNkV4RDc5SDhIaENZ?=
 =?utf-8?B?RnBPY3M1RkJLNCtuZktDeVZCQWx2T1NqczdwYTRWNTB4YXVSS3NXdk5GcXFO?=
 =?utf-8?B?azVkVFUzTzVCRjRMbVo5L1BoVlNHYkpXamorVG5CTU5GMC9ZY0NYeFg4OXpD?=
 =?utf-8?B?THpJSEdPUVFqaDcxWFl4eW00YVJpYjNmQkVhZmNFc3ZwalpZSWRpNVhxWEd6?=
 =?utf-8?B?WHNpUHFKTy9kdDNoOStCR3lWU1ZiU2JIYW9KbktIYjJXM21FVTd1LzBmSVMr?=
 =?utf-8?B?RjZUWiswVmRkREhldlhTQUxoLzhPR0hFZlZpNXFzZ2ovOVZjbVZvOXBvU1hi?=
 =?utf-8?B?L3U3dmttQ2dIYjkvSlRiZldMejBBekNxYXR5cC9BQmhiYnRnV0Z4K25CTHBP?=
 =?utf-8?B?OWtrVlZNeHZZc2ZNOXRKSFJTUDJVTGtPa3Q3NzFXUG9Ob3BnWFVKMFV1Rmsr?=
 =?utf-8?B?dEdBTjdPQTdLQXdvR0M1YzlTQzlkTEtMQUlJdzJmNXdsdEZXWjNwZlVoNGhw?=
 =?utf-8?B?NFFTcjZGZmEvVmFGbnAySUppLytRRUNHUVdtOGxaOEpTNjZsY09ZUUNxL3ZT?=
 =?utf-8?B?cTBNdEM0Ky9LUmpUQldyTmV6USt4dFp1ZVRPTHNyNTF1UENmZ3kzVHhxY3Rv?=
 =?utf-8?B?dU81RU04dWlkZkpoZmxsaXF3NUxoUGk1ZUdBVEIzY2t6bHFaMzQzaGtOdXBn?=
 =?utf-8?B?NityeTlJTWtkeTI1TEFxZndMN09wVmJpbGNJZ0lKdkFiM1lOS0pnSVR0UlRa?=
 =?utf-8?B?Y1NTd1g3MnhyS1dUYWpWcEZ6VWV0a3Z2cDBPbDl1Qy9RbUpWajMwNVc5RHds?=
 =?utf-8?B?V1g1b2hXbm1qem5SK2gyVlk4Y3dGTnZIRlA3K1lyT3QrTVBtUlpnbXZ6TWxB?=
 =?utf-8?B?SXFBV1g4OUZ5YzVZdWg4N2ZHZGZ1cWd2b01qeGdoK0ljOTJKRTRvMzc3Y0tG?=
 =?utf-8?B?MWhWdkJuTmk2ZGJCSmkyK0cxbXlhOTkwOFVMSFlNUC9NSmY2NXJCbWRpRjVP?=
 =?utf-8?B?UnlUTWdxMTRoQ0tIQVErOHB2bGdRMjhSbGIzbkd3MHUweXJQYUtLQWI5VFU3?=
 =?utf-8?B?NXlPd1ROTnNhR3RjUk14T0lxWkNBL1daYkc4b3paWmlHQUFQUEhTWE5BZjNi?=
 =?utf-8?B?aHZqb1ZCanNkUU9KUW96V3RQRStIdjNXVVUrRUNxNHpScmVkK3labmpOMUJW?=
 =?utf-8?B?SUF2dFBiWE5WVUxQb2Y2Zk9raTR2NC9Fa0hOaWZ4OHhybFZMRGh5VU1RTUNE?=
 =?utf-8?Q?+Y7ooFf4bqg1oeUW6xi7st6JW?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	YI6NyD5igPc4wT1XMvGHyazc9EgsQcvSeMFh28bOLElam+kOlAnhF9B/RE6Mj0M7I1hZem1UyGGcwDfLTL3blH+d+G+mCKeFADGV+Rq2w6CBYXI8xAKcXBDU6EeLOqDyP52UYdoFlT3losYhiPGXO86O4M3+bJx68dzH9i7nZnTARnDDiYCA7pEbQoaOHsbWlwcwgPPLH4oRRbP5T+BuGdijY8CaLSaMX/Mq9F/1ajCLzJIvpoBoNMtOwvMaw6cccp26si12TcS2kEAla6JJra/l8OTbYvVp9qCIz1bLhyrkI9xra6aSXvZ3LeJYRPBsJ31L+K7JmBVuagdi4bgp3dydiWNLZHDPS84gN61/Z7C9mGHNOwyJW2vWL0Urf4vmtvfSxSHKdPM8K2w6PCqanYQW7/Uf2XAgAfXLa9zc5t9bQ03S4ylv2i6iUSLaeuf0JBfhrnp+23TneNKOd24cIN9CUhaw42Bu62h+PKumFUIiNxLt9y/6TN0CJx3k14buDBfGPI0Kjri8CbBeeyO3TAXsXcP4M51UdiAkxg1mQ/1SaKFM6SvHjj4sPtLlO03cfvyFMmoDOHYJMyt7BWZkPYF5XTbedFV8YqZptbiBQOA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71f2e574-dde7-4fbf-ffab-08dc2660e9d3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 15:41:26.4011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pi4SPKwT2/FWvQtD2r/caUr8i1rIl7jA9Afv7ZZMwgkXqQzb0Wxt447ArMuL2unxnYtHddAfRYDBT89OcwIZrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-05_10,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 phishscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402050118
X-Proofpoint-GUID: wb5-1K3VgxCaDBQEjr3s3Zndr3hK0SuY
X-Proofpoint-ORIG-GUID: wb5-1K3VgxCaDBQEjr3s3Zndr3hK0SuY

On 05/02/2024 15:20, Pankaj Raghav (Samsung) wrote:
> On Wed, Jan 24, 2024 at 02:26:40PM +0000, John Garry wrote:
>> Add flag IOMAP_ATOMIC_WRITE to indicate to the FS that an atomic write
>> bio is being created and all the rules there need to be followed.
>>
>> It is the task of the FS iomap iter callbacks to ensure that the mapping
>> created adheres to those rules, like size is power-of-2, is at a
>> naturally-aligned offset, etc. However, checking for a single iovec, i.e.
>> iter type is ubuf, is done in __iomap_dio_rw().
>>
>> A write should only produce a single bio, so error when it doesn't.
>>
>> Signed-off-by: John Garry <john.g.garry@oracle.com>
>> ---
>>   fs/iomap/direct-io.c  | 21 ++++++++++++++++++++-
>>   fs/iomap/trace.h      |  3 ++-
>>   include/linux/iomap.h |  1 +
>>   3 files changed, 23 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
>> index bcd3f8cf5ea4..25736d01b857 100644
>> --- a/fs/iomap/direct-io.c
>> +++ b/fs/iomap/direct-io.c
>> @@ -275,10 +275,12 @@ static inline blk_opf_t iomap_dio_bio_opflags(struct iomap_dio *dio,
>>   static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
>>   		struct iomap_dio *dio)
>>   {
>> +	bool atomic_write = iter->flags & IOMAP_ATOMIC;
> 
> Minor nit: the commit says IOMAP_ATOMIC_WRITE and you set the enum as
> IOMAP_ATOMIC in the code.

Thanks for spotting this

> 
> As the atomic semantics only apply to write, the commit could be just
> reworded to reflect the code?

Yes, so I was advised to change IOMAP_ATOMIC_WRITE  -> IOMAP_ATOMIC, as 
this flag is just a write modifier. I just didn't update the commit message.

Thanks,
John

> 
> <snip>
>> diff --git a/fs/iomap/trace.h b/fs/iomap/trace.h
>> index c16fd55f5595..c95576420bca 100644
>> --- a/fs/iomap/trace.h
>> +++ b/fs/iomap/trace.h
>> @@ -98,7 +98,8 @@ DEFINE_RANGE_EVENT(iomap_dio_rw_queued);
>>   	{ IOMAP_REPORT,		"REPORT" }, \
>>   	{ IOMAP_FAULT,		"FAULT" }, \
>>   	{ IOMAP_DIRECT,		"DIRECT" }, \
>> -	{ IOMAP_NOWAIT,		"NOWAIT" }
>> +	{ IOMAP_NOWAIT,		"NOWAIT" }, \
>> +	{ IOMAP_ATOMIC,		"ATOMIC" }
>>