Received-SPF: pass (google.com: domain of linux-kernel+bounces-52986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Anna-Maria Behnsen <anna-maria@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
 John Stultz <jstultz@google.com>, Thomas Gleixner <tglx@linutronix.de>,
 Eric Dumazet <edumazet@google.com>, "Rafael J . Wysocki"
 <rafael.j.wysocki@intel.com>, Arjan van de Ven <arjan@infradead.org>,
 "Paul E . McKenney" <paulmck@kernel.org>, Rik van Riel <riel@surriel.com>,
 Steven Rostedt <rostedt@goodmis.org>, Sebastian Siewior
 <bigeasy@linutronix.de>, Giovanni Gherdovich <ggherdovich@suse.cz>, Lukasz
 Luba <lukasz.luba@arm.com>, "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
 Srinivas Pandruvada <srinivas.pandruvada@intel.com>, K Prateek Nayak
 <kprateek.nayak@amd.com>
Subject: Re: [PATCH v10 18/20] timers: Implement the hierarchical pull model
In-Reply-To: <ZbvHvKdpgqfsJp0E@localhost.localdomain>
Date: Mon, 05 Feb 2024 16:59:45 +0100
Message-ID: <871q9qucjy.fsf@somnus>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Frederic Weisbecker <frederic@kernel.org> writes:

> Le Mon, Jan 15, 2024 at 03:37:41PM +0100, Anna-Maria Behnsen a =C3=A9crit=
 :
>> +static bool tmigr_handle_remote_up(struct tmigr_group *group,
>> +				   struct tmigr_group *child,
>> +				   void *ptr)
>> +{
>> +	struct tmigr_remote_data *data =3D ptr;
>> +	u64 now, next =3D KTIME_MAX;
>> +	struct tmigr_event *evt;
>> +	unsigned long jif;
>> +	u8 childmask;
>> +
>> +	jif =3D data->basej;
>> +	now =3D data->now;
>> +
>> +	childmask =3D data->childmask;
>> +
>> +again:
>> +	/*
>> +	 * Handle the group only if @childmask is the migrator or if the
>> +	 * group has no migrator. Otherwise the group is active and is
>> +	 * handled by its own migrator.
>> +	 */
>> +	if (!tmigr_check_migrator(group, childmask))
>> +		return true;
>> +
>> +	raw_spin_lock_irq(&group->lock);
>> +
>> +	evt =3D tmigr_next_expired_groupevt(group, now);
>> +
>> +	if (evt) {
>> +		unsigned int remote_cpu =3D evt->cpu;
>> +
>> +		raw_spin_unlock_irq(&group->lock);
>> +
>> +		next =3D tmigr_handle_remote_cpu(remote_cpu, now, jif);
>> +
>> +		/* check if there is another event, that needs to be handled */
>> +		goto again;
>> +	} else {
>> +		raw_spin_unlock_irq(&group->lock);
>> +	}
>> +
>> +	/*
>> +	 * Update of childmask for the next level and keep track of the expiry
>> +	 * of the first event that needs to be handled
>> +	 */
>> +	data->childmask =3D group->childmask;
>> +	data->firstexp =3D next;
>
> So assume we have:
>
>             [GRP1:0]
>         migrator =3D [GRP0:0]
>         active   =3D [GRP0:0]
>         nextevt  =3D TIMER3
>         /                    \
>     [GRP0:0]                  [GRP0:1]
>  migrator =3D CPU0           migrator =3D NONE
>  active   =3D CPU0           active   =3D NONE
>  nextevt  =3D KTIME_MAX      nextevt  =3D TIMER3
>     /         \                /         \
>    0           1              2           3
>   idle       idle           idle         idle (TIMER3)
>
> Then CPU 0 goes idle:
>
>             [GRP1:0]
>         migrator =3D NONE
>         active   =3D NONE
>         nextevt  =3D TIMER3
>         /                    \
>     [GRP0:0]                  [GRP0:1]
>  migrator =3D NONE           migrator =3D NONE
>  active   =3D NONE           active   =3D NONE
>  nextevt  =3D KTIME_MAX      nextevt  =3D TIMER3
>     /         \                /         \
>    0           1              2           3
>   idle       idle           idle         idle (TIMER3)
>
> CPU 0 is the idle migrator and its tmc->wakeup is TIMER3.
> But CPU 0 has a local timer that expires before TIMER3.
>
> When that timer interrupt fires, it raises the softirq, which
> executes on IRQ tail. So CPU0 eventually calls tmigr_handle_remote()
> before TIMER3 has expired.
>
> This leads to tmigr_next_expired_groupevt() to return NULL and then
> data->firstexp =3D KTIME_MAX and then tmc->wakeup =3D KTIME_MAX.
>
> Later on, tmigr_new_timer() is called with a KTIME_MAX global
> event and so tmc->wakeup stays with KTIME_MAX, ignoring TIMER3.
>
> It looks like you need to handle the tmigr_next_expired_groupevt()
> case returning NULL.

Yes. You are right. group->next_expiry is updated via
tmigr_next_expired_groupevt(). So I should take this value to rely on
for the firstevt.

But with this, we do not need the return value of
tmigr_handle_remote_cpu(). When the upperst level is inactive and there
is a timer (e.g. propagated there by tmigr_handle_remote_cpu()), the
return value of tmigr_handle_remote_cpu() is the next_expiry of the top
level group. But this value is also noticed by walking the hierarchy up
to the top level with tmigr_handle_remote_up().

Thanks,

	Anna-Maria