Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2488678rdb; Mon, 5 Feb 2024 08:04:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEAQRlTAcVJv8j/va/3SQXmlFkFlJ9gKD3u1wzTPA+4UIOt5QotXo9UbHOB9+vn5Fu1m4i X-Received: by 2002:a17:906:258f:b0:a32:b376:489d with SMTP id m15-20020a170906258f00b00a32b376489dmr7122296ejb.21.1707149092726; Mon, 05 Feb 2024 08:04:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707149092; cv=pass; d=google.com; s=arc-20160816; b=pSAdjDuVoIW+xYNHeXoYB5REnC6t1Ohot56LIZbJOQnETBL+PYjaW+hZBPNw+B7a+v q1QtSqSQqBzGDcdERged2mqF+hYYyLQvTBAKrIdUz0KBTWeA04xCKqRqN1UiY1jahdtt 4NC14MgCWK6MAmoTi4ida5Vc0ksNTQom43sfdYvBK/hF5lqD7drJ6+EKmw6CqQuyL7E5 WceBwvhSj/E/jYuAJhlM+rh1Sl0L+L2xhBeKKHGe/s1nsXX7UDDVY/XuREgwVp4OV5zX vZ5hnGr6FM2gTnSmggo9sV9irUVJR7TPUizU0t9NRlw55BIQULRbg34mO+vhiHgvwddG Uvzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :reply-to:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=pWfJS+gwVj+PUGX+6rqFWBY+Qy089fOxJXy1xT8gFLI=; fh=3wQnFDodPDMLwdd3JwRPbce+7rAdRlED2AiAczSSIzE=; b=XxYeeQltacPa9KFp5RpvKUF2LFYfFrrZLOaFQRl1FlmSCZ3gzJOVDzSJ9Ug7QlrGNJ dCRuPVp3Aplzk6VVQuHm9tFNMxosd8Nsud80CMk6Sh97ozXS+3Yfa2ESBqaxsI8JgEtF ry/lkKEo1fYKTVIthQFVNGJU/yOAzeKgXQZFDDMCotGa/sR/Z8fQRFX+jJi/MO+GvZWh WXjiB94r8QPW3nwWQ5sjQv0pSlOeY9eo+gdLJybmPsdzZ/ASybuMPOTOqtDhGUi5r7gW hHgXi4Tc8XLxSlVA7KX+vlooXqzXkCw9aj47SoRDo0Iv8GQcbXHJVJCG5z0wyPKIWKuR uvUw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=LxHABtr1; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=LxHABtr1; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-52990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52990-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCXixW7GNWrHMujCEU8D5PNWnePWX9CqXqQd2qbGYjyXr8H9bDJu87eC6DS71WY/ct6wYmGzbbg45SefaquEzK0LwLmW32LyvbDu5QyMOQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t11-20020a17090616cb00b00a37c9e1a5f3si908480ejd.186.2024.02.05.08.04.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 08:04:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-52990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=LxHABtr1; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=LxHABtr1; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-52990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-52990-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7B5091F23754 for ; Mon, 5 Feb 2024 16:04:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7CF6533CF9; Mon, 5 Feb 2024 16:04:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="LxHABtr1"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="XlrvhEnM"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="LxHABtr1"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="XlrvhEnM" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2DA52DF87; Mon, 5 Feb 2024 16:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707149081; cv=none; b=HTcVZVzpDAwmSQmINzcwPohAOHlQW/X+Iux6HboKfPasQi0RBD93nTrhpgJ05shxC9aVDdE9bJIsgAE5KhIhc3pe8kIyCkms3lEWIFug5+lPrhZkmAzSWRVs7gI29/YmW708dMyeD036UDYjnTxmrxK2PV3zfRyR0eI6AT1Mn/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707149081; c=relaxed/simple; bh=LY1woPs2w7IdncE7cHCuLOftAXsdnvsS/3dBDGoJ5Lo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sgQlCu7u3FXQ583xFMktaNHmKLQS4Buol5zUTEPDUdkSJxBJhf+53GXhwlnMpsA/sdfIANdBsM8m8CW76jQRHeFeq+LfOcMNStSwgw9WalOi6RIL8T6RxL2mfmebsKGI3KrfaU8V0BAlv733BB6/RdWvrYWVrLpPLPOnKsx1t34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=LxHABtr1; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=XlrvhEnM; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=LxHABtr1; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=XlrvhEnM; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7FEC622167; Mon, 5 Feb 2024 16:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707149077; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pWfJS+gwVj+PUGX+6rqFWBY+Qy089fOxJXy1xT8gFLI=; b=LxHABtr1VV4i598J0WC8E8T+bX8nRiCa64d7hrWW3cEyAyvaDHkJ3n9P+IsWu6sOEnuGzw n+KSPridy1JuAk4e8Jv0PD7ydOcEV4iVFkKumFhkTpdxhUUo6U2MckvqGAW8yyVA5jmVSA nlr7ZdozrEFWOL2pMbHDwxSopcX5VXc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707149077; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pWfJS+gwVj+PUGX+6rqFWBY+Qy089fOxJXy1xT8gFLI=; b=XlrvhEnMEdD0jy3dA/L4oZOe0uEy8+FFC0bZPmzlEUGSCa3aMitP1D7lRqCDYaGFj00XnA pj4FvNVweZ4z/4CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707149077; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pWfJS+gwVj+PUGX+6rqFWBY+Qy089fOxJXy1xT8gFLI=; b=LxHABtr1VV4i598J0WC8E8T+bX8nRiCa64d7hrWW3cEyAyvaDHkJ3n9P+IsWu6sOEnuGzw n+KSPridy1JuAk4e8Jv0PD7ydOcEV4iVFkKumFhkTpdxhUUo6U2MckvqGAW8yyVA5jmVSA nlr7ZdozrEFWOL2pMbHDwxSopcX5VXc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707149077; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pWfJS+gwVj+PUGX+6rqFWBY+Qy089fOxJXy1xT8gFLI=; b=XlrvhEnMEdD0jy3dA/L4oZOe0uEy8+FFC0bZPmzlEUGSCa3aMitP1D7lRqCDYaGFj00XnA pj4FvNVweZ4z/4CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 65130136F5; Mon, 5 Feb 2024 16:04:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dUKDGBUHwWXLCgAAD6G6ig (envelope-from ); Mon, 05 Feb 2024 16:04:37 +0000 Date: Mon, 5 Feb 2024 17:04:08 +0100 From: David Sterba To: Kunwu Chan Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, Johannes.Thumshirn@wdc.com, dsterba@suse.cz, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] btrfs: Simplify the allocation of slab caches in btrfs_delayed_inode_init Message-ID: <20240205160408.GI355@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20240201084406.202446-1-chentao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201084406.202446-1-chentao@kylinos.cn> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LxHABtr1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XlrvhEnM X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-1.23 / 50.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.02)[52.20%] X-Spam-Score: -1.23 X-Rspamd-Queue-Id: 7FEC622167 X-Spam-Flag: NO On Thu, Feb 01, 2024 at 04:44:06PM +0800, Kunwu Chan wrote: > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create > to simplify the creation of SLAB caches. > Make the code cleaner and more readable. > > Signed-off-by: Kunwu Chan > --- > Changes in v2: > - Update commit msg only, no functional changes Please convert all kmem_cache_create calls where the KMEM_CACHE macro is suitable, ie the cache name and the structure name match.