Received-SPF: pass (google.com: domain of linux-kernel+bounces-53008-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <42fd6e46-30c0-439c-b58c-00d8a201560c@amd.com>
Date: Mon, 5 Feb 2024 10:28:14 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 6/6] cpufreq: amd-pstate: remove legacy set_boost
 callback for passive mode
Content-Language: en-US
To: Oleksandr Natalenko <oleksandr@natalenko.name>,
 rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 gautham.shenoy@amd.com, Borislav.Petkov@amd.com,
 Perry Yuan <perry.yuan@amd.com>
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1707047943.git.perry.yuan@amd.com>
 <e0746643c781f638c9e9cb8a6d2ceebeeb906f95.1707047943.git.perry.yuan@amd.com>
 <4896392.31r3eYUQgx@natalenko.name>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <4896392.31r3eYUQgx@natalenko.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M2JBb1pkQVM2QTgyeHpmdkJJUmNWUFBPK3hEMFVWOUhUbzA2SmZPL1hpZXpi?=
 =?utf-8?B?b1NITVVWbmZPU29ZV0lzdTlKMFJhWHpoZmIzU1IxM05MOHFVVFEyRWI4dy8v?=
 =?utf-8?B?cThyclk0czhxaS8rcFVQanBEam1kbkc5dmptN20zOHRTS1UrOVh5UnQxcEND?=
 =?utf-8?B?RUdWSEpQS3M2aXVzUTYwNTRUSWlGc1NjM3d0NURCU3FDZHgzcFZDTHNLdHpJ?=
 =?utf-8?B?QUtzbHVEWmFXRmF6QUJmQ1FSTHJNajlBRlgzb3V5RlBPdGFTa05ySFNQNUNL?=
 =?utf-8?B?d3J3dFJRUzJvY2VUMnhqeHJiMmFkZC9Dd1V0UVBuM3MwMU1oRjkwaFRKaTNZ?=
 =?utf-8?B?OGo0NHZicXV5WnBLK1BBOU5SOGhJdHIvMzR2b2dLVUt6Ty9pcDlsL04xdjV3?=
 =?utf-8?B?TW96NU05SlczY1VIVk0vdXIvNGpjVThXUTdEL2NYOXJkQ2lDclRpbyt1S2NY?=
 =?utf-8?B?Q3BydjJVOHdpdDZpZjhxQzJoa0Z2bHZ5RjdZQ0ZsQXBHSmw2YWlXMFplWFdp?=
 =?utf-8?B?eWw0amYyS1VWK0drWG1GMmpsemNPdHcyYXZxU0xzaFlXQ2RQQVNlVkE4aytI?=
 =?utf-8?B?ekFneFNaVXcrUHdtTE0zWis3dmZYM2RmbFJJUUNHUDBhV3hrNkhWTXBJQ3Rt?=
 =?utf-8?B?RVd2N3J6NlhTQ0ZINy9EalBpV1dEQ0sxYXFBN3pjYUd6R2FIMWhnVzV1WGRy?=
 =?utf-8?B?d2NkZ2VDa0xaWmdYaHFMK0NaNnVQRkI1OVFOSlIwZGxkaTlFT01uKzNwYm9L?=
 =?utf-8?B?V2xNbk5iQnIxbE5aU2ZrNU5Xc1lIWDVJVGc1azNiUWw4N2g4OW9RYS9aczFk?=
 =?utf-8?B?QWVaWjE5TnIzTzc2ZUhlKzdOYVlIZFBiUlpPUlMyQVlvZVMybi9KdlcydVow?=
 =?utf-8?B?MXV0UnpvYWN2cGFvQkZNMjBoS241a3Iwc3BmTW1UTHJJOWxVSzc3RjB2bG9I?=
 =?utf-8?B?Ny82amhEOTg3NEtiUU9iekhqRUdJNnV5UWtES2I0UVkwditndkM3di9XdVly?=
 =?utf-8?B?bTNzbHMwS3R5NnowdExlbjlpenlQS1h3RWl4TGdOZXVpS1RRZGNJai81eDVK?=
 =?utf-8?B?cDNsSGErVnpIT3dBZFpCWlVwKzJnNVRiTnM5bXJkQ3lUU2NMczRPTUtoNE1y?=
 =?utf-8?B?TXdOZWJjUS8rZ3RwSC9xTU9vRHRTRWwvclo1M2dJRGRkN25sMlhzMnZxSGdO?=
 =?utf-8?B?SFlmV1hBS2tST0lLQkhKZWRZMUNPS3cvNnF1VXVWS2EwZVd0T1RaWHVoeXJL?=
 =?utf-8?B?RlJJL3J3R0VoZHdQRWx6M09RbVhoRGdLN0gvK01rYU9JeW1vK2R2UkpnaXdn?=
 =?utf-8?B?QnJSaDJ2TjhyVHdwczRNR25ydnFxVmRsVWp2MHQydE9hbmxpTGVZSlJyd1hG?=
 =?utf-8?B?ZjROeVdJbXVVa3RwRGkrSEMrWFF0N0Jka2k5NVRtcDlrdHp0RFMyWGJJOWZO?=
 =?utf-8?B?QWpraVV2dWJyektvZXRsVjFXVkhTMU5kc0JiallvZjFKV1hhM09xd1o4TXFP?=
 =?utf-8?B?N0lQRW5CYTJoMmJIVkJHdEZidWtsaFRBbGhRaXZ4MFdPR1p4WWY0Q09tMW4y?=
 =?utf-8?B?cytrUlJCdmpveXBkellPbGJscnZwREozdmhRaFIvMTNQRU9iWHpmeThlVlY3?=
 =?utf-8?B?SjhUNWpoVzVqbkR3a1pMTG9TWmNkU2xTQ25GYktwalpQd2ExRDhZbHdRQTg4?=
 =?utf-8?B?aTAyUnkzU2N6ZnhHemhGZUszNGZBdU0yTlp0cFNqZlczWWtJbUV4enhWdzFm?=
 =?utf-8?B?SU00dHRRQUJEM2hMdXBPZ2laWVIvWldaVWkxR3dYVmFPc0RkN0pjaG9Yem1S?=
 =?utf-8?B?bnR3Q29VREhBSUlxdGE3YXRBTk1PdVVjN0tENFBiMUh4Y2JiYjFzaE5OS0NS?=
 =?utf-8?B?VjhzWFdvQWRBTWNGRHZDZ051KzNjM0YzTUdpemNSbWpNMFk2ZkwxbnE2Uzlj?=
 =?utf-8?B?eHVzRW1TSmYxSnV0bXQxWUNrLzROdW4wcERrNkl3cmhieWI5MTFyOG55WTho?=
 =?utf-8?B?ZkkyaTQrWnhqbVZwUm1BSlF2dUk2WFpvcGZsd29OSHY3MFpFNUtPbFhlY3pq?=
 =?utf-8?B?V0hOZTZFenNiVG50azdSa0tTb0hXUmJVRlRWTWR6NjVOVjdWSTNlZEZEUHQr?=
 =?utf-8?Q?FoTheHl+cIECTQ4JZiY4PRxfd?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1dc0d64b-195e-4b04-a8a1-08dc26677496
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 16:28:16.0865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A4SZcN2ZrF2uqRGpNZEW8EUGjWqSi6arYS9jsEfPuYWYiDbWnPTzxsTCgjR1+aTscltiNVhf/TNpeeXzxoEJ5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8998

On 2/4/2024 08:57, Oleksandr Natalenko wrote:
> Hello.
> 
> On neděle 4. února 2024 13:12:57 CET Perry Yuan wrote:
>> With new freqency boost interface supported, legacy boost control
>> doesn't make sense any more which only support passive mode.
>> so it can remove the legacy set_boost interface from amd-pstate driver
>> in case of there is conflict with new boost control logic.
>>
>> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
>> ---
>>   drivers/cpufreq/amd-pstate.c | 1 -
>>   include/linux/amd-pstate.h   | 1 -
>>   2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
>> index 02a76b8fb298..4e377efdd4ed 100644
>> --- a/drivers/cpufreq/amd-pstate.c
>> +++ b/drivers/cpufreq/amd-pstate.c
>> @@ -1492,7 +1492,6 @@ static struct cpufreq_driver amd_pstate_driver = {
>>   	.exit		= amd_pstate_cpu_exit,
>>   	.suspend	= amd_pstate_cpu_suspend,
>>   	.resume		= amd_pstate_cpu_resume,
>> -	.set_boost	= amd_pstate_set_boost,
>>   	.name		= "amd-pstate",
>>   	.attr		= amd_pstate_attr,
>>   };
>> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
>> index 446394f84606..66d939a344b1 100644
>> --- a/include/linux/amd-pstate.h
>> +++ b/include/linux/amd-pstate.h
>> @@ -80,7 +80,6 @@ struct amd_cpudata {
>>   	struct amd_aperf_mperf prev;
>>   
>>   	u64	freq;
>> -	bool	boost_supported;
> 
> This leaves amd_pstate_ut_check_freq() in drivers/cpufreq/amd-pstate-ut.c broken. Likely, the whole `if (cpudata->boost_supported) {` hunk should be removed there too.
> 
> Also, in the header file, there's kernel-doc before `struct amd_cpudata`, where boost_supported is mentioned. It should be removed too then.

Yeah; I though the kernel robot caught this on v1 too.  Make sure you 
run the unit tests at *each* patch so that this code remains bisectable.

> 
>>   
>>   	/* EPP feature related attributes*/
>>   	s16	epp_policy;
>>
> 
>