Received-SPF: pass (google.com: domain of linux-kernel+bounces-53012-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <de66890b-a42c-4d8b-8079-fcfff0007aeb@amd.com>
Date: Mon, 5 Feb 2024 10:31:47 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iommu/amd: Mark interrupt as managed
Content-Language: en-US
To: joro@8bytes.org, suravee.suthikulpanit@amd.com, Vasant.Hegde@amd.com
Cc: will@kernel.org, robin.murphy@arm.com, iommu@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <20240122233400.1802-1-mario.limonciello@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240122233400.1802-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZjU4QUpjSUl0VXc4RmQ2VU83c3pnK0s1STNzNXZDV29qMFdFVmJMY0JyTEt1?=
 =?utf-8?B?UUJMeUVSN3NWTWxJSkE5OGV2cit0c3g3RXdQMmRZeXFpcjkrMmZRMTlCUDNs?=
 =?utf-8?B?S2ZWOHFpYmZsVmtOZDZWeWc4SzVDWVBYV20xblN2a0dBYnJTZDNnOVFaQXRv?=
 =?utf-8?B?N0IzejZsdk4ya1hmVUd2dkg1cllVak1BT1ZSdzFnN0FKTURuWHpnYm5lTFFt?=
 =?utf-8?B?NE1sc1MyeU9WU1lIVDBBN1dHaVZpWEwyclNodzJnbFJhdytSWWVPUUFIVXhM?=
 =?utf-8?B?cVhEbzRYYlhHS3lQNTAwZU9HZzRVbTlFMDlNMzNyQUhFeExXKzBoY0crNUJ3?=
 =?utf-8?B?cElMSUZTM1NueGpoZm10VW1xaU13MXNLR0dtMjN5YzZITXQ0STMzdlR6TFZG?=
 =?utf-8?B?eFpWaTM1cnpoalpyejE5UytqSGtvdGRBS3Nia0VhcmhyUWxpcDBGZGFKdFNv?=
 =?utf-8?B?VDJvbTJ1aUVza29SNys2S1pReXp6R1kxVnRLM0pOemQ3RjJGcWZjVkxXeExj?=
 =?utf-8?B?cHM0R1Z5NSswMUhjL1lQckg4bzV2RmZBcTlFb3dETUYvejN1RFNGakRyU3dM?=
 =?utf-8?B?ZyttNnN6OE53dWRxSjJCT3k1dVJLeXhSbzVZSm9xWnV0Tkg4allQTkRjZlhW?=
 =?utf-8?B?T3ZoZnpLU25xTTlvcGRhT3lCcW9GNVU1OVV3OCtVZy9JLzhkd1JvcVhydkF3?=
 =?utf-8?B?TUVvWkpqbUdWZTQrUFFqSUJGU3hsQTNEWnBsRG5BRklmU052Q0Q3TFFQbEo1?=
 =?utf-8?B?SDFldDF1d3Y4enZEd3VpSW9ldkdFSkNTcE1pd0tKelNDeE1BUHNoK3RiZ3M0?=
 =?utf-8?B?U0ZiTGtjRWhoUG1mTmRjTmlkanNKVDZjWGJyL3VUTWlFR0pDeFJ1bE5KcHJ5?=
 =?utf-8?B?US9Bd0RBMlpOSUFDUmRacFhXSm0xN2d1d3JiYWNJbktHemZKWG83a0JCbm9G?=
 =?utf-8?B?OUZnUFFjbnBNdzlFUkd6VXhrK0lJdWRrSS9BTSt4Y1VnMnAvb1R6NDdqV3I1?=
 =?utf-8?B?L3dRek9pUitwbFo0RFNXa0toREF0YUVOMHhKcVBzVGNVclhiQ3drNG10bjht?=
 =?utf-8?B?ang5aWd4RDJKSDl5dUJlN1VMeGcyNFNzbW5QT0NkUGhiczZjeHNpQklFalpq?=
 =?utf-8?B?L1N6d3F4ZGkzZjFpS3BBdU9MT0NWNUNidWZieGpBWnVSS1JuUjNqVmpIc1dZ?=
 =?utf-8?B?WlZXWnJSUGpyZUxKVEpFTTdVYXFOOEFOdjNyK0lhQUNReVlONXNpTGY4Rlc0?=
 =?utf-8?B?SUhsWGo2ME01bFhKaHpJdEJBVVVMZUN6WnN3SE1MS29FV0cvWHdEMWpjalli?=
 =?utf-8?B?OFIzWFA1aUlpQ2NGOE5kV0s2THZuVjN1Rnhnc1R0TGJUYjJ5blBUYVRWQSt2?=
 =?utf-8?B?UHpvY051UWJ4aFVKdXdxaEd2NlNNbDV4RWpVdktCU1hYb1FEbnA3MmJ2UUZF?=
 =?utf-8?B?cmxVVFRJSGJMSkRqb1FMUGlFdXN4M0lGY0tmMVVTSnh4ZkJXbTBYdEsrUjF1?=
 =?utf-8?B?THBRZEwxbER3YU1iVm0zZktyVUhSWU5yWisvQncxekhoakhpcS9Ob1pjMnN5?=
 =?utf-8?B?ZVUyRUZ1OTlvZy80M0Q3K1QvdWllWnNrejNMWjlSVzVKamhzdG55dUQveVpO?=
 =?utf-8?B?V1hIZVVwRnpaRHNUdmFxUmo3elJEMEdsajdsMXhnMHRwSGlQa1FETHdyQ1Q1?=
 =?utf-8?B?OFVhK3M0b09hQTQza2ZEZWRNRHZPUzRJWjBEOGZlRFhmdTdGa2tBSEZUeGZC?=
 =?utf-8?B?ck5tcmhxTnFRVzNWcmUyM2tBL1hjcmFTMTc0cC9Od05SVEVlVkZiMWNqRFpB?=
 =?utf-8?B?cnZFVFJ4M0RJWHlTMVVCeHdab09qdURscjlTWnVRU1BzL2RLaVBKdWxUblpC?=
 =?utf-8?B?U3d6VGNRUzFLT3dqZnJJVzViK2NobUs0TDlkbFZUalBKUGpSR3V0dTdZOVk5?=
 =?utf-8?B?SWhBUytlY3c3Q05RNFJwYXRUdmNQcHh6MFp5eHZsanpJZWl4YWNtNklUM1Rr?=
 =?utf-8?B?dlAzdzl3VkZiU3FyRk9QL0h1MTN1WnVESmF2QTdueHZOR0NLVTlkdk8xdFpU?=
 =?utf-8?B?elVKd0JXTWZaa0J6Wm9zS1NWcGNnUm9zL2dPT3ZrSEd5cGk3TGRwR2ZxajQw?=
 =?utf-8?Q?OlLIjaymKEXJl97oh0dYaYG6p?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df7b734e-bca4-4811-2f1d-08dc2667f3f6
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 16:31:49.7784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YFpKz1OvnsDtcgfd4cfg9PEPE13lm72STdyiCIcV7ZL5YaH1J4V59pjUk916sVbvn7qTSLC3K9sU5mextXRJbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4559

On 1/22/2024 17:34, Mario Limonciello wrote:
> On many systems that have an AMD IOMMU the following sequence of
> warnings is observed during bootup.
> 
> ```
> pci 0000:00:00.2  can't derive routing for PCI INT A
> pci 0000:00:00.2: PCI INT A: not connected
> ```
> 
> This series of events happens because of the IOMMU initialization
> sequence order and the lack of _PRT entries for the IOMMU.
> 
> During initialization the IOMMU driver first enables the PCI device
> using pci_enable_device().  This will call acpi_pci_irq_enable()
> which will check if the interrupt is declared in a PCI routing table
> (_PRT) entry. According to the PCI spec [1] these routing entries
> are only required under PCI root bridges:
> 	The _PRT object is required under all PCI root bridges
> 
> The IOMMU is directly connected to the root complex, so there is no
> parent bridge to look for a _PRT entry. The first warning is emitted
> since no entry could be found in the hierarchy. The second warning is
> then emitted because the interrupt hasn't yet been configured to any
> value.  The pin was configured in pci_read_irq() but the byte in
> PCI_INTERRUPT_LINE return 0xff which means "Unknown".
> 
> After that sequence of events pci_enable_msi() is called and this
> will allocate an interrupt.
> 
> That is both of these warnings are totally harmless because the IOMMU
> uses MSI for interrupts.  To avoid even trying to probe for a _PRT
> entry mark the IOMMU as IRQ managed. This avoids both warnings.
> 
> Link: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/06_Device_Configuration/Device_Configuration.html?highlight=_prt#prt-pci-routing-table [1]
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Hi,

Friendly ping on reviewing this patch.

Thanks,

> ---
>   drivers/iommu/amd/init.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index c83bd0c2a1c9..40979b0f5250 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -2068,6 +2068,9 @@ static int __init iommu_init_pci(struct amd_iommu *iommu)
>   	/* Prevent binding other PCI device drivers to IOMMU devices */
>   	iommu->dev->match_driver = false;
>   
> +	/* ACPI _PRT won't have an IRQ for IOMMU */
> +	iommu->dev->irq_managed = 1;
> +
>   	pci_read_config_dword(iommu->dev, cap_ptr + MMIO_CAP_HDR_OFFSET,
>   			      &iommu->cap);
>   
> 
> base-commit: 75f74f85a42eb294b657f847c33e1bb7921dbec9