Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2519863rdb; Mon, 5 Feb 2024 09:00:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeT3S0amNsdSeB+7ihQpd7oapzLgPMqextvXMiUGbEgveTAU6x8TsoNMiBdL58Say4mEPT X-Received: by 2002:a05:6a21:183:b0:19e:5e6c:9d61 with SMTP id le3-20020a056a21018300b0019e5e6c9d61mr84983pzb.28.1707152408379; Mon, 05 Feb 2024 09:00:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707152408; cv=pass; d=google.com; s=arc-20160816; b=vseUogxzhI6afoNdtfa3pdWvyO+I7+pgYkXcdUFbRlXUFC4zrHx5D3ORhqvJMoW91P cNUQLA+SV1dDMwAJ52FATNxD6JooDrT25WDWUZsrdWM7Yyc8J6vRvNBh32QXuBCwkr6P gFK4HKmMpD5LlOE74H0ED3d0r7cEt/lEZSKDovk+M/YITN0JZtHPbEa8onRgnVJswaB2 UIyKzIA6zyiK7KFs2YkRx2OamHPMcu6JSTnfW+d6xv97NTdprrxKY01qgLNFyFF7g9dI V16NKES4hNDeuwh4HPXqcrie7mkS31fCkKF9rlsiJ/DG8QVogDZTQCIBOuN/HRv7viWC WBGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=biDMumhciKwt9Q9TwZc1phg2WKM9P0dO60zqX1cTX6o=; fh=j7Llb32gAZaRgUvUtDLe96Atwq+GBUKAE84vwfLjgRk=; b=fJVAZv/3FHBgTjEuOHw4FzWvVCpfhI3jpHCwGe8BuD32J3RKolE8YXr9WMRmFCvo0e XFcUe1Cw5cWB2a7xWhoVdUbxrs0ngRolbs5NDs/kw0eDDnonjhuj1aGagpEnf87ab5lT Tbjksoj8nsnozfvbN2i5QacivUSwXgOnK7eS64JyN5Plxq4YomnG8rHqcbJr7yb/Nnqn SDu5T9aQR4iru6KPwAOINlYrXxICs3DkDyxElLBXCKnkE86SV72OQn6v2xUD7V7pZgxB YqvfSQ3Ir02GPVYGMV+x821hF0rKdE9/Mo0g9LmouxzK9KV3YDZbrhskaOPOO2PBhYEJ O3uA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BxLNYSsg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-53053-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-53053-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCVgxfAM/N3FhdxigVfmDySlILpUUiG1C4SrrxHUg1OuD5jWef0iGHbq+j42mInf8FqxVNI791ig34/Ve6lG8yc9aLSg/4F5gfUYJmW17Q== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g32-20020a631120000000b005d67007b43dsi142491pgl.571.2024.02.05.09.00.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 09:00:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-53053-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BxLNYSsg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-53053-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-53053-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 26BB4283EFE for ; Mon, 5 Feb 2024 16:59:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02A6140BF4; Mon, 5 Feb 2024 16:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BxLNYSsg" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 276AA44C7B; Mon, 5 Feb 2024 16:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707152316; cv=none; b=Fw3Q0OuSX5yzL0Cb4SKcw2d7PCOHSxje7CRGKRNvU7qPPTJ+7AVnSczEbhlbZsbkcn38tDwxcKMhSu4P/SXqDwR88gVYyEbD02HWsvmADWGwU7eu0lwoXgA582+bckKtQZqeqTV/0tPYAi4ry/pG/eWelceaB0cbLoXww4p4LhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707152316; c=relaxed/simple; bh=d3MHcE60+aEolo8yoxGkE+jYHNZc2enKn6A6LrbJtfg=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=m4cVLsUUKDYPBxK2UORkXIfkLFTkW/ySfZqNdftLPp+7/QZhckwIhQlBTksVHrBkrsI7vO05kChGk3pQCxX5IGTC/mcuqtrKBScjoFg9mBTi3PQRXLSbeZFadFOYgqkTBOs5YdeyCfe3TgqClQ5TzpQZjr6KhHkC4Z9gInIycAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BxLNYSsg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E628C433F1; Mon, 5 Feb 2024 16:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707152315; bh=d3MHcE60+aEolo8yoxGkE+jYHNZc2enKn6A6LrbJtfg=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=BxLNYSsgyWXjOQlBq/UM1PQu9D8GiKu7jgV85Pbc7gZldree/qIejh3lw0cGvR3rG mjHGNXTRMV7oftGNdv+wz8bcIhV57ysafTzHPN5+uAUO/G0DsgqW0+mDH5D7ITHeri 5Jq5ddr6NJ0P2KUdljd8c+Cfjw4rgTCL/JWAISw50RsQLVSb3xaZdNHdXkCxktD9dE y5Gk+QYbq06q/JWMe+h3p8z3fg5mw4uVihCMXI1tzis15RJqqCK6vDRGLBXkOhVGLa 3FQyi0Wj++Neairf9Y1DSQjlqgqHqBOqsmK5V0gIotRxkJ11WBc8zoHYMa4heTyCr1 xSpriaNwY7XkA== From: Mark Brown To: Richard Fitzgerald , Dan Carpenter Cc: James Schulman , David Rhodes , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <0c254c07-d1c0-4a5c-a22b-7e135cab032c@moroto.mountain> References: <0c254c07-d1c0-4a5c-a22b-7e135cab032c@moroto.mountain> Subject: Re: [PATCH] ASoC: cs35l56: fix reversed if statement in cs35l56_dspwait_asp1tx_put() Message-Id: <170715231128.801804.92834537524909316.b4-ty@kernel.org> Date: Mon, 05 Feb 2024 16:58:31 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-0438c On Mon, 05 Feb 2024 15:44:30 +0300, Dan Carpenter wrote: > It looks like the "!" character was added accidentally. The > regmap_update_bits_check() function is normally going to succeed. This > means the rest of the function is unreachable and we don't handle the > situation where "changed" is true correctly. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: cs35l56: fix reversed if statement in cs35l56_dspwait_asp1tx_put() commit: 4703b014f28bf7a2e56d1da238ee95ef6c5ce76b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark