Received-SPF: pass (google.com: domain of linux-kernel+bounces-53058-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <93e93056-d75c-4b12-a161-1e410f3ac354@gmx.de>
Date: Mon, 5 Feb 2024 18:02:29 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] platform: x86: wmi: make wmi_bus_type const
To: "Ricardo B. Marliere" <ricardo@marliere.net>,
 Hans de Goede <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20240204-bus_cleanup-platform-drivers-x86-v1-0-1f0839b385c6@marliere.net>
 <20240204-bus_cleanup-platform-drivers-x86-v1-1-1f0839b385c6@marliere.net>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20240204-bus_cleanup-platform-drivers-x86-v1-1-1f0839b385c6@marliere.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:MHFPugB5Jnk=;4B6ZCoPeD6lAfMKPv8cmx6wcsjC
 DwisChEkJqRmA+9kKH5GgptfOFNnSrFgl0Y9t6rMpr9YM9ezS3lKg81y43FrKYEEnWZDTuL2w
 H5G7jvsqQ/zvh2t/17dJsQPKGG8FYL4B7NUVNvuJBHQ1XadtcnueCKdmcTsLzQOTUrJSg55FV
 Lu6ou38z99i4uRfqOcQQZpD4i/DKLsgAeU6PVB5gwqiPh6D+PlUDZxJOzxKljT2tl7tiBYDPx
 SREM/+Luv+JIFZ7cdxnFyCMSDUUwcLdIaHtd4eXFCtJ6oiD6rQ3iBKuIxaKEMGHaP7htr09NI
 4mHLK5DheCGBw+t+8j/dAAC29jYfjkaBe4VN2xljFItadYM3YjeCfboYR43rdmf3fez0uYkSO
 7RIQNfX37eBcdzCYOYC9wkqrlMXssqimbO4HNucxHfKw3ICjkK/XLHxiKkVlJXmi+8cR0ehep
 i29ph+0nXYPmNEdw5QcE5GG/KHYDzQ8wlWp6pYMn+b48lrkPtGy852L6gNbSbA09G8sJUddXs
 iLaXBJgcjNnKhEgCyaTNstLQGIdl6Psc/LsSaKXPKWDTyyQBYxvaBLxeQX5FeGa6fO/dHQuaB
 Kik8RnRDUN/VFHd77YT5W08N7n9LASbry3A3mPZep1MVK4eWmdB8ApnztKqhPSyEpxJV/MYpV
 mXAfjWKrz60eUoh0608dTbZQa0HLW9xqZ2RxluQlrWf+UGTxN8h32RiQJPC5IOn4HLxF0QcEA
 dEOcWE64+iXo10fmB+Vi1L5TtuPl4rgvCp4viPedrBxmsaqr95eilGFRjNSPAIiuDlTfsiX2r
 Io8t//ao1SzV5JO/d5j4gRgF+JEGUGOd1xVYWJAGecMyI=

Am 04.02.24 um 15:40 schrieb Ricardo B. Marliere:

> Now that the driver core can properly handle constant struct bus_type,
> move the wmi_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>   drivers/platform/x86/wmi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 7ef1e82dc61c..859dfff515d0 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -219,7 +219,7 @@ static int wmidev_match_guid(struct device *dev, con=
st void *data)
>   	return 0;
>   }
>
> -static struct bus_type wmi_bus_type;
> +static const struct bus_type wmi_bus_type;
>
>   static struct wmi_device *wmi_find_device_by_guid(const char *guid_str=
ing)
>   {
> @@ -899,7 +899,7 @@ static struct class wmi_bus_class =3D {
>   	.name =3D "wmi_bus",
>   };
>
> -static struct bus_type wmi_bus_type =3D {
> +static const struct bus_type wmi_bus_type =3D {
>   	.name =3D "wmi",
>   	.dev_groups =3D wmi_groups,
>   	.match =3D wmi_dev_match,
>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>