Received-SPF: pass (google.com: domain of linux-kernel+bounces-53123-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Frank Li <Frank.Li@nxp.com>
To: lpieralisi@kernel.org
Cc: Frank.li@nxp.com,
	bhelgaas@google.com,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	festevam@gmail.com,
	helgaas@kernel.org,
	hongxing.zhu@nxp.com,
	imx@lists.linux.dev,
	kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org,
	kw@linux.com,
	l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com,
	linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org,
	manivannan.sadhasivam@linaro.org,
	robh@kernel.org,
	s.hauer@pengutronix.de,
	shawnguo@kernel.org
Subject: [PATCH v10 10/14] PCI: imx6: Add iMX95 PCIe Root Complex support
Date: Mon,  5 Feb 2024 12:33:31 -0500
Message-Id: <20240205173335.1120469-11-Frank.Li@nxp.com>
In-Reply-To: <20240205173335.1120469-1-Frank.Li@nxp.com>
References: <20240205173335.1120469-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YGraCGU6gp3+YU7ipSvW/1iIByDX+Wt1hK2UoAm08D7JDgB9tj4rzv50uEaq?=
 =?us-ascii?Q?pwhw+3preY7Cx0as+zn+xivQ3OfTESxEPH6VDmWvV3plssESvlPBBBwV/OIF?=
 =?us-ascii?Q?s55cpT7iwsG7HrteLlNJvYdtAyZH1IYChLy5wuNVR/gzOMGV0OTD0biwfNIv?=
 =?us-ascii?Q?I2pefxCV+L9H/au3a83w56EIru2obxMbdSf8AAEbG2WKIbWzl5LCwyIWfMJF?=
 =?us-ascii?Q?fqWUYrn6v26CQGdgqfbr7ZNrdmmAx//e2yfueC0XkMEHLiBozeVa2eJ4BLBY?=
 =?us-ascii?Q?kCeVJMNjPMpQQHpU2fcw4hfITCFKAxUaT0AJgW/a2cueKFFC5NV1ZNJurw13?=
 =?us-ascii?Q?Q7gFIWufgYL2/jEowwG+BsaHevfpxJ3jHJsCTaAVeW4Q5iWdRn9mBxgJKYcb?=
 =?us-ascii?Q?m/uI4g86yJc9CBubOkagzxW5/fhDkHRAUz2zZpJd4iRHNIgry3kvmeDeq1xN?=
 =?us-ascii?Q?DqvybT00HSIcSZ8jeT52hpl5fnyGE+CCWKoDr0dBef059/nFrIfy8/ggGvE6?=
 =?us-ascii?Q?04yfMz26n5tzzGCYWf7YLOBAOYshEKeOP4euS1y21FyxPa9vVLcrt0Fcy0OD?=
 =?us-ascii?Q?b84ZmTw2q7OnQG3EOUwhT8E5iG2et0jX8evFjnZvhsKwva/QNkcokYsOLar7?=
 =?us-ascii?Q?MvJaUeFTyU0HULiV/dhmbkmoLCepuqJCHJTd7/TNMbjmHl2EUJgtBGwwijLz?=
 =?us-ascii?Q?2n15RCoZFtcnq+muLaPt/a9rSV4HLFDSzTZTIHQi+kh/dfa3M9vJ/HIMGat5?=
 =?us-ascii?Q?QpFlzmpH/JkvrTOstYGOqk+vYE6KVjC5StPU7UcMcYEIXXrXbbrZ5tAogd/Y?=
 =?us-ascii?Q?3WhaR9asV2bY2KzEty1fXVrVVjzPbNAqxyWUHy6EcNGxDCHuY8RgylVrQJD2?=
 =?us-ascii?Q?Vi4hWOnwhlG37Mu01rYd+rE5AEhQo3qidsA7PxBMjVDtTFOlIPEg9kUdEarK?=
 =?us-ascii?Q?btZF549LHQ8z10ys6OcqMRKcTdfpDYlvs1OFMZjCvZgSLd8drEOpjD0SIiYj?=
 =?us-ascii?Q?itQ9+g9+ctvkilHkdP6TewlpuPlB+f6ZcBhG9V+51ws8wmTvnKSrJqZ3fj27?=
 =?us-ascii?Q?MtfYykVT7dVONgSTjwfmzr9ZcfWoB2wBjEvB1UUgw3Ki1Qi89OLcICtUEafg?=
 =?us-ascii?Q?bCVN9VsZCKkLXcMp2jo6x+/ARExuvjG8p5yco8ebfiyycMhzMNDcjISDhWtM?=
 =?us-ascii?Q?/hHxzFWZnw/eQ1VaeEePkuMlTYBANj9lBPSA+z5+1d1sHLlBkZOgM7zkTjeZ?=
 =?us-ascii?Q?MB4/nhXYs9Q8T9B0fqYhC1tmDCxMEFWS8QTCUgZOHSzxFgMBdBjU7axKKJD6?=
 =?us-ascii?Q?HbI0BcWba0clO6TP7sGlUT3zD0u7I+s/XcXs7FAINcIxlsw7ReKW/oEOHSUR?=
 =?us-ascii?Q?vgLRhAj/dI3oJY3bTBXJOyVlTgHbLrgxChG+tGQ4y4E6zw6YgqNgk426jNQC?=
 =?us-ascii?Q?4+9RXeJUqs0qFoEfr3Hzi2avxo9vI3G0Ter8eDVGySEkkiezrvbD4yIMvF/K?=
 =?us-ascii?Q?J+eWpnA2gFbwaRsMWCbJWbBfZuYZ9dYtEo9fhuU9SLUb481pTHfZiM5C3/Y0?=
 =?us-ascii?Q?dSK2lNrUrNHRmJtDC83OZItBZw8X6+X32NY18EGR?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e391cde1-76b3-40b5-946a-08dc2670bde9
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 17:34:44.5618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i7O5FhPCXaE0CgKUeh64GTOX2IuFZLxDnLvvdY5JvdhTZbNsTa79S717IdnLhw1F9Qlqj7LguSr0BBC90ACDDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7080

Add iMX95 PCIe Root Complex support.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v8 to v9
    - Add mani's review tag
    
    Change from v7 to v8
    - Update commit subject
    - add const from regmap
    - remove unnessary logic in imx6_pcie_deassert_core_reset()
    
    Change from v4 to v7
    - none
    Change from v1 to v3
    - none

 drivers/pci/controller/dwc/pci-imx6.c | 82 +++++++++++++++++++++++++--
 1 file changed, 77 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index c266b9f098a5b..183bb3b31cf16 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -42,6 +42,25 @@
 #define IMX8MQ_GPR12_PCIE2_CTRL_DEVICE_TYPE	GENMASK(11, 8)
 #define IMX8MQ_PCIE2_BASE_ADDR			0x33c00000
 
+#define IMX95_PCIE_PHY_GEN_CTRL			0x0
+#define IMX95_PCIE_REF_USE_PAD			BIT(17)
+
+#define IMX95_PCIE_PHY_MPLLA_CTRL		0x10
+#define IMX95_PCIE_PHY_MPLL_STATE		BIT(30)
+
+#define IMX95_PCIE_SS_RW_REG_0			0xf0
+#define IMX95_PCIE_REF_CLKEN			BIT(23)
+#define IMX95_PCIE_PHY_CR_PARA_SEL		BIT(9)
+
+#define IMX95_PE0_GEN_CTRL_1			0x1050
+#define IMX95_PCIE_DEVICE_TYPE			GENMASK(3, 0)
+
+#define IMX95_PE0_GEN_CTRL_3			0x1058
+#define IMX95_PCIE_LTSSM_EN			BIT(0)
+
+#define IMX95_PE0_PM_STS			0x1064
+#define IMX95_PCIE_PM_LINKST_IN_L2		BIT(14)
+
 #define to_imx6_pcie(x)	dev_get_drvdata((x)->dev)
 
 enum imx6_pcie_variants {
@@ -52,6 +71,7 @@ enum imx6_pcie_variants {
 	IMX8MQ,
 	IMX8MM,
 	IMX8MP,
+	IMX95,
 	IMX8MQ_EP,
 	IMX8MM_EP,
 	IMX8MP_EP,
@@ -63,6 +83,7 @@ enum imx6_pcie_variants {
 #define IMX6_PCIE_FLAG_HAS_PHYDRV			BIT(3)
 #define IMX6_PCIE_FLAG_HAS_APP_RESET		BIT(4)
 #define IMX6_PCIE_FLAG_HAS_PHY_RESET		BIT(5)
+#define IMX6_PCIE_FLAG_HAS_SERDES		BIT(6)
 
 #define imx6_check_flag(pci, val)     (pci->drvdata->flags & val)
 
@@ -179,6 +200,24 @@ static unsigned int imx6_pcie_grp_offset(const struct imx6_pcie *imx6_pcie)
 	return imx6_pcie->controller_id == 1 ? IOMUXC_GPR16 : IOMUXC_GPR14;
 }
 
+static int imx95_pcie_init_phy(struct imx6_pcie *imx6_pcie)
+{
+	regmap_update_bits(imx6_pcie->iomuxc_gpr,
+			IMX95_PCIE_SS_RW_REG_0,
+			IMX95_PCIE_PHY_CR_PARA_SEL,
+			IMX95_PCIE_PHY_CR_PARA_SEL);
+
+	regmap_update_bits(imx6_pcie->iomuxc_gpr,
+			   IMX95_PCIE_PHY_GEN_CTRL,
+			   IMX95_PCIE_REF_USE_PAD, 0);
+	regmap_update_bits(imx6_pcie->iomuxc_gpr,
+			   IMX95_PCIE_SS_RW_REG_0,
+			   IMX95_PCIE_REF_CLKEN,
+			   IMX95_PCIE_REF_CLKEN);
+
+	return 0;
+}
+
 static void imx6_pcie_configure_type(struct imx6_pcie *imx6_pcie)
 {
 	const struct imx6_pcie_drvdata *drvdata = imx6_pcie->drvdata;
@@ -575,6 +614,7 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie)
 				   IMX6Q_GPR1_PCIE_REF_CLK_EN, 1 << 16);
 		break;
 	case IMX7D:
+	case IMX95:
 		break;
 	case IMX8MM:
 	case IMX8MM_EP:
@@ -1278,12 +1318,32 @@ static int imx6_pcie_probe(struct platform_device *pdev)
 		return PTR_ERR(imx6_pcie->turnoff_reset);
 	}
 
+	if (imx6_pcie->drvdata->gpr) {
 	/* Grab GPR config register range */
-	imx6_pcie->iomuxc_gpr =
-		 syscon_regmap_lookup_by_compatible(imx6_pcie->drvdata->gpr);
-	if (IS_ERR(imx6_pcie->iomuxc_gpr)) {
-		dev_err(dev, "unable to find iomuxc registers\n");
-		return PTR_ERR(imx6_pcie->iomuxc_gpr);
+		imx6_pcie->iomuxc_gpr =
+			 syscon_regmap_lookup_by_compatible(imx6_pcie->drvdata->gpr);
+		if (IS_ERR(imx6_pcie->iomuxc_gpr))
+			return dev_err_probe(dev, PTR_ERR(imx6_pcie->iomuxc_gpr),
+					     "unable to find iomuxc registers\n");
+	}
+
+	if (imx6_check_flag(imx6_pcie, IMX6_PCIE_FLAG_HAS_SERDES)) {
+		void __iomem *off = devm_platform_ioremap_resource_byname(pdev, "app");
+
+		if (IS_ERR(off))
+			return dev_err_probe(dev, PTR_ERR(off),
+					     "unable to find serdes registers\n");
+
+		static const struct regmap_config regmap_config = {
+			.reg_bits = 32,
+			.val_bits = 32,
+			.reg_stride = 4,
+		};
+
+		imx6_pcie->iomuxc_gpr = devm_regmap_init_mmio(dev, off, &regmap_config);
+		if (IS_ERR(imx6_pcie->iomuxc_gpr))
+			return dev_err_probe(dev, PTR_ERR(imx6_pcie->iomuxc_gpr),
+					     "unable to find iomuxc registers\n");
 	}
 
 	/* Grab PCIe PHY Tx Settings */
@@ -1456,6 +1516,17 @@ static const struct imx6_pcie_drvdata drvdata[] = {
 		.mode_off[0] = IOMUXC_GPR12,
 		.mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE,
 	},
+	[IMX95] = {
+		.variant = IMX95,
+		.flags = IMX6_PCIE_FLAG_HAS_SERDES,
+		.clk_names = imx8mq_clks,
+		.clks_cnt = ARRAY_SIZE(imx8mq_clks),
+		.ltssm_off = IMX95_PE0_GEN_CTRL_3,
+		.ltssm_mask = IMX95_PCIE_LTSSM_EN,
+		.mode_off[0]  = IMX95_PE0_GEN_CTRL_1,
+		.mode_mask[0] = IMX95_PCIE_DEVICE_TYPE,
+		.init_phy = imx95_pcie_init_phy,
+	},
 	[IMX8MQ_EP] = {
 		.variant = IMX8MQ_EP,
 		.flags = IMX6_PCIE_FLAG_HAS_APP_RESET |
@@ -1500,6 +1571,7 @@ static const struct of_device_id imx6_pcie_of_match[] = {
 	{ .compatible = "fsl,imx8mq-pcie", .data = &drvdata[IMX8MQ], },
 	{ .compatible = "fsl,imx8mm-pcie", .data = &drvdata[IMX8MM], },
 	{ .compatible = "fsl,imx8mp-pcie", .data = &drvdata[IMX8MP], },
+	{ .compatible = "fsl,imx95-pcie", .data = &drvdata[IMX95], },
 	{ .compatible = "fsl,imx8mq-pcie-ep", .data = &drvdata[IMX8MQ_EP], },
 	{ .compatible = "fsl,imx8mm-pcie-ep", .data = &drvdata[IMX8MM_EP], },
 	{ .compatible = "fsl,imx8mp-pcie-ep", .data = &drvdata[IMX8MP_EP], },
-- 
2.34.1