Received-SPF: pass (google.com: domain of linux-kernel+bounces-53124-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Frank Li <Frank.Li@nxp.com>
To: lpieralisi@kernel.org
Cc: Frank.li@nxp.com,
	bhelgaas@google.com,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	festevam@gmail.com,
	helgaas@kernel.org,
	hongxing.zhu@nxp.com,
	imx@lists.linux.dev,
	kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org,
	kw@linux.com,
	l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com,
	linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org,
	manivannan.sadhasivam@linaro.org,
	robh@kernel.org,
	s.hauer@pengutronix.de,
	shawnguo@kernel.org
Subject: [PATCH v10 11/14] PCI: imx6: Clean up get addr_space code
Date: Mon,  5 Feb 2024 12:33:32 -0500
Message-Id: <20240205173335.1120469-12-Frank.Li@nxp.com>
In-Reply-To: <20240205173335.1120469-1-Frank.Li@nxp.com>
References: <20240205173335.1120469-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vwTRG6AlC7PyFudBofRP3UPT4OiMXVVDwzdm1DKfirCQ2HYK22YktE50KNRv?=
 =?us-ascii?Q?Iry5wyzMQSdjJoWZIxcuCF4eh5EgisKg1nvQWG2goKvuRyu+y0SyUkxOvO97?=
 =?us-ascii?Q?2Qs1k1c825NspUHvXpK1tqFjxcRAlHGhzPEDyz1S57VawZ+3J/b3kMbFvbjG?=
 =?us-ascii?Q?WPk/xM2VTtbH/XtYFhEiY/Uq524OO9OEahS7TP9dXdVoQqm26lUTjwpvm/t0?=
 =?us-ascii?Q?kalq+CXdDnen74FuaXX/Wdsp4LhybBgtraIrFFieTYZMuSJwdCRETF956Nmm?=
 =?us-ascii?Q?Rf9nU9FYPxhtGidiVvLRaE+fMuyjc0w701qXIUdrigGYubmFIo6slkcigihP?=
 =?us-ascii?Q?CNM5v6zLfx3wbTPWrKKCl1k48yPry0J2g8C8kyfFrRn0bcyvISlE4Tlhu27M?=
 =?us-ascii?Q?kXWE3Q7VkU6UnHxsfVBcYY1CTYu3u+scKbFWA/V0EQSRKKsHxI9XamZgdigG?=
 =?us-ascii?Q?79GfWB/haiHz8PCALAZqtFt7dEvggFyJR6+/7iqlw2Fh5bQA+sMCXyk0EEW1?=
 =?us-ascii?Q?gqbxmnnd/BoPSDGLIGD51y2x6gMoaS3Bu0BYYVNbr2W/d4mat+bbWjTIuTur?=
 =?us-ascii?Q?usQIzyzzf6gEaofoCRh/R0WdZv/ZTZ6Z2n/cSlr8zjJr+k1L+Xsjt0Ea80ms?=
 =?us-ascii?Q?E6Itz6Yzo4ri5CiWLrmlythKbB1rY8lUzHug091gwHVq5jzyQ6k/+3zK1o1V?=
 =?us-ascii?Q?nFXkBiirEwf1w4EtV1HNsP7q+MTe7IFBHcRIpY2rwYkwIUvCRhzMrlTnEikN?=
 =?us-ascii?Q?mHAIiCYws0gvUF6smS9T7vTzpWVTArja6wpuTsFQMR30vnK8ENT2c2zGBUyh?=
 =?us-ascii?Q?Nw1hW9TYw5v6g2omU6M9HJabZD3B8WvjKj15TRsWlxlaJLqVEuFj9gCmIDSm?=
 =?us-ascii?Q?SLqNo2RzPjH/82YJveDAfgNHFgK6EufLjRars+vd8FcD/hyvVZpp8Smha6as?=
 =?us-ascii?Q?DhlAwW08TCqa22+BClLjRDzj48iZVE2Eufqk3OSvGGif8EzXOAkOGyr+2mdg?=
 =?us-ascii?Q?0nArzbigtVHe70FZprlaCkVfVgrV3pUk7K8EFpQ76x22E2z8bcK1LrxYA/nC?=
 =?us-ascii?Q?eKeBvHTS1PBHpZj9TA6OYs2WwbD+12caLruJd83kLeaUSDKnH6hUWWTJ5VDm?=
 =?us-ascii?Q?UchtysU7fnD6y5btYBpGUeQ9dqStuHG8XkIv7lPDrMilA+J5x5ZXpZ0iy3v4?=
 =?us-ascii?Q?lbSqT6NJ0TGmSuX4r9XZ1mn2yLfdJk0msK1qspB1kxSskpt5gtz/y10oBdmt?=
 =?us-ascii?Q?jpP96fHOJtVnGa3uMrsBtl9Jw4R21KdQgqnQxdIKC27mHj7o5R5oM3RYB6ED?=
 =?us-ascii?Q?156CwllUzdVbspcfVSEqyQpAJ8HdCUMvHulRcz1gReBGNi82OlkHsCGrosPV?=
 =?us-ascii?Q?fdm6RyZ4R2B5OaooodDlbZKmUmU0cj7VbnDv6/MuA06o3IVTT45ILS2fLqmG?=
 =?us-ascii?Q?T6tMuEOzZwpPKNKhoE5C0JIM7oq0JDzXqW4Ug0H8qsXlSZ8zf3UD1Usb5WSI?=
 =?us-ascii?Q?di+FLuqK/775xOqjMHIjUIqdWy4PGl2uMEVpjlADZERK63xPxGdSbgDdfj5N?=
 =?us-ascii?Q?fF1HHwqY/bcaGa+Wf0R64V266rSKq/hMhQbK7FGd?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8508d75-76e0-4d18-fd92-08dc2670c0d6
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 17:34:49.4823
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j0OQuysQUW4RpbUYuGQ7F0RuKPufXQDYu8+0XpMrG1TptCF4rHMtjycwu7Jhjo26TBE525qhRV2C0q8A4eckdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7080

Since the dw_pcie_ep_init() function is already fetching the 'addr_space'
region, no need to do the same in this driver.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v7 to v8
    - update commit message
    - Add Manivannan Sadhasivam's review tag
    Change from v4 to v7
    - none
    Change from v1 to v3
    - new patches

 drivers/pci/controller/dwc/pci-imx6.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 183bb3b31cf16..9cc6802e93641 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1067,7 +1067,6 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 	int ret;
 	unsigned int pcie_dbi2_offset;
 	struct dw_pcie_ep *ep;
-	struct resource *res;
 	struct dw_pcie *pci = imx6_pcie->pci;
 	struct dw_pcie_rp *pp = &pci->pp;
 	struct device *dev = pci->dev;
@@ -1086,14 +1085,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 		pcie_dbi2_offset = SZ_4K;
 		break;
 	}
-	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
-	if (!res)
-		return -EINVAL;
 
-	ep->phys_base = res->start;
-	ep->addr_size = resource_size(res);
-	ep->page_size = SZ_64K;
+	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
 
 	ret = dw_pcie_ep_init(ep);
 	if (ret) {
-- 
2.34.1