Received-SPF: pass (google.com: domain of linux-kernel+bounces-53106-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240204-bus_cleanup-memstick-v1-1-14809d4405d8@marliere.net>
In-Reply-To: <20240204-bus_cleanup-memstick-v1-1-14809d4405d8@marliere.net>
From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Mon, 5 Feb 2024 18:28:40 +0100
Message-ID: <CAPDyKFqkJjdc5vNr-wisTPXqf+2ORsBkcOZUS+LyaktpN-cCKA@mail.gmail.com>
Subject: Re: [PATCH] memstick: core: make memstick_bus_type const
To: "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>, Alex Dubov <oakad@yahoo.com>, linux-mmc@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"

On Sun, 4 Feb 2024 at 21:05, Ricardo B. Marliere <ricardo@marliere.net> wrote:
>
> Now that the driver core can properly handle constant struct bus_type,
> move the memstick_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/memstick/core/memstick.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c
> index bbfaf6536903..23fea51ecbdd 100644
> --- a/drivers/memstick/core/memstick.c
> +++ b/drivers/memstick/core/memstick.c
> @@ -164,7 +164,7 @@ static struct attribute *memstick_dev_attrs[] = {
>  };
>  ATTRIBUTE_GROUPS(memstick_dev);
>
> -static struct bus_type memstick_bus_type = {
> +static const struct bus_type memstick_bus_type = {
>         .name           = "memstick",
>         .dev_groups     = memstick_dev_groups,
>         .match          = memstick_bus_match,
>
> ---
> base-commit: 4e99ffb173faaf38f010acb369bff57a20e9e531
> change-id: 20240204-bus_cleanup-memstick-071b3564d808
>
> Best regards,
> --
> Ricardo B. Marliere <ricardo@marliere.net>
>