Received-SPF: pass (google.com: domain of linux-kernel+bounces-53137-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 5 Feb 2024 12:43:49 -0500
From: Frank Li <Frank.li@nxp.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Rob Herring <robh@kernel.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, imx@lists.linux.dev,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 5/6] dt-bindings: PCI: dwc: Add 'msg' register region
Message-ID: <ZcEeVc1y/V7jPay2@lizhi-Precision-Tower-5810>
References: <20240202-pme_msg-v3-0-ff2af57a02ad@nxp.com>
 <20240202-pme_msg-v3-5-ff2af57a02ad@nxp.com>
 <eg7wrjp5ebz43g37fvebr44nwkoh4rptbtyu76nalbmgbbnqke@4zugpgwesyqd>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eg7wrjp5ebz43g37fvebr44nwkoh4rptbtyu76nalbmgbbnqke@4zugpgwesyqd>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RdDskFce42UDUn4U9IovSFmhMPds84ch8+abTOfdFkSAwx2I8k4sZBtC1moX?=
 =?us-ascii?Q?2vV6Eq4VmQiFDF3y1NgQuyTwKTxCPVySnDfGL4h47BVX9Lp60v3g6pUDFkLz?=
 =?us-ascii?Q?it63ubj9cW0gckNtxy8ocmsLAHYDvPNaxqK6IE122aZKtoUgrK8OhjMgJQBj?=
 =?us-ascii?Q?DRKtA4H7RbssQQBvubQN5pu5/9f19gTE+eCs+COHAx7coCjCA1B9P+mlOz0/?=
 =?us-ascii?Q?ZRoPBq40M0FCwQjUzNifyyrxtkfTOrHObK8ZnG1b1FEWmjAO+YiOUpnplY2/?=
 =?us-ascii?Q?/fueNaecVHlbVbzl3I8bhQxKNx+0oEwMubuitKpn4iKBpadT2LV43Q3m+rnu?=
 =?us-ascii?Q?0oN8hTMNjXtaNPvvJNmdRP2u+N0LhyKlUZFnCZyKtGqi8uWrlM8gtS7leTfu?=
 =?us-ascii?Q?W6E75lJlrpeLTDpIggXqSerma7O1dFnfD4lpZwcG26n5ARFYRmBkbJlFUa/a?=
 =?us-ascii?Q?AlTajvDD0Fz7s2n/i+7CHIlFGqDCRfjcfIUJG4ZLxK8dtFMxvBfDPCNPTm2U?=
 =?us-ascii?Q?dua5Yez9VhrjdE22RTLDZtAaT6W/B8iBxsAi2dRyq4+HYU4vG35X4rvie5CA?=
 =?us-ascii?Q?d2wLRZZuGfh11GmNsoIx6aogQ9v3aCSCvYorsgPuthN1BgFOebYW3tNJky76?=
 =?us-ascii?Q?7/QJFdO15fE/CjYOHN/8rN9JHYrXmvlclPaOD28mlJM1ZCzbQUBhhM6KvqN7?=
 =?us-ascii?Q?9mfLwkRmsoAe8r73AZaTrM67KKiUb0f/USBnXkyf3cA4ZUcF9wiClx5U1SFT?=
 =?us-ascii?Q?8yWvccl7yaScpGPDq312eUUDvuy/Rh1eY2E28vHokG+pHO+UUmsa7vcaaC+1?=
 =?us-ascii?Q?oPs76I9RPtrgwvj8WutXJMmV9P/XWu9r5L1+Veu7uQ5LNxGmB0IsmArcxClC?=
 =?us-ascii?Q?ccQbLKjjYRtYMH2UHZqI0SPlzXWCbGTWECwvtHSBvBMfE3K/vxS4mP+bPpgF?=
 =?us-ascii?Q?FgXUfbfzv8+aCyxLYM23eWgzmUMgIwx9LDgPMlQ2aCCfAQR9HW3HpKQLhrLv?=
 =?us-ascii?Q?rwHaST6uzpuzS5BD3VrysDySZlTqa/tS0D5/4jcxPgAZhX+BNiny7G/aqBMo?=
 =?us-ascii?Q?hBVPIaH++sFFyEoIyW8GWklRTbNYYVJ2ur7zVk2TMbsYXhFEa8GZokfY+dNU?=
 =?us-ascii?Q?Oq34A5qPu4p7eB8DpIv08lX/7a7IFKkUX9Cmivs0qc2yhauJEyKOcUq2IYP6?=
 =?us-ascii?Q?2ywVvQw8sKR9bd9yac5XTc9JXzsoYaZQ5oQ1N9lbqGN7R+DKkzsMx5n047qq?=
 =?us-ascii?Q?9HJnTK9hz8/u5utxFQRjVnMUXl0rT8roN67AQtkbn3W6Wpu2jjXoxCzWGkXj?=
 =?us-ascii?Q?4S9C3VJ165BL+7eR/kzGtZ1SlCpTRhvuz6wnNexqc2IGDbxvwiRNU5ZBWjwu?=
 =?us-ascii?Q?PkclLzZiR4NX36mpEYHpjkp/KTIQgzK2TRrMtvNA3O3DTN8QT6VroDCLWTsm?=
 =?us-ascii?Q?xe+ty8OcFLFzGM7t+T1nTdndsn+7uWuXt8SvEVosBw6kdhLEwUO/gjxkEpaF?=
 =?us-ascii?Q?b+q53sFaHLbdBoNPTiLd8Lr+ZRxHP/uRvPXF6LAKrafpBs/B5ENIJUI7zeeZ?=
 =?us-ascii?Q?piI0aquzpVvmKkwQeF4=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13abe6ef-9376-440c-da54-08dc2672094e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 17:44:00.4865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vaHl9CAbXwlNmGN4eFviJIrdc4vEg2SW/kRaGnKCt2HuJFS+scktTG/567iWv5Y/OTMHqxB/WkhgbwBt/uRJdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7733

On Sat, Feb 03, 2024 at 01:44:31AM +0300, Serge Semin wrote:
> On Fri, Feb 02, 2024 at 10:11:27AM -0500, Frank Li wrote:
> > Add an outbound iATU-capable memory-region which will be used to send PCIe
> > message (such as PME_Turn_Off) to peripheral. So all platforms can use
> > common method to send out PME_Turn_Off message by using one outbound iATU.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > index 022055edbf9e6..25a5420a9ce1e 100644
> > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > @@ -101,6 +101,10 @@ properties:
> 
> >              Outbound iATU-capable memory-region which will be used to access
> >              the peripheral PCIe devices configuration space.
> >            const: config
> > +        - description:
> > +            Outbound iATU-capable memory-region which will be used to send
> > +            PCIe message (such as PME_Turn_Off) to peripheral.
> > +          const: msg
> 
> Note there is a good chance Rob won't like this change. AFAIR he
> already expressed a concern regarding having the "config" reg-name
> describing a memory space within the outbound iATU memory which is
> normally defined by the "ranges" property. Adding a new reg-entry with
> similar semantics I guess won't receive warm welcome.
> 
> -Serge(y)

Okay, Anyone from device-tree give comments about this?

@rob, krzysztof kozlowski

Frank
> 
> 
> >          - description:
> >              Vendor-specific CSR names. Consider using the generic names above
> >              for new bindings.
> > 
> > -- 
> > 2.34.1
> > 
> >