Message-ID: <476A9E27.8060302@sgi.com>
Date: Thu, 20 Dec 2007 08:53:59 -0800
From: Mike Travis <travis@sgi.com>
User-Agent: Thunderbird 2.0.0.6 (X11/20070801)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: Yinghai Lu <Yinghai.Lu@Sun.COM>, Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: not needed patch
References: <200712192057.02500.yinghai.lu@sun.com> <20071220142906.GA20794@elte.hu> <476A983F.1060704@sgi.com> <20071220163352.GA6930@elte.hu>
In-Reply-To: <20071220163352.GA6930@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 29

Ingo Molnar wrote:
> * Mike Travis <travis@sgi.com> wrote:
> 
>>>> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could 
>>>> use c->cpu_index in identify_cpu.
>>> but that's 2.6.25 stuff, right? Travis?
>>>
>> Looking at this more closely, yes my change is not needed and should 
>> be removed.  I'm not sure what caused my cpu # to be all zeros when I 
>> was testing, but it now works ok without my change.
> 
> how about this question:
> 
>>> well, it might in the worst-case be a superfluous change, but not 
>>> cause any problems in 2.6.24, right?
> 
> 	Ingo

I don't think it hurts anything except as noted, it wouldn't be available
to the subfunctions (like identify_cpu) that might need the cpu_index
(which also is noted that none currently do.)  

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/