Received-SPF: pass (google.com: domain of linux-kernel+bounces-53133-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 5 Feb 2024 12:41:15 -0500
From: Frank Li <Frank.li@nxp.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: manivannan.sadhasivam@linaro.org, bhelgaas@google.com,
	conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com,
	helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev,
	kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org, kw@linux.com,
	l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, robh@kernel.org, s.hauer@pengutronix.de,
	shawnguo@kernel.org
Subject: Re: [PATCH v9 05/16] PCI: imx6: Using "linux,pci-domain" as slot ID
Message-ID: <ZcEdu9Jw1k6Kwuz4@lizhi-Precision-Tower-5810>
References: <20240119171122.3057511-1-Frank.Li@nxp.com>
 <20240119171122.3057511-6-Frank.Li@nxp.com>
 <ZbzcOarorCS1MPRc@lpieralisi>
 <ZbztZkNQ+wydticD@lizhi-Precision-Tower-5810>
 <Zb06JL5X8EiHEyFD@lpieralisi>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zb06JL5X8EiHEyFD@lpieralisi>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3XUGtfnxay9DDCW85AUdL5RTKuZyVWyXw11gsweQ4jp4wm7nGKxIjdD8IplJ?=
 =?us-ascii?Q?SZqItA+mUd3mMYUf4m1+uL0MqBy6KYzCjRJ6GHVJishb+Amx8ozft5dUCemc?=
 =?us-ascii?Q?znOmr1K0TU2NidIjPCFJrSdf0mDbHHNhd45fr8jBI8mATZ6lZoqx0WvWUX6r?=
 =?us-ascii?Q?GSpDcP1eodpsjPn1R3GE1Xpnb+znNTNwen6uGZTCxwsAl7Yjj9lhA2pthHNU?=
 =?us-ascii?Q?dvJCAHL4vNCx0+v98zvvzSqbTdl1f38lKYAl4ZNSya+dqGq9MYllITfLdgYT?=
 =?us-ascii?Q?nKBCAGOUGbpAO4oX+1eXFYBZLFMJjSa5zPU+89KjfSnOef/+W47dofY3WI9K?=
 =?us-ascii?Q?poQTIYsogLdERCGkJhyhQcbdzaM3GatlAi/Zx6qesMx1V4PstDUj2uHhdSEn?=
 =?us-ascii?Q?M/KqHJvkJHvpDcz8n86NTyhMZho9G/OIq8MtkSMT075uBFTHIvSRhU+a7sCT?=
 =?us-ascii?Q?GndVIlRxVWhdYE1HUuZpZcgo1PY2L7ozLUOBbSeRXdImADxnx/a0tZEFBKdX?=
 =?us-ascii?Q?hXlU90b37WcAoqNYp/JR28CKYUUjG9OEn7Bv5PVEkpyDwfNE2E3ffYOT+ZzT?=
 =?us-ascii?Q?ekTki+hN38FOiEP5kx5lyh2FkDInCtJw5FYROS7Rxjee/OYBa/LbnHY/gPdV?=
 =?us-ascii?Q?WlqaRbz8eUMOGFA2UQSXSx1QCaUVDSNpooFRlNzAKKRxmxgKayHCHRK8T76Q?=
 =?us-ascii?Q?XkxFmiiREuwXYsbL1FQaOpqn5read+ZFiPlIE9BKar5JJRWbABXlyiHSTB66?=
 =?us-ascii?Q?nWsHEkUlihtuqne/mB4cVwsQBkpig2ba4NKAVeKTmilXbnBSYJAfFVUMUKqG?=
 =?us-ascii?Q?/y+bbjGzr30PgHiMa7MuQi/M1k6NpOrOE4x1oAnPjCbMOdZbysmQph3I6IMk?=
 =?us-ascii?Q?0aef/bkyqyunX1Y1K1W2u8/crxxmb6O0dCelmgmdvZ024pGkdRZhrLUY9sdI?=
 =?us-ascii?Q?P2X4nLgPScYX8WA0YGiQe7lnyg2VtmFEODNja3ZdDZkni2w+eAsX+mQ8LgCt?=
 =?us-ascii?Q?LWDrrzF2NdcSE7NL+yAshngpQ5/SGAxrRdKD3ebn6yzL0mMS97xowcuJZNep?=
 =?us-ascii?Q?bJQikO4ZvpXwJwG9cZhE1uc/pMbs8pBg3zerC0IoygmLKZYvXXhDYri9fYAd?=
 =?us-ascii?Q?c/aRCzoZUqZ3lWDO9RqKc4fWzyU/jaZzqsHRtGIFRnjkApxVgyUO1rGeTPOw?=
 =?us-ascii?Q?FvN3072xY3KXf8sS9qJbuQ/rx8ZNPrqJ8kADQrYqJm9AI4PHTBUkwt27O2Rf?=
 =?us-ascii?Q?z4KCV4NkN2BE6nuL6GNf+zZA0MFaTL6SfXtDIHhEvMzN/dqPGP0PeqFQE27t?=
 =?us-ascii?Q?qBei335CGryMlcOgwkV6rnXoA+RyAycMMae9iBefOJcb5VYhq0w9S/0lxdNr?=
 =?us-ascii?Q?4s3JGjM0C7MFTPnUzOwWw5BEf5oR20IXgzBG1IgSFGkfTe/fO0upFJ3i2ajy?=
 =?us-ascii?Q?Uv+3psFmfRyRTDpK+bBNYaJumya1S9HXJSWWRDXz90fe/17MmPiGCZnBejzS?=
 =?us-ascii?Q?VDNspNAdmNA5QGUvbIwon4mMk8eQPHXjxH0Y6hzAN/sKjdIK5F3fdtWx1jtt?=
 =?us-ascii?Q?pmFaxYLXwYCovn/4bxgzJlMQKsIuu+XARtihWjPO?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f5e9413-a3d7-46d1-c2c9-08dc2671ac91
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 17:41:24.9498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AXZDWo+JhIWHb/1FxB2Ix1vfu6we6pj0UEBoZq0ao4qI4tP9BD8RTMuSEHPG50yA8wru6BR8WXCZCZiOUxfoMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7733

On Fri, Feb 02, 2024 at 07:53:24PM +0100, Lorenzo Pieralisi wrote:
> On Fri, Feb 02, 2024 at 08:25:58AM -0500, Frank Li wrote:
> > On Fri, Feb 02, 2024 at 01:12:41PM +0100, Lorenzo Pieralisi wrote:
> > > "PCI: imx6: Use "linux,pci-domain" as slot ID"
> > > 
> > > On Fri, Jan 19, 2024 at 12:11:11PM -0500, Frank Li wrote:
> > > > Avoid use get slot id by compared with register physical address. If there
> > > > are more than 2 slots, compared logic will become complex.
> > > > 
> > > > "linux,pci-domain" already exist at dts since commit:
> > > > 	commit (c0b70f05c87f3b arm64: dts: imx8mq: use_dt_domains for pci node).
> > > > 
> > > > So it is safe to remove compare basic address code:
> > > > 	...
> > > > 	if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> > > > 		imx6_pcie->controller_id = 1;
> > > 
> > > No it is not unless you magically update all firmware out
> > > there in the field.
> > 
> > commit c0b70f05c87f3b09b391027c6f056d0facf331ef
> > Author:     Peng Fan <peng.fan@nxp.com>
> > AuthorDate: Fri Jan 15 11:26:57 2021 +0800
> > Commit:     Shawn Guo <shawnguo@kernel.org>
> > CommitDate: Fri Jan 29 14:46:28 2021 +0800
> > 
> > I am not sure if it is neccesary to compatible with 2 years ago's dts.
> > I think it may not boot at all with using 2 year agao dtb file directly.
> > 
> > Do you have other comments? I can remove it from this big patch series,
> 
> I will have a look at the full series first we can decide whether
> to drop it later.
> 
> I am travelling so I am not sure I can review it before February
> 12th, FYI.

Okay, I send v10 at
https://lore.kernel.org/imx/Zb06JL5X8EiHEyFD@lpieralisi/raw
which removed "linux,pci-domain" patches.

If you have more comments, please comment at v10 version.

Frank


> 
> Lorenzo