Received-SPF: pass (google.com: domain of linux-kernel+bounces-53175-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <5cfbdb015154919d24967aec4cec5890760c1dd5.camel@perches.com>
Subject: Re: [PATCH 1/2] checkpatch: tolerate long lines w/o spaces
From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>, linux-kernel@vger.kernel.org, 
	akpm@linuxfoundation.org
Date: Mon, 05 Feb 2024 10:02:13 -0800
In-Reply-To: <20240203195527.212505-2-jim.cromie@gmail.com>
References: <20240203195527.212505-1-jim.cromie@gmail.com>
	 <20240203195527.212505-2-jim.cromie@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Sat, 2024-02-03 at 12:55 -0700, Jim Cromie wrote:
> checkpatch complains about long lines (>75 chars), but allows a few
> exceptions:
>=20
>  file delta changes
>  filename then :
>  A Fixes:, link or signature tag line
>=20
> Add another exception, to allow a long "word" without whitespace.  The
> regex allows spaces in 1st 10 chars, so it allows the following [1],
> which current checkpatch carps about.
>=20
> [1] https://lore.kernel.org/lkml/20200825153338.17061-1-vincent.whitchurc=
h@axis.com
>=20
> Dummy-tag: test-generic-tag-format-with-url-length-bla-bla-jeez-dont-give=
-up-now-there.
>=20
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
>  scripts/checkpatch.pl | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9c4c4a61bc83..dc17c6da3af2 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3271,6 +3271,8 @@ sub process {
>  					# filename then :
>  		      $line =3D~ /^\s*(?:Fixes:|$link_tags_search|$signature_tags)/i |=
|
>  					# A Fixes:, link or signature tag line
> +		      $line =3D~ /^.{10}\S+$/ ||
> +					# a long single "word" without whitespace

Perhaps better would be
		      $line =3D! /^(?:\S+\s+)?\S+$/ ||

=09
>  		      $commit_log_possible_stack_dump)) {
>  			WARN("COMMIT_LOG_LONG_LINE",
>  			     "Prefer a maximum 75 chars per line (possible unwrapped commit d=
escription?)\n" . $herecurr);