Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935010AbXLTRQq (ORCPT ); Thu, 20 Dec 2007 12:16:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760157AbXLTRQd (ORCPT ); Thu, 20 Dec 2007 12:16:33 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:34405 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759966AbXLTRQc (ORCPT ); Thu, 20 Dec 2007 12:16:32 -0500 Date: Thu, 20 Dec 2007 09:16:03 -0800 From: Stephen Hemminger To: parag.warudkar@gmail.com Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sky2: Use deferrable timer for watchdog Message-ID: <20071220091603.0d69b045@deepthought> In-Reply-To: References: Organization: Linux Foundation X-Mailer: Claws Mail 2.10.0 (GTK+ 2.12.0; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1916 Lines: 46 On Tue, 18 Dec 2007 20:13:28 -0500 (EST) Parag Warudkar wrote: > > sky2 can use deferrable timer for watchdog - reduces wakeups from idle per > second. > > Signed-off-by: Parag Warudkar > > --- linux-2.6/drivers/net/sky2.c 2007-12-07 10:04:39.000000000 -0500 > +++ linux-2.6-work/drivers/net/sky2.c 2007-12-18 20:07:58.000000000 -0500 > @@ -4230,7 +4230,10 @@ > sky2_show_addr(dev1); > } > > - setup_timer(&hw->watchdog_timer, sky2_watchdog, (unsigned long) hw); > + hw->watchdog_timer.function = sky2_watchdog; > + hw->watchdog_timer.data = (unsigned long) hw; > + init_timer_deferrable(&hw->watchdog_timer); > + > INIT_WORK(&hw->restart_work, sky2_restart); > > pci_set_drvdata(pdev, hw); Does it really reduce the wakeup's or only change who gets charged by powertop? The system is going to wakeup once a second anyway. Looks to me that if the timer is using round_jiffies(), that setting deferrable just changes the accounting. My interpretation of the api is: * round_jiffies() - timer wants to wakeup but isn't precise about when so schedule on next second when system will wake up anyway; e.g why meetings are usually scheduled on the hour * deferrable - timer doesn't have to really wakeup but wants to happen near a particular time. e.g. "I'll meet you at the pub around 8pm" Therefore doing deferrable is unnecessary for timers using round_jiffies unless system is so good at doing timers that it is going to skip doing timer once per second. -- Stephen Hemminger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/