Received-SPF: pass (google.com: domain of linux-kernel+bounces-53797-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a12a0bf1-c59d-4b87-87ac-546f0f5e8d72@gmx.net>
Date: Mon, 5 Feb 2024 20:06:25 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 00/12] Add support for BCM2712 DMA engine
Content-Language: en-US
To: Andrea della Porta <andrea.porta@suse.com>, Vinod Koul
 <vkoul@kernel.org>, Florian Fainelli <florian.fainelli@broadcom.com>,
 Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>, dmaengine@vger.kernel.org,
 linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org
Cc: Maxime Ripard <maxime@cerno.tech>, Dom Cobley <popcornmix@gmail.com>,
 Phil Elwell <phil@raspberrypi.com>
References: <cover.1706948717.git.andrea.porta@suse.com>
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <cover.1706948717.git.andrea.porta@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:D0ByTQ4dxtk=;wVGIfcHu2aqaBPu4fkqTwf9T5Wz
 sthJxR2uEffnPYrkNDt7HwyWrQuU8aOC/YFD3SQsSE8hLvz67vi7VM0cjLvXZ0CitMAZp8SGD
 17s2jUrjvNo1IWDtoA4AQi2Dr4MiaphAs89o3WBvv2BgRUZmlG5ub0Us5irBWEGAlONyRPAKU
 Sj0ObMkaSAsEGYtnSq2KOLFGLsI8q26ec8GhaBZqjOephWoC1IqDkeDJkVb09X9KiErCmhTfO
 B2zBfvF44ruSXlZI5GWqSsxjadCajaL2AyMfGSnXocfYMoRv8+ECMhoTuweZJAZ2JVbGXRAbi
 nHQy8rkUd9r+2yRiayNrrcwg91gUvL7H+6mmvwodXCjUxJfydJyHEBSnKLquYVTyS9S29ZJLc
 vomggZHaG6lHgaug6clsoRk5PFM7zR3d3KJ45X7oHkdt0p+UOu5QHaSlcca4Jh8eIfGiOj9uq
 sPiuxJDyl9aT7C3bV7AJFRBNOOW3ehBVuFfd86t/mEQOloAKScTnVRozFb18coNui+TcE0Izi
 leFf/NVBxuZlknRpygDQjz74Fk7ID7W3zYTPBrKGEH9vrtKeN1t8KtIfhOYl+P0kc7XnPaIyA
 46QxH5847H1XTP57224inOS65uUzIPcGVZpphwIMv6003dP/TnPbjEEp4T++/IlJYhtXWpQPy
 b/cNvq506jtn6PdVARCbvxDKZLhWWqp1i6IbII7lpvRl6gD0dAf3azK2Gfn9dF4ZJ4Gy5OnMM
 72DrFB5oAlDmcQ864YogPaNglENiSk4L2fqVegyG9+HCt/BP7KRmZjplqrMoYC0WPn1o+/P4A
 ZJ3hfRM8ZGYtvxGkipp6Dwtb40d0cOLYIb7cbPP9Pj6oI=

Hi Andrea,

Am 04.02.24 um 07:59 schrieb Andrea della Porta:
> This patchset aims to update the dma engine for BCM* chipset with respec=
t
> to current advancements in downstream vendor tree. In particular:
>
> * Added support for BCM2712 DMA.
> * Extended DMA addressing to 40 bit. Since BCM2711 also supports 40 bit =
addressing,
> it will also benefit from the update.
> * Handled the devicetree node from vendor dts (e.g. "dma40").
>
> The only difference between the application of this patch and the relati=
ve code
> in vendor tree is the dropping of channel reservation for BCM2708 DMA le=
gacy
> driver, that seems to have not made its way to upstream anyway, and it's
> probably used only from deprecated subsystems.
>
> Compile tested and runtime tested on RPi4B only.
sorry but this is not sufficient. AFAIK only the Raspberry Pi 5 has a
BCM2712. I suggest to start with BCM2711 40 bit support, which is enough
work.

This whole series does neither contain a change to the dt-bindings nor
to the DTS files. This is not how it works.

Best regards
>
> Dom Cobley (4):
>    bcm2835-dma: Support dma flags for multi-beat burst
>    bcm2835-dma: Need to keep PROT bits set in CS on 40bit controller
>    dmaengine: bcm2835: Rename to_bcm2711_cbaddr to to_40bit_cbaddr
>    bcm2835-dma: Fixes for dma_abort
>
> Maxime Ripard (2):
>    dmaengine: bcm2835: Use to_bcm2711_cbaddr where relevant
>    dmaengine: bcm2835: Support DMA-Lite channels
>
> Phil Elwell (6):
>    bcm2835-dma: Add support for per-channel flags
>    bcm2835-dma: Add proper 40-bit DMA support
>    bcm2835-dma: Add NO_WAIT_RESP, DMA_WIDE_SOURCE and DMA_WIDE_DEST flag
>    bcm2835-dma: Advertise the full DMA range
>    bcm2835-dma: Derive slave DMA addresses correctly
>    dmaengine: bcm2835: Add BCM2712 support
>
>   drivers/dma/bcm2835-dma.c | 701 ++++++++++++++++++++++++++++++++------
>   1 file changed, 588 insertions(+), 113 deletions(-)
>