Received-SPF: pass (google.com: domain of linux-kernel+bounces-53805-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 5 Feb 2024 11:13:57 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>, "Peter
 Zijlstra" <peterz@infradead.org>, Dan Williams <dan.j.williams@intel.com>,
	<linux-kernel@vger.kernel.org>
CC: Ingo Molnar <mingo@kernel.org>, <linux-cxl@vger.kernel.org>, "Fabio M. De
 Francesco" <fabio.maria.de.francesco@linux.intel.com>, Ira Weiny
	<ira.weiny@intel.com>
Subject: RE: [PATCH 1/2] cleanup: Add cond_guard() to conditional guards
Message-ID: <65c133751a7_4e7f52946@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240204173105.935612-1-fabio.maria.de.francesco@linux.intel.com>
 <20240204173105.935612-2-fabio.maria.de.francesco@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240204173105.935612-2-fabio.maria.de.francesco@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m9foP7Hv+xIJ0Ua+SSv8/a6tkbe42v2Ih65LQtxytoen3HMmjcsLU3TCtNMI?=
 =?us-ascii?Q?p0QBtJxAmSTfKyMqN9Tx5fMd99rsiCdKgzmOHldxKiWTG59aJv4ACVwC2TK+?=
 =?us-ascii?Q?C4ICuUdwfgtRx57Q+tY60141RubErFL+Vt2+DYk8yWqtP/QC17jRvQGMNchS?=
 =?us-ascii?Q?l07VigNWECFjUYS6bwLtXkduMeDr+16P99y05vgFZYRObv7976bjvq3v7XQv?=
 =?us-ascii?Q?VEO7FJQ0JELY/dkrg3PxDQ27fb7x9Yh2XPuQhyceA3Tj6QiL7mJ9GGP+AYvB?=
 =?us-ascii?Q?mvsJjkFJLKzJDebDKTZbYngDV2DzsKyRMjYe7PuEzdaQpF10vJZY9EqrCmZL?=
 =?us-ascii?Q?ZB9wq0DaD36mYzTjO4OQsQyWMHFb6DUY6InFcIJQKFucm7pkCiBcKqHQQT7x?=
 =?us-ascii?Q?0WC1oOGLkPDXei1zz5Tqr5ci2VKAPYkoWmk9PuCgAqR+wIV8FazLs0u+mYw8?=
 =?us-ascii?Q?jPcu1Bsu7DWaT+qZUKoN32b18jGEAByiQ5JHV6npaMgUQCngKBEi9ZJfdJ56?=
 =?us-ascii?Q?lrR4A6Dc/7EYRN/X+YX5zag9gaGvSWhI0AQnujH73TczCc+NJ6NVFZ1hSqlA?=
 =?us-ascii?Q?nZfzRKDsQkdHhxqMaZxhskJe1jspV/iQ5e275QkvOhpypXwR1AAWj68hPUn8?=
 =?us-ascii?Q?YxfOeUYJbOZswfs7+aNnjlrmPgGaagTuHtJk57GJAQjHI5VConTq5l+47Pa/?=
 =?us-ascii?Q?bdoS9ggJnGdfcoNj6nWac+ZkVy7UG2AyE2SaxcUNTaT/8r9zOTFuoBCtn2gi?=
 =?us-ascii?Q?sxRKIZWFBIspkWXTLLDlf/GSuFm+k+zU3rJ7jwNKeBJT1AoKImXatXV4vo51?=
 =?us-ascii?Q?gdFzZUW10uk/BIFwtIAeLk5BJ9Z11qR0blZCN6tDbyRS0E98Rj3ruBMnevw+?=
 =?us-ascii?Q?SKOSTjn6iI1U4+xZan+blvYVk6W1mzMR2kynPVsVrYdwvqKqcpv/kjEyTQ6P?=
 =?us-ascii?Q?gYiznP1luAQUrRANPFBOclms2rDBF1TNomosFFVKjAcJPLTrT1mM6r7v/7RF?=
 =?us-ascii?Q?I2gBvi6eI+IuCYsky15BzUxRWQw6HfjC7wwxNWW94pSzZNJXe+xeLnFywUv0?=
 =?us-ascii?Q?XcG7Vwpcqh5GdPFraKkn/xbI8NrJhMAz3SPvCeRqNAUnBHn5+qncpnCKAbVU?=
 =?us-ascii?Q?VBkJ1PKXXgzcISemHz/2DhOMbJh0jkW8Ej+fDOL999DCpVV+SJu+aDqpOQgE?=
 =?us-ascii?Q?fDJFtb+ZYVYxKgDRPuxO8GWHVwmadttQX18KwLIS9TcmEFFveqlyWlTzzimi?=
 =?us-ascii?Q?PhioA2SbKVtGJ82ThWb+Fhgi/iUa3yAU9s1iaDVGyramE6bbaB64P2Vot5wm?=
 =?us-ascii?Q?sPb2AGB5asOYmfFsdfmLCctoVqJMq8H+2/DnpsvPAGty9xR2C7SquGoR+8yC?=
 =?us-ascii?Q?hxC+slGPdFHIDyP43fN+uvTtvOOpL4B3IgfFAF80eh7JBYdP1K/4NxeTSWl/?=
 =?us-ascii?Q?zglIGbdP7nlGxWv2AE7s312KKKP1sI/ivcgGKKJRqD6aCCpUkCwaIbiwztpa?=
 =?us-ascii?Q?IJbIjZlDJaq1wk70kNWbu8Pk4j1gpOMYWd8fzEnqzAAyojwpmDXJcDP2+IBX?=
 =?us-ascii?Q?2VYIDIBYYJ5PxarxWpDWx99b+2bye+csXBIiWJguZo2LEhz+CPrGsGD0D2Ys?=
 =?us-ascii?Q?2A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b67175ce-2157-40be-d526-08dc267e9b18
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 19:13:59.1431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GhmlZqSbd1MnF4J0UvYmuaKKI6R/5ym1nsWGF9KT4OZf/h6+752DJgoCt8WUjAI9q0RU1ZPJfq08yZFdUYjuGFPkZJQTWF6QXC2lykITAqE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7989
X-OriginatorOrg: intel.com

Fabio M. De Francesco wrote:
> Add cond_guard() macro to conditional guards.
> 
> cond_guard() is a guard to be used with the conditional variants of locks,
> like down_read_trylock() or mutex_lock_interruptible().
> 
> It takes a statement (or more statements in a block) that is passed to its

s/or more statements in a block/or statement-expression)/

s/to its/as its/

> second argument. That statement (or block) is executed if waiting for a
> lock is interrupted or if a _trylock() fails in case of contention.
> 
> Usage example:
> 
> 	cond_guard(rwsem_read_try, { printk(...); return 0; }, &semaphore);

Missed commenting on this in the last posting, but multi-statement fail
cases that print and return 0 are unlikely to ever be the common case. I
think the most simple to understand example is an interruptible lock
that returns -EINTR on failure:

	cond_guard(mutex_intr, return -EINTR, &mutex);

..and then maybe mention that _fail can be a statement-expression if
needed.

> Consistenly with the other guards, locks are unlocked at the exit of the

s/Consistenly with the other guards/Consistent with other usage of guard()/