Received-SPF: pass (google.com: domain of linux-kernel+bounces-53804-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 5 Feb 2024 14:13:37 -0500
From: Frank Li <Frank.li@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, imx@lists.linux.dev,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 5/6] dt-bindings: PCI: dwc: Add 'msg' register region
Message-ID: <ZcEzYdZKotBJlR5i@lizhi-Precision-Tower-5810>
References: <20240202-pme_msg-v3-0-ff2af57a02ad@nxp.com>
 <20240202-pme_msg-v3-5-ff2af57a02ad@nxp.com>
 <eg7wrjp5ebz43g37fvebr44nwkoh4rptbtyu76nalbmgbbnqke@4zugpgwesyqd>
 <20240205183048.GA3818249-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240205183048.GA3818249-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8Q8BN8T3LqAKPCO0EyP/U2Z2GJ3IOb8Dj5lzeeiFWg59PbKVpNHqfZTCkiTn?=
 =?us-ascii?Q?k+Ss56sCtkQ2mSQaKAbPSrgiMCSZKJKCshOK9Gf/3SU1SvV9gbvqrySlc6sP?=
 =?us-ascii?Q?WSybrEhQuVqhzGq+gLewtYrl+HbB3MqDxsA+FoBGYGIFBQqfl7iFmU065I/P?=
 =?us-ascii?Q?yMNFfddPsRFockXYIo3ztPaQph1Vi7JjrGx1zq1d15yfNXirsEQiUeGQtZE0?=
 =?us-ascii?Q?0AgVo2QrmHrLM7uXGaWgwvNT/HNjcuubw894ZAvtygPsvqE5DVnGyMJQ4Ut6?=
 =?us-ascii?Q?esyfmZcli3FysHP9iFB1AnrGldfsMO6f4K4qah7vIx9T2TVD9Mg2zdLo6zds?=
 =?us-ascii?Q?EHFgq7u1W28bsH1Yc6S4PszjbQ450209/pmSID9G32CXzowCGTVI3gUkScrh?=
 =?us-ascii?Q?mP/FpczqVO6kEZ7xn7TNd7V76/Xd+TQnGiTKxQ8/d5offu80HtvIdlLO3gDn?=
 =?us-ascii?Q?rOxnWHAoXXLXnP0LShXPMDCCPE25pXIraYoyhc0kutYzfPSJ1+OFqjvzg3mF?=
 =?us-ascii?Q?5pkv7tAFhk6mjbCLqU/4496CsaKCebVdsTlkSsZZSHvcuxFX6gz+rBXuvNlr?=
 =?us-ascii?Q?1IU9+0eiDeCZ2zYIQs7/YbcLk+3fU6yyOKG79JJv0yFxKBqJgx8txKvasOau?=
 =?us-ascii?Q?BZSoK8byOsWuquiGyIWtaTac0ILn/CyljGMHb5s+aQLg4E5A47sRIoGneLlA?=
 =?us-ascii?Q?3a9St4SFg6SMmtS8R7XpPYs3F3d4CLkDR1LHW/dnYoblQ8RTXghPiYXeYMQ4?=
 =?us-ascii?Q?DMobdU4Oy5ZBqR38gt7TbaKKmEarT70Q9SqU1p0OHrRJubM7c9lGmekReuDy?=
 =?us-ascii?Q?sf2UMcjBpbZKSbtN/upuKVbyWt2Uzpdc7M6l+ZTR0XIUYUNsBu0cfMajMQZc?=
 =?us-ascii?Q?qA6zM7AJaKwuwkIwsFlmRS22Fa6IAWllaCz0p4G3/OEZtmg8jmcfrpUeB9tC?=
 =?us-ascii?Q?EvqrqxWwElM+ssixg4ZQ6STUULjpyVZuIJleVHobXuDnfdBTIlT2JAatsx48?=
 =?us-ascii?Q?QV+LOu/AQRVhwpCq7pmMTGgbmxA7xD1wn04UPPILRGIkb+Y0o84NjyDfLUa+?=
 =?us-ascii?Q?Ti0arn98hXdYUNUAkfOwFlxjU1qhjSngQvXWHgsg0J2BQCxkX8EqA3D1T6lQ?=
 =?us-ascii?Q?IkEDVo0Um8i8cgpI0WwZkPlRcw+nPNm43EQAzjcysDNaxMhqL5yllOMStzFC?=
 =?us-ascii?Q?jay9L2FQZT3XtCVVQ6Due8VIHubN2IiQcKvbMRhyy0PCxdqWHyGj60ubIK6K?=
 =?us-ascii?Q?EFpIhglD/WO83Z7IveDyJiiRB0PyVKeWsvud9YjzzwlLru6SzGz9M1S6Ofoo?=
 =?us-ascii?Q?LfBmd9EldtlYh+uMrcE0QMBJG9YGfk2xvmhlYl9QcRpfkmIpSoCvD95oA2pe?=
 =?us-ascii?Q?uMmAdJTqGii4petfGo0vtzy2HZzPkS0JEyxo0PDL+YKh5ag3JJmbu13DH+Ad?=
 =?us-ascii?Q?xhWk6uZznFwPIPQ4HVOYH0+oBujtXwhLWsWCaEPGlwbXWTeHOIes3HxwNTEx?=
 =?us-ascii?Q?iiifnK6g1wNta/KDvgH53qacybf/mmma0jfn3e3E4vMk54sQRLUZsZqHYAWN?=
 =?us-ascii?Q?/4fLP7geVNnzqSfQWY5QdA4ws7l+eDkTpzxA+2LS?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92cfcc8e-cc3e-4776-0f71-08dc267e931f
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 19:13:45.6904
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eb9eWbqkLDB2gWSXu3H9+EM+xJuX09zPeApdbdQdn06booo8PlJvf1cwZuytBtlGKS0QWK7wL8FaPRWX6fCp0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8286

On Mon, Feb 05, 2024 at 06:30:48PM +0000, Rob Herring wrote:
> On Sat, Feb 03, 2024 at 01:44:31AM +0300, Serge Semin wrote:
> > On Fri, Feb 02, 2024 at 10:11:27AM -0500, Frank Li wrote:
> > > Add an outbound iATU-capable memory-region which will be used to send PCIe
> > > message (such as PME_Turn_Off) to peripheral. So all platforms can use
> > > common method to send out PME_Turn_Off message by using one outbound iATU.
> > > 
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > > index 022055edbf9e6..25a5420a9ce1e 100644
> > > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > > @@ -101,6 +101,10 @@ properties:
> > 
> > >              Outbound iATU-capable memory-region which will be used to access
> > >              the peripheral PCIe devices configuration space.
> > >            const: config
> > > +        - description:
> > > +            Outbound iATU-capable memory-region which will be used to send
> > > +            PCIe message (such as PME_Turn_Off) to peripheral.
> > > +          const: msg
> > 
> > Note there is a good chance Rob won't like this change. AFAIR he
> > already expressed a concern regarding having the "config" reg-name
> > describing a memory space within the outbound iATU memory which is
> > normally defined by the "ranges" property. Adding a new reg-entry with
> > similar semantics I guess won't receive warm welcome.
> 
> I do think it is a bit questionable. Ideally, the driver could 
> just configure this on its own. However, since we don't describe all of 
> the CPU address space (that's input to the iATU) already, that's not 
> going to be possible. I suppose we could fix that, but then config space 
> would have to be handled differently too.

Sorry, I have not understand what your means. Do you means, you want
a "cpu-space", for example, 0x8000000 - 0x9000000 for all ATU. 

Then allocated some space to 'config', 'io', 'memory' and this 'msg'.

Frank

> 
> Rob