Received-SPF: pass (google.com: domain of linux-kernel+bounces-53904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 5 Feb 2024 12:19:20 -0800
From: Eric Biggers <ebiggers@kernel.org>
To: Kshitiz Varshney <kshitiz.varshney@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Varun Sethi <V.Sethi@nxp.com>, Gaurav Jain <gaurav.jain@nxp.com>,
	Pankaj Gupta <pankaj.gupta@nxp.com>,
	Sahil Malhotra <sahil.malhotra@nxp.com>,
	Vabhav Sharma <vabhav.sharma@nxp.com>,
	Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
	Rahul Kumar Yadav <rahulkumar.yadav@nxp.com>,
	Nikhil Singla <nikhil.singla@nxp.com>, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Enable config for sm3, sm4, polyval, xctr cipher test
 as built in module.
Message-ID: <20240205201920.GA2220@sol.localdomain>
References: <20240205112933.3084766-1-kshitiz.varshney@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240205112933.3084766-1-kshitiz.varshney@nxp.com>

On Mon, Feb 05, 2024 at 12:29:33PM +0100, Kshitiz Varshney wrote:
> Issue:-
> Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> 
> skcipher: failed to allocate transform for xctr(aes): -2
> alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
> alg: self-tests for sm3 using sm3 failed (rc=-2)
> tcrypt: failed to load transform for sm3: -2
> alg: hash: failed to allocate transform for polyval: -2
> alg: self-tests for polyval using polyval failed (rc=-2)
> 
> Resolution:-
> Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
> CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of
> sm3, sm4, aria, polyval & xctr.
> 
> Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>

This looks like an issue in tcrypt.  When algorithms are unavailable it should
consider the corresponding test cases to be skipped, not failed.

>  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++

There should be no need to enable every crypto algorithm in every defconfig
file.  Can you consider fixing the underlying issue instead of doing that?

- Eric