Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2665912rdb; Mon, 5 Feb 2024 13:45:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+G4uXtYcJmrbpVpsCgSSiBxaZAM0MKSgfRoL5T5meh/83R1aOBgeqXU9ynvwodEkaREn/ X-Received: by 2002:a05:6870:e38f:b0:219:8bb1:dbe0 with SMTP id x15-20020a056870e38f00b002198bb1dbe0mr1074685oad.23.1707169532859; Mon, 05 Feb 2024 13:45:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707169532; cv=pass; d=google.com; s=arc-20160816; b=a7NgDYUur87OF/oxiprTh7azLtSyBcgbqyCeUSiN48vQl2SDTd105odmqpH7jcaS7L D5Fk0kpB5WffOaMeCgXhFA+onK9vzAuMrY6lwfWvqlBu0yiOAmuuR57A+HZVvqewuzdP lQxmpNM84oiRMA2xsSkEZ+RCVXyrngnjL+AJC3/7XSYrx3nXxpI711dwRFOXT+9AeC6X qRQvOzWvjYQ2AiH2toI0VwRbJ33f7rUkHdJGMMzpIPzlhwdovKKhiYeC0BNgXfew6zZl HSJhzzxs/xvN1xpvhOc1QId1Cp5nbcjvXVNPGUMYSjEBT/9QXzNHLmaN4cb7FxbmEjkE YUtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OnPs4J2FLqlSi9AAQWsy8ks+h3XUSpaDvBaw8zXZYQA=; fh=uuWvuEZkqT224rcv5cKkH7+2rSOy3uuH1wurYWA7lzw=; b=Bl63dFHVCpkjLCrvcoOUJEmS1BCIUwSoPcoPiXjxNl06mSvyWxAnodiMKDRIZnfovh /mkbu8xZKN7N6x+gtA+ypcwVWs40ExGpzlsebJv7iFwXVmRJImP8/6fHgHDJLuHekaoG W3YBh+4I99bIWmFw8i6aq5Ihi7oTWjfCy9Whiou36tpr0F8Xsz5/XimL4Mkgu6RGzn3Y Iz3qbHzyHAxTaXK15XDnQR8Nrx1FxUpas8OHjBnYYTmYTHJMY5v44vQpeBRa1djADbTk rk4gposuvbzzCB4OFZyzacFsxbcS+3LsFGpLEXMBK0hmV90GwYg5zowbE+9OM0X7OxXz K0UQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IQU23IF+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-53908-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-53908-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCX3z5riHnEpLxQ/+IiVuSmXUefkQYXNpTlKJ85DkKDpuQeirM1r28nus3TweaMnnbQZxBgIL7QNgOH0tXjyAI3TNH9jK/TEArrU9eQD1g== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b13-20020ac8754d000000b0042c3433682csi100702qtr.456.2024.02.05.13.45.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 13:45:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-53908-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IQU23IF+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-53908-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-53908-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EEC091C26948 for ; Mon, 5 Feb 2024 21:45:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA78B13246A; Mon, 5 Feb 2024 20:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IQU23IF+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD220131E5A; Mon, 5 Feb 2024 20:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707164507; cv=none; b=NMg+hc3Q9zc4gNZULBeJBJ2apBS6l9Zs39/+mrZKFozAIEOqeihYiN8hS/ebD9C/lA37aQnTGdMgGIA9W6WgU+9UYPmz8rWcdGlTK8YwydPoKZ8OQtnp3R05DmY1UcUjxNfEyggypeJZ9/8fQ7SMGyT30DXIhMf0fmC6NNxdMEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707164507; c=relaxed/simple; bh=OnPs4J2FLqlSi9AAQWsy8ks+h3XUSpaDvBaw8zXZYQA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X3D5vZkXdnSRGmdA+HjiAJRXaNwuiGmVBA3vUtChjRTc4p9SgOoFocaNbp6Flc5g3ANh0XlXtk7Dpgbcw3WM22UsnIz6OcZNM2OZqcwBUxrieO7qWKryHyGAyiXWzABXVI4sQwvHR7HU40q3LcKCL87EMDS6sc8v5wpHD1qw1ag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IQU23IF+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19B56C43390; Mon, 5 Feb 2024 20:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707164507; bh=OnPs4J2FLqlSi9AAQWsy8ks+h3XUSpaDvBaw8zXZYQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IQU23IF+/34JM5UsTXGwn1C4ycg82FIgulYTDDJ9CBWTOVB/n/X7uBYLMm7HSPgOt i+cus8mTPvjvjWEo4Aw26/x+dVoCCXUrwTTrzecCMmq+SBzrp9nfk9IercDvb/RwxT 60Im7bvxKSTFCnoDeHhyDNoIejyAnkKYwaeGXQo07Iux7rQSwW4qTiC3MD1ZcO0PYb EAX/V+f/52BeppcBvGr7nKWXYNc/L9JrAs3rGrw+zEfnDgQXSSADSCk1Dbi0ozS+Ic dVlJSnCocWslszkJWVahgh0jize4v/cZQL49RK3IbzeFVyHTre40nQz6BvOkKyMxDi 0l0JHCnpGM3WA== Date: Mon, 5 Feb 2024 12:21:45 -0800 From: Eric Biggers To: Kees Cook Cc: linux-hardening@vger.kernel.org, Rasmus Villemoes , Mark Rutland , "Gustavo A. R. Silva" , Marco Elver , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] overflow: Introduce add_wrap(), sub_wrap(), and mul_wrap() Message-ID: <20240205202145.GB2220@sol.localdomain> References: <20240205090854.make.507-kees@kernel.org> <20240205091233.1357377-2-keescook@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205091233.1357377-2-keescook@chromium.org> On Mon, Feb 05, 2024 at 01:12:30AM -0800, Kees Cook wrote: > Subject: Re: [PATCH v3 2/3] overflow: Introduce add_wrap(), sub_wrap(), and mul_wrap() Maybe these should be called wrapping_add, wrapping_sub, and wrapping_mul? Those names are more grammatically correct, and Rust chose those names too. - Eric